Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: fatal null crashing just some time after loading  (Read 487 times)

kur0pur0

  • Ensign
  • *
  • Posts: 3
    • View Profile
fatal null crashing just some time after loading
« on: May 02, 2023, 03:13:40 PM »

so i have been playing for a few hours now without problems but suddenly past a certain point now, i keep getting crashes and fatal null errors that i dont completly understand
the game was doing fine, and it happens just travelling in a system or the hyperspace, and even loading some recently older saves is still making the same error again! for some reason, i dont get it, on why it sudedenly started happening.

- here is a snip of the log

1816813 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.util.ConcurrentModificationException
java.util.ConcurrentModificationException
   at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
   at java.util.ArrayList$Itr.next(Unknown Source)
   at com.fs.starfarer.campaign.econ.Market.reapplyConditions(Unknown Source)
   at com.fs.starfarer.campaign.econ.Market.advance(Unknown Source)
   at com.fs.starfarer.campaign.econ.Economy.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
1817045 [Thread-9] INFO  sound.public  - Creating streaming player for music with id [miscallenous_corvus_campaign_music.ogg]
1817045 [Thread-9] INFO  sound.OooO  - Playing music with id [miscallenous_corvus_campaign_music.ogg]
(if this post goes live, is because for some reason the forum is not letting me post the topic when i upload the file.)


also for mods

Spoiler
ENABLED MODS
pantera_ANewLevel30-30 2.1: A New Level of Confidence
AI-Retrofits-0.7.19.1: AI-Retrofit
all_the_domain_drones+NewDrones-0.6D: All the Domain Drones+ New Drones
armaa-2.23: Arma Armatura
automatedcommands-1.1a: Automated Commands
timid_admins-1.86: Better Colonies
better_variants-1.2.0: Better Variants
chatter-1.13.1: Combat Chatter
aaacrew_replacer-0.6.1: Crew Replacer
diableavionics-2.7.0rc3: Diable Avionics
forge_production-1.1.1: Forge Production
gflportraitpack-1.8.0: Girls Frontline Portrait Pack
gflportraitpack2-1.1.3: Girls Frontline Portrait Pack Part 2
illustrated_entities-1.1.a: Illustrated.Entities
IndEvo-3.2.c: Industrial.Evolution
lw_lazylib-2.7b: LazyLib
exshippack-0.60: Machina Void Shipyards
MagicLib-0.46.1-rc03: MagicLib
nexerelin-0.10.6d: Nexerelin
planet_search-1.2.0: Planet Search
secretsofthefrontier-0.13.1: Secrets of the Frontier
spacetruckin-1.2: Space Truckin'
speedUp-0.7.2: SpeedUp
sun_starship_legends-2.2.2: Starship Legends
stelnet-2.6.2: Stellar Networks
tahlan-0.9RC3: Tahlan Shipworks
Terraforming & Station Construction-8.2.1: Terraforming & Station Construction
star_federation-0.99 RC3: The Star Federation
va11portraits-1.2: VA11 HALL-A Portrait Pack
variants_lib-0.2.0: Variants Lib
aaamarketRetrofits-0.1: market retrofits
shaderLib-1.6.1: zz GraphicsLib

[close]
« Last Edit: May 02, 2023, 03:26:21 PM by kur0pur0 »
Logged

Naimod

  • Ensign
  • *
  • Posts: 22
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #1 on: May 03, 2023, 07:28:55 AM »

practically the same issue for me as well.

Quote
1164350 [Thread-10] INFO  sound.public  - Creating streaming player for music with id [miscallenous_corvus_campaign_music.ogg]
1164350 [Thread-10] INFO  sound.OooO  - Playing music with id [miscallenous_corvus_campaign_music.ogg]
1164508 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.util.ConcurrentModificationException
java.util.ConcurrentModificationException
   at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
   at java.util.ArrayList$Itr.next(Unknown Source)
   at com.fs.starfarer.campaign.econ.Market.reapplyConditions(Unknown Source)
   at com.fs.starfarer.campaign.econ.Market.advance(Unknown Source)
   at com.fs.starfarer.campaign.econ.Economy.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

Only tested my latest save file though. It always happens a bit after I beat one Legio Raid, and MVS sends another raid (they're allied)
not sure if that's relevant but those are the only consistent things that I can mark before my game crashes.

Quote
{"enabledMods": [
  "yunrutechmining",
  "AI-Retrofits",
  "adjustableautomatedships",
  "Adjusted Sector",
  "chatter",
  "cmutils",
  "aaacrew_replacer",
  "diyplanets",
  "edshipyard",
  "HexShields",
  "HSHPortrait Pack",
  "illustrated_entities",
  "IndEvo",
  "lw_lazylib",
  "exshippack",
  "MagicLib",
  "nexerelin",
  "omgbp_omegablueprints",
  "remnant_defectors",
  "tahlan_scalartech",
  "swp",
  "tahlan",
  "TrulyAutomatedShips",
  "uaf",
  "ungp",
  "aaamarketRetrofits",
  "shaderLib"
]}
Logged

basileus

  • Commander
  • ***
  • Posts: 133
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #2 on: May 03, 2023, 07:41:12 AM »

Did you guys recently update any mods?
Logged

Naimod

  • Ensign
  • *
  • Posts: 22
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #3 on: May 03, 2023, 07:43:11 AM »

Did you guys recently update any mods?

Not for me. I was actually thinking that updating some mods might fix this.

EDIT:
Tried updating magiclib
now I get the same exact error log as OP

192820 [Thread-3] INFO  sound.public  - Cleaning up music with id [campaign_music_part_2_v28.ogg]
192824 [Thread-7] INFO  sound.public  - Cleaning up music with id [miscallenous_corvus_campaign_music.ogg]
193085 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.util.ConcurrentModificationException
java.util.ConcurrentModificationException
   at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
   at java.util.ArrayList$Itr.next(Unknown Source)
   at com.fs.starfarer.campaign.econ.Market.reapplyConditions(Unknown Source)
   at com.fs.starfarer.campaign.econ.Market.advance(Unknown Source)
   at com.fs.starfarer.campaign.econ.Economy.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
193235 [Thread-10] INFO  sound.public  - Creating streaming player for music with id [miscallenous_corvus_campaign_music.ogg]
193235 [Thread-10] INFO  sound.OooO  - Playing music with id [miscallenous_corvus_campaign_music.ogg]
« Last Edit: May 03, 2023, 08:26:11 AM by Naimod »
Logged

basileus

  • Commander
  • ***
  • Posts: 133
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #4 on: May 03, 2023, 09:28:49 AM »

The curious thing is that the call stack is entirely from the game API without any mod method calls.

The error itself relates to an ArrayList being modified while it's being iterated.  It could either be the result of using the wrong type of loop being used or a multi-thread concurrency issue. 

It could be that a mod is modifying the ArrayList from another thread, and either the mod or the game itself haven't declared it to be a synchronizedList.

Considering the call stack, this may actually be something for Alex to take a look at.
Logged

Naimod

  • Ensign
  • *
  • Posts: 22
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #5 on: May 03, 2023, 09:57:28 AM »

here's hoping there's a fix. I just got into peak enjoyment on my current save
Logged

float

  • Captain
  • ****
  • Posts: 275
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #6 on: May 03, 2023, 10:17:29 AM »

There's a good chance that some mod is trying to remove a market condition via removeCondition inside a loop over that market's conditions. The error isn't caught until the next time the conditions list is iterated over, which happens to happen in the base game code.
Logged

Naimod

  • Ensign
  • *
  • Posts: 22
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #7 on: May 03, 2023, 11:06:43 AM »

There's a good chance that some mod is trying to remove a market condition via removeCondition inside a loop over that market's conditions. The error isn't caught until the next time the conditions list is iterated over, which happens to happen in the base game code.

If that’s the case, it could be AI retrofits. It lets you build colonies that are essentially ran by robots. It kind of messes with the usual demands of industries.

But it could be other mods as well like Industrial revolution.
Logged

basileus

  • Commander
  • ***
  • Posts: 133
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #8 on: May 03, 2023, 02:16:43 PM »

If that’s the case, it could be AI retrofits. It lets you build colonies that are essentially ran by robots. It kind of messes with the usual demands of industries.

Yes, I think there's a very good chance that it's either from that mod or its MarketRetrofits dependency.  You should post a bug report in one of those threads and remind Alaric that it's not possible to either remove or modify elements from within an enhanced for loop.
Logged

kur0pur0

  • Ensign
  • *
  • Posts: 3
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #9 on: May 03, 2023, 02:27:38 PM »

HMM, well those are some really nice insights thank you,tho  it doesnt seem ai retrofit like a mod that can be removed and keep playing normally on that save if thats the case...wich is a shame i suppose, guess i might try another game for a bit i will try and if it happens again i will take it out, i kinda want to use it a lot but if its really the problem i will just go without it
Logged

Naimod

  • Ensign
  • *
  • Posts: 22
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #10 on: May 03, 2023, 06:16:46 PM »

HMM, well those are some really nice insights thank you,tho  it doesnt seem ai retrofit like a mod that can be removed and keep playing normally on that save if thats the case...wich is a shame i suppose, guess i might try another game for a bit i will try and if it happens again i will take it out, i kinda want to use it a lot but if its really the problem i will just go without it

if the problem is only with the market aspect of the mod then you might still be able to play with the hullmods and crewreplacers. You just have to abstain from building the automated colonies.
Did you build any?

I did, didn't have an issue until I built a 2nd one.
Logged

kur0pur0

  • Ensign
  • *
  • Posts: 3
    • View Profile
Re: fatal null crashing just some time after loading
« Reply #11 on: May 04, 2023, 12:45:24 PM »

well, i havent actually done any colonies with it, just some ships, my first thought maybe the AI made one but now that i think so, maybe its not that huh.
Logged

Histidine

  • Admiral
  • *****
  • Posts: 4690
    • View Profile
    • GitHub profile
Re: fatal null crashing just some time after loading
« Reply #12 on: May 04, 2023, 05:46:51 PM »

I think TASC also has at least one condition that can be removed while it's being applied, although I don't know if this has been linked to any such crashes.

Anyway in Starsector 0.96 this particular issue won't happen.
Logged