Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[IraqiWalker]

I tried looking around, but couldn't find anything yet (Maybe I haven't dug deep enough).
However, I followed the Intro to Modding walkthrough by Vayra, and when I try to launch my game with the mod I created (simple ship mod to test adding ships in) I get a crash instantly with the error "Fatal:null"
I'm guessing the cause is probably the mod_info.json file, but I compared to others and the main difference has been the lack of .jar files, which I'm not sure if I need or not considering I'm not using any special assets.

[Pandora]

I've seen a few mods that had no .jar files, and they are normally ship adds... What you could do is look at the mod Missing Ships. The only thing they do is add a few ships, and they have no .jar file at all.

They oughta help you see if there is anything missing.

[Alex]

if you check starsector.log, that should have a stack trace which - along with the few lines before it - might point in a more specific direction as far as what the issue is.

[IraqiWalker]

I've seen a few mods that had no .jar files, and they are normally ship adds... What you could do is look at the mod Missing Ships. The only thing they do is add a few ships, and they have no .jar file at all.

They oughta help you see if there is anything missing.

I double checked, and it looks like my file is fine. Thanks for the recommendation.

if you check starsector.log, that should have a stack trace which - along with the few lines before it - might point in a more specific direction as far as what the issue is.

Looked through it, and after sifting through a LOT of text, I ran into this line:
37883 [Thread-4] INFO  com.fs.starfarer.loading.LoadingUtils  - Loading CSV data from [ABSOLUTE_AND_CWD: null]

I'm not sure why it's not seeing my csv file in the /mods/mymod/data/hulls folder.

Any ideas?

[Pandora]

It could be a pathing error in the CSV file itself... Do all your ships have the right IDs?

Because the problem could be that it can't find them with the names they have in the file itself.

Also, also, you could join the unofficial Discord. They have a few veteran modders there along with a channel dedicated to modding and scripting.

Spoiler

Invite code is TBhcFNh

[close]

[Alex]

Looked through it, and after sifting through a LOT of text, I ran into this line:
37883 [Thread-4] INFO  com.fs.starfarer.loading.LoadingUtils  - Loading CSV data from [ABSOLUTE_AND_CWD: null]

I'm not sure why it's not seeing my csv file in the /mods/mymod/data/hulls folder.

Any ideas?

What you want to do is 1) run the game and get a crash, then 2) open up the log file and go to the very end, then scroll up looking for the first (i.e. closest to the end of the file) error. That's going to be the one relevant to the crash.

[SafariJohn]

Does ImportantPeopleAPI actually do anything or is it just a management tool?

[SirHartley]

Once again back with something that will probably be part of the next release,
I need to decrease build cost if an industry had a specific previous instance. something like:

Code

		if (previous instanceof industry_A) {
			this.getBuildCost().reduce??
		}

I'd need to do the same for build time.
Can't find a method to do that - do you have any ideas?

Found a workaround, upgrade to temp industry, remove if present and replace with required industry.
thank you nonetheless!

[Alex]

Does ImportantPeopleAPI actually do anything or is it just a management tool?

It's a management tool for e.g. not giving multiple active procurement missions to the same person, etc.

[Pandora]

Edit: Never mind, found out what the problem was!

[hyoukikyo]

Hello,

I am new to the forum and i hope i am not breaking any standard protocol.

My question is that I could just never find a standard midline brawler in any of the markets.
I am able to find a tri-tachyon variant but never the standard one.

I tried editing by following the numbers and tags of a centurion because it is after all a fairly common midline ship that i see everywhere.

What happened though is that now I can see hegemony fleets using the standard midline brawler but it is still never in the markets.

Please help?

I have edited the following:
hegemony.faction
default_ship_roles

and i checked ship_data to see if they are different but centurion and brawler are practically the same.
i do not know what else to do.

[SirHartley]

I am trying to figure out a concurrent modification error that happens only in an extremely specific set of circumstances, and am at my wits end with this.

The issue:
I have an industry that applies fleet listeners to all fleets in the system, tallies any FleetPoint loss, and adjusts output according to that.
It also creates a second market on the entity it is installed on, to enable production budget increase if Heavy Industry is present on the planet. The secondary market ("SalvageMarket") has an industry that gets the smallest produced amount of ship hulls on the primary market, and applies it to itself.
This SalvageMarket is created/removed depending on the presence of Heavy Industry.

All of the above works without a hitch.

The problem:
If HeavyIndustry is removed form a planet with an active SalvageMarket, the game crashes with a ConcurrentModificationError.

This is not caused by SalvageMarket removal directly - the game runs a few other methods from my class before crashing, even after SM is no longer present, and crashes once the removal triggers an economy update.

This does not happen in any other case - removing the ScrapYards is fine, up/downgrading...

Main Industry Class:
https://bitbucket.org/SirHartley/deconomics/src/master/deconomics_ScrapYard
Secondary:
https://bitbucket.org/SirHartley/deconomics/src/master/deconomics_AltHullProd

Crash info:

Code

46435 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.util.ConcurrentModificationException
java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
    at java.util.ArrayList$Itr.next(Unknown Source)
    at com.fs.starfarer.campaign.econ.reach.ReachEconomy.nextStep(Unknown Source)
    at com.fs.starfarer.campaign.econ.Economy.nextStep(Unknown Source)
    at com.fs.starfarer.campaign.econ.Economy.tripleStep(Unknown Source)
    at com.fs.starfarer.campaign.ui.marketinfo.IndustryListPanel.recreateOverview(Unknown Source)
    at com.fs.starfarer.campaign.ui.marketinfo.OO0o.dialogDismissed(Unknown Source)
    at com.fs.starfarer.ui.N.dismiss(Unknown Source)
    at com.fs.starfarer.ui.impl.K.dismiss(Unknown Source)
    at com.fs.starfarer.ui.impl.K.actionPerformed(Unknown Source)
    at com.fs.starfarer.ui.newnew.buttonPressed(Unknown Source)
    at com.fs.starfarer.ui.I.Ò00000(Unknown Source)
    at com.fs.starfarer.ui.I.processInput(Unknown Source)
    at com.fs.starfarer.ui.O0Oo.o00000(Unknown Source)
    at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
    at com.fs.state.AppDriver.begin(Unknown Source)
    at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
    at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)

do you have any idea what could cause this? I think it might be some check related either to the production budget or the presence of the market itself.

[Alex]

Spoiler

Hello,

I am new to the forum and i hope i am not breaking any standard protocol.

My question is that I could just never find a standard midline brawler in any of the markets.
I am able to find a tri-tachyon variant but never the standard one.

I tried editing by following the numbers and tags of a centurion because it is after all a fairly common midline ship that i see everywhere.

What happened though is that now I can see hegemony fleets using the standard midline brawler but it is still never in the markets.

Please help?

I have edited the following:
hegemony.faction
default_ship_roles

and i checked ship_data to see if they are different but centurion and brawler are practically the same.
i do not know what else to do.

[close]

Hi - hmm. Hard to say exactly, but is it possible that the brawler is showing up on the military markets, just not on the open market? Or that you haven't waited long enough for the ships to refresh enough times? What you've done - without knowing the specifics - sounds like, at least conceptually, should have done the job.

I am trying to figure out a concurrent modification error that happens only in an extremely specific set of circumstances, and am at my wits end with this.

Spoiler

The issue:
I have an industry that applies fleet listeners to all fleets in the system, tallies any FleetPoint loss, and adjusts output according to that.
It also creates a second market on the entity it is installed on, to enable production budget increase if Heavy Industry is present on the planet. The secondary market ("SalvageMarket") has an industry that gets the smallest produced amount of ship hulls on the primary market, and applies it to itself.
This SalvageMarket is created/removed depending on the presence of Heavy Industry.

All of the above works without a hitch.

The problem:
If HeavyIndustry is removed form a planet with an active SalvageMarket, the game crashes with a ConcurrentModificationError.

This is not caused by SalvageMarket removal directly - the game runs a few other methods from my class before crashing, even after SM is no longer present, and crashes once the removal triggers an economy update.

This does not happen in any other case - removing the ScrapYards is fine, up/downgrading...

Main Industry Class:
https://bitbucket.org/SirHartley/deconomics/src/master/deconomics_ScrapYard
Secondary:
https://bitbucket.org/SirHartley/deconomics/src/master/deconomics_AltHullProd

Crash info:

Code

46435 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.util.ConcurrentModificationException
java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
    at java.util.ArrayList$Itr.next(Unknown Source)
    at com.fs.starfarer.campaign.econ.reach.ReachEconomy.nextStep(Unknown Source)
    at com.fs.starfarer.campaign.econ.Economy.nextStep(Unknown Source)
    at com.fs.starfarer.campaign.econ.Economy.tripleStep(Unknown Source)
    at com.fs.starfarer.campaign.ui.marketinfo.IndustryListPanel.recreateOverview(Unknown Source)
    at com.fs.starfarer.campaign.ui.marketinfo.OO0o.dialogDismissed(Unknown Source)
    at com.fs.starfarer.ui.N.dismiss(Unknown Source)
    at com.fs.starfarer.ui.impl.K.dismiss(Unknown Source)
    at com.fs.starfarer.ui.impl.K.actionPerformed(Unknown Source)
    at com.fs.starfarer.ui.newnew.buttonPressed(Unknown Source)
    at com.fs.starfarer.ui.I.Ò00000(Unknown Source)
    at com.fs.starfarer.ui.I.processInput(Unknown Source)
    at com.fs.starfarer.ui.O0Oo.o00000(Unknown Source)
    at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
    at com.fs.state.AppDriver.begin(Unknown Source)
    at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
    at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)

[close]

do you have any idea what could cause this? I think it might be some check related either to the production budget or the presence of the market itself.

This means that when you delete remove the SalvageMarket, you're doing this from a method that's called while the game is iterating over a list of markets, somewhere further up the stack. Once it gets back up the stack to the loop where it was iterating over the list, it'll try to go to the next element, see that the list has changed, and throw this exception. In practical terms, this means you'll need to defer market removal somehow, perhaps by adding an EveryFrameScript that does this instead of doing it in the apply()/unapply() methods.

(I've changed the economy code so this specific error should no longer happen, btw.)

[SirHartley]

Shouldn't there also be concurrency issues on market addition? Adding it works just fine, and is done within the same method.

Removal also works fine if triggered with the removal of the ScrapYard.
It really only causes that error if the heavy industry is removed.

[Alex]

It just depends on where it happens; apply()/unapply() get called from various places in the core code.