Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Lycaeon]

Hello all,

I've encountered an unusual bug in my last run. When I made a donation of 20,000 to the bar historian, I noticed this amount wasn't deducted from my credit balance. To confirm this wasn't a fluke or a mistake on my part, the next time a donation opportunity came up for 50,000, I noted my balance before and after making the donation and it was again the same. This was despite the game noting I had lost both amounts in the dialogue screen when the donations were made. I also did not spend any SP on blueprints/colony items prior to this.

As of now I don't know if this bug is or isn't due to a mod...I never paid attention to my cash total when making donations before. I also noted that credits seemed to be added or removed correctly with other events not related to the bar historian. Nothing unusual showed up in the starsector.log file either.

Any help in this matter would be appreciated. My mod list is as follows:

Additional Character Names,
AI High Energy Focus Tweak,
AoTD Cryosleeper,
Audio Plus,
Better Colonies,
Combat Chatter,
Detailed Combat Results,
Fleet Journal,
Force Auto Resolve,
GraphicsLib,
Hostile Intercept,
Interesting Portraits Pack,
LazyLib,
LunaLib,
MagicLib,
More Player Flags,
More Ship Names,
Nexerelin,
Nomadic Survival,
Officer Extension,
Planetary Shield Access Control,
Realistic Combat,
Ruthless Sector,
Scavenger Trading,
Starpocalypse Revengeance,
Starship Legends,
Stellar Networks,
Terraforming and Station Construction,
Unknown Skies

Of these mods Nomadic Survival by Sundog is the most recent one I've added, and the only one I can think of apart from Nexerelin and Starship Legends that alters the planetside dialogue in any way.

[Sundog]

Good catch!
I didn't test this in-game because I'm not aware of a convenient way to proc historian donations, but this appears to be a vanilla bug, surprisingly. As far as I can tell, the code responsible for handling the donation has a line for notifying you that credits were lost, but nothing to actually remove the credits. I'll PM Alex to make sure he knows to take a look at this.

com.fs.starfarer.api.impl.campaign.intel.bar.events.historian.DonationOffer.opt ionSelected()

Code

	public void optionSelected(String optionText, Object optionData) {
		
		HistorianData hd = HistorianData.getInstance();
		
		if (optionData == OptionId.DONATE) {
			setDone(true);
			setRemove(true);
			
			hd.incrTier();
			hd.setRecentlyDonated();
			
			AddRemoveCommodity.addCreditsLossText(credits, text);
			
			CustomRepImpact impact = new CustomRepImpact();
			impact.limit = RepLevel.COOPERATIVE;
			impact.delta = 0.1f;
			Global.getSector().adjustPlayerReputation(
					new RepActionEnvelope(RepActions.CUSTOM, impact,
										  null, dialog.getTextPanel(), true), hd.getPerson());
			
//			CustomRepImpact impact = new CustomRepImpact();
//			impact.delta = 0.1f;
//			
//			Global.getSector().adjustPlayerReputation(
//					new RepActionEnvelope(RepActions.CUSTOM, 
//							impact, null, text, true, true),
//							hd.getPerson());
			
			dialog.getTextPanel().addPara("The historian thanks you for your help.");
			return;
		}
		
		
		if (optionData == OptionId.NEVER_MIND) {
			setDone(true);
			
			dialog.getTextPanel().addPara("The historian cooperates in changing topics.");
			return;
		}
	}

[Lycaeon]

Huh, that's interesting. Thanks for taking the time to look it up in the code.

[Sundog]

No problem. The coding software I use made it pretty easy 

[Alex]

And, thanks to this report, it's now fixed for the next release