Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24)

Author Topic: Updating Janino for next Starsector update?  (Read 489 times)

Timid

  • Admiral
  • *****
  • Posts: 636
  • Personal Text
    • View Profile
Updating Janino for next Starsector update?
« on: August 29, 2022, 10:28:09 PM »

I noticed a few user's mod lists are getting some issues involving https://github.com/janino-compiler/janino/issues/93.

Could a janino update be doable right now for the next Starsector update?

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 23775
    • View Profile
Re: Updating Janino for next Starsector update?
« Reply #1 on: August 30, 2022, 08:18:11 AM »

Honestly, I don't really see doing that - I don't have a lot of confidence that something wouldn't break because of it, for one. For two, it feels like compiling stuff into jars should be the preferred way of doing things - if nothing else, just for the impact that has on the game's loading time.

(The compilation is done on a separate thread, so a limited number of loose scripts has no impact, but if a bunch of mods all do it, it adds up and can easily become the "long pole" in the loading process. E.G. if you see the loading progress bar stuck at 100% but waiting for an unduly long time, there's a good chance that it's waiting for loose script compilation to finish. It's either that, or mods doing something heavy in their ModPlugin.onApplicationLoad() method.)
Logged

Timid

  • Admiral
  • *****
  • Posts: 636
  • Personal Text
    • View Profile
Re: Updating Janino for next Starsector update?
« Reply #2 on: August 30, 2022, 08:21:55 AM »

Fair enough.