Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24); New blog post: Anubis-class Cruiser (12/20/24)

Pages: 1 ... 22 23 [24]

Author Topic: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods  (Read 242464 times)

EnigmaniteZ

  • Commander
  • ***
  • Posts: 152
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.0) — gain XP for ships, spend it on S-mods
« Reply #345 on: November 24, 2024, 10:32:35 AM »

the reserve xp pool comes from losing an smodded ship that you personally built mods into, in combat, from what I vaguely remember. works for me, at least, so I have to wonder if it is a weird compatibility issue or something else. if you have that xp it should show up next to the normal XP on the ship selector: XP X (Y in the reserve pool)

...and I'm slightly annoyed that the reserve xp can't be used to increase smod slots. mostly because I lost a ship and ended up getting it back via an event (I..think that is a Nex thing), but at 6/3. and it's a Revenant, of course.
Logged
Also known as: Khe, Kherae. Pros: tend to be an optimizer and a fixer. Cons: ADD (Is that a squirrel over there?) and severe memory issues (as in: I'm the last 10+ years)

Dear fellow coders: please use more null checks...

Rzabat

  • Ensign
  • *
  • Posts: 10
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.0) — gain XP for ships, spend it on S-mods
« Reply #346 on: November 25, 2024, 10:34:57 PM »

Is there a way to get the UI back to when extra XP was added onto a ship through sliders? I think there is some compatibility bug but I don't know what mod would be causing me to not see or receive any of it.
Logged

kirbcake

  • Ensign
  • *
  • Posts: 1
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.0) — gain XP for ships, spend it on S-mods
« Reply #347 on: December 09, 2024, 07:32:14 AM »

Hey, made an account to say I love the mod and it should be vanilla lol. Also wanted to let you know that, for me at least, Starsector fatal errors when trying to view the built in hullmod menu for the Glimmer frigate. I'm assuming this has to do with it being a drone ship and all, so it very well may extend to the rest of the Remnants.
Logged

float

  • Captain
  • ****
  • Posts: 329
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.0) — gain XP for ships, spend it on S-mods
« Reply #348 on: December 09, 2024, 09:43:35 AM »

Hey, made an account to say I love the mod and it should be vanilla lol. Also wanted to let you know that, for me at least, Starsector fatal errors when trying to view the built in hullmod menu for the Glimmer frigate. I'm assuming this has to do with it being a drone ship and all, so it very well may extend to the rest of the Remnants.
Hi, and welcome!
I can't reproduce the error you're experiencing. If you check your Starsector install folder, there should be a folder called starsector-core. Open it, and there should be a file named starsector.log. If you open starsector.log right after you experience a crash, you can scroll to the bottom to find a series of indented lines preceded by a numbered ERROR message. Can you post the entire error message, starting from the number and including all of the subsequent indented lines?
« Last Edit: December 09, 2024, 02:18:12 PM by float »
Logged

float

  • Captain
  • ****
  • Posts: 329
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.1) — gain XP for ships, spend it on S-mods
« Reply #349 on: December 09, 2024, 02:18:27 PM »

1.0.1:
Spoiler
- Disabled and removed the legacy UI.
- Added LunaLib refit button to manage S-mods, if you have LunaLib. (Note: due to weirdness with stacking interfaces, clicking the
  increase S-mod limit button will close the S-mod interface when accessed directly from refit screen).
- No longer checks hullmod getUnapplicableReason for hullmods that are already installed on the variant.
- Fixed reserve XP not working correctly with Lunalib.
- Fixed increasing S-mod limit not working with the exact number of story points needed.
- Reserve XP can now be used to increase S-mod limit.
[close]
Logged

Cirind

  • Ensign
  • *
  • Posts: 12
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #350 on: December 10, 2024, 05:09:03 AM »

Just wanted to report partial incompatibility between Indies Expansion Pack v2.0 and Progressive S-mods.

Trying to install s-mod on stored frigate crashes the game.

Logs are from 1.0.0 version of S-mods but after looking at new ones they are more or less identical.

https://drive.google.com/drive/folders/1Zus69OdwTfrUaT7w7A-n3AZ1hrUT4VN9?usp=sharing from Java 8 and 23.
Logged

float

  • Captain
  • ****
  • Posts: 329
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #351 on: December 10, 2024, 08:48:36 AM »

Just wanted to report partial incompatibility between Indies Expansion Pack v2.0 and Progressive S-mods.

Trying to install s-mod on stored frigate crashes the game.

Logs are from 1.0.0 version of S-mods but after looking at new ones they are more or less identical.

https://drive.google.com/drive/folders/1Zus69OdwTfrUaT7w7A-n3AZ1hrUT4VN9?usp=sharing from Java 8 and 23.

That link doesn't work.
Logged

artci

  • Ensign
  • *
  • Posts: 4
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #352 on: December 13, 2024, 04:31:26 PM »

Hi all,
I encountered the same issue.

Steps to reproduce:
1. Get any frigate hull.
2. Refit and install the "Stored frigate" mod from the "Indies Expansion Pack" mod.
3. Go to the planet menu and choose the menu item to manage the built-in s-mods.
4. Click on the frigate prepared in steps 1 and 2.

Expected results - the s-mod management menu should open for the ship allowing to build-in s-mods using ship's XP.

Actual results - the game crashes with the error "java.lang.NullPointerException: Cannot invoke "com.fs.starfarer.api.fleet.FleetMemberAPI.getFleetData()" because "fleetmembercheck" is null". Full message from the log in spoiler (I can provide the full log if that is helpful, but I could not find any other relevant messages there). Let me know if more info is needed - I can do further testing, as it reproduces easily with my current fleet.

Spoiler
Code
247646 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException: Cannot invoke "com.fs.starfarer.api.fleet.FleetMemberAPI.getFleetData()" because "fleetmembercheck" is null
java.lang.NullPointerException: Cannot invoke "com.fs.starfarer.api.fleet.FleetMemberAPI.getFleetData()" because "fleetmembercheck" is null
    at data.scripts.hullmods.acs_frigate_on_hangar.isApplicableToShip(acs_frigate_on_hangar.java:101) ~[?:?]
    at progsmod.data.campaign.rulecmd.ui.plugins.HullModSelector.disableUnapplicable(HullModSelector.java:214) ~[?:?]
    at progsmod.data.campaign.rulecmd.ui.plugins.HullModSelector.update(HullModSelector.java:115) ~[?:?]
    at progsmod.data.campaign.rulecmd.PSM_BuildInHullModNew$SelectorContainer.updateAll(PSM_BuildInHullModNew.java:321) ~[?:?]
    at progsmod.data.campaign.rulecmd.ui.plugins.HullModSelector.updateItems(HullModSelector.java:109) ~[?:?]
    at progsmod.data.campaign.rulecmd.ui.plugins.HullModSelector.init(HullModSelector.java:100) ~[?:?]
    at progsmod.data.campaign.rulecmd.PSM_BuildInHullModNew$1.createCustomDialog(PSM_BuildInHullModNew.java:187) ~[?:?]
    at com.fs.starfarer.ui.newui.oOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.<init>(Unknown Source) ~[port_obf.jar:?]
    at com.fs.starfarer.ui.newui.o0Oo.showCustomDialog(Unknown Source) ~[port_obf.jar:?]
    at progsmod.data.campaign.rulecmd.PSM_BuildInHullModNew.createPanel(PSM_BuildInHullModNew.java:120) ~[?:?]
    at progsmod.data.campaign.rulecmd.ui.plugins.ShipSelector.onSelected(ShipSelector.java:37) ~[?:?]
    at progsmod.data.campaign.rulecmd.ui.plugins.Selector.checkIfModified(Selector.java:111) ~[?:?]
    at progsmod.data.campaign.rulecmd.ui.plugins.Selector.buttonPressed(Selector.java:70) ~[?:?]
    ...
[close]
Logged

float

  • Captain
  • ****
  • Posts: 329
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #353 on: December 13, 2024, 04:55:11 PM »

Looks like "acs_frigate_on_hangar" is missing a null check somewhere, as that's where the error is originating from. There's nothing I can do on my end, as there's no "setFleetMember" function on ShipAPI or similar. (Best I could possibly do is rearrange the boolean conditions to short-circuit the isApplicableToShip check earlier in the chain, but that'd still crash if you used the "show recent" function.)

Plus the Starsector API even states that getFleetMemberId() "can be null if there isn't one," so by extension getFleetMember() being null should also be within spec.
Logged

artci

  • Ensign
  • *
  • Posts: 4
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #354 on: December 14, 2024, 03:27:25 AM »

Thank you for the info, I posted in the other mod thread - maybe it's easier to fix from that side. In any case this is not a blocker as the "Stored frigate" mod can be removed temporarily.
Logged

wakemab470

  • Ensign
  • *
  • Posts: 3
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #355 on: December 14, 2024, 05:04:16 PM »

Hello, for some reason, the addShipXP command doesn't seem to work. Am I doing something wrong? Thank you!
Logged

TimeDiver

  • Captain
  • ****
  • Posts: 415
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #356 on: December 14, 2024, 05:24:24 PM »

Hello, for some reason, the addShipXP command doesn't seem to work. Am I doing something wrong? Thank you!
The Console Command is 'PSM_addShipXP'; you forgot the 'PSM_' prefix.

EDIT: Unless playing on Linux (and/or Mac?), capitalization should be optional.
Logged

wakemab470

  • Ensign
  • *
  • Posts: 3
    • View Profile
Re: [0.97a] Progressive S-Mods (1.0.2) — gain XP for ships, spend it on S-mods
« Reply #357 on: December 14, 2024, 07:40:58 PM »

Hello, for some reason, the addShipXP command doesn't seem to work. Am I doing something wrong? Thank you!
The Console Command is 'PSM_addShipXP'; you forgot the 'PSM_' prefix.

EDIT: Unless playing on Linux (and/or Mac?), capitalization should be optional.

Thank you!
Logged
Pages: 1 ... 22 23 [24]