Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24); In-development patch notes for Starsector 0.98a (2/8/25)

Author Topic: white dwarf in deep hyperspace  (Read 2063 times)

Blurple Berry

  • Ensign
  • *
  • Posts: 48
    • View Profile
white dwarf in deep hyperspace
« on: September 01, 2019, 07:31:53 AM »

it is a bug, right?
at least it feels like a bug

i attached a picture just to be sure

... god, i hope it's a bug ;D

[attachment deleted by admin]
Logged

goduranus

  • Admiral
  • *****
  • Posts: 925
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #1 on: September 01, 2019, 11:19:02 AM »

It's not, a lot of stellar bodies's gravity wells will drift into deep hyperspace

Blurple Berry

  • Ensign
  • *
  • Posts: 48
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #2 on: September 01, 2019, 12:21:59 PM »

It's not, a lot of stellar bodies's gravity wells will drift into deep hyperspace

thank you for the clarification!

what a shame, i really liked the game :(
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 25125
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #3 on: September 01, 2019, 12:23:23 PM »

It's kind of sort of a bug - more like a small content issue; i.e. ideally it wouldn't happen, but sometimes it does. I keep fixing these up periodically but they pop up now and again in some spots. This is near Valhalla, right?
Logged

Blurple Berry

  • Ensign
  • *
  • Posts: 48
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #4 on: September 01, 2019, 01:05:28 PM »

It's kind of sort of a bug - more like a small content issue; i.e. ideally it wouldn't happen, but sometimes it does. I keep fixing these up periodically but they pop up now and again in some spots. This is near Valhalla, right?

near(ish)  ;D
it's the dual star system i marked in the screenshot (for orientation -> corvus is bottom right)

i might be able to upload the save files in zip format (with my fleet located in said system and all) on some free hosting site - if that would help in any way

[attachment deleted by admin]
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 25125
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #5 on: September 01, 2019, 01:06:10 PM »

Ah, ok, thank you - will take a look! No need to upload the save, this is all the info I need.
Logged

Blurple Berry

  • Ensign
  • *
  • Posts: 48
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #6 on: September 01, 2019, 01:29:08 PM »

alright, no problem

... actually, thank YOU for looking into it (and replying so fast)
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 25125
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #7 on: September 01, 2019, 01:30:06 PM »

:D
Logged

Blurple Berry

  • Ensign
  • *
  • Posts: 48
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #8 on: September 02, 2019, 07:54:14 AM »

i believe to have found a "solution"

but to be honest, i really have no idea what i did there and no clue how i even got to that point

anyway

i edited the SectorGen.java file

original code

// ensure area round stars is clear
      HyperspaceTerrainPlugin plugin = (HyperspaceTerrainPlugin) Misc.getHyperspaceTerrain().getPlugin();
      NebulaEditor editor = new NebulaEditor(plugin);
      float minRadius = plugin.getTileSize() * 2f;
      for (StarSystemAPI curr : sector.getStarSystems()) {
         float radius = curr.getMaxRadiusInHyperspace() * 0.5f;
         editor.clearArc(curr.getLocation().x, curr.getLocation().y, 0, radius + minRadius * 0.5f, 0, 360f);
         editor.clearArc(curr.getLocation().x, curr.getLocation().y, 0, radius + minRadius, 0, 360f, 0.25f);
      }

edited code

// ensure area round stars is clear
      HyperspaceTerrainPlugin plugin = (HyperspaceTerrainPlugin) Misc.getHyperspaceTerrain().getPlugin();
      NebulaEditor editor = new NebulaEditor(plugin);
      float minRadius = plugin.getTileSize() * 2f;
      for (StarSystemAPI curr : sector.getStarSystems()) {
         float radius = curr.getMaxRadiusInHyperspace() * 1.5f;
         editor.clearArc(curr.getLocation().x, curr.getLocation().y, 0, radius + minRadius * 0.5f, 0, 360f);
         editor.clearArc(curr.getLocation().x, curr.getLocation().y, 0, radius + minRadius, 0, 360f, 0.25f);
      }

then i used "devmode vision", ctrl-teleporting and a godamn ruler to see if anything improved

out of 11 newly generated systems none had this "star in deep hyperspace" problem

with the original code 3 out of 3 newly generated system had at least 1 "problematic" star system

admittedly, it's not a very elegant solution - "cleared space" can be very obvious at times but it ain't too bad either
maybe i even just got lucky with the seeds or simply missed stuff and for most people it's probably a pretty minor problem (if at all), but i thought i share my "fix" anyway
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 25125
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #9 on: September 02, 2019, 08:13:07 AM »

admittedly, it's not a very elegant solution - "cleared space" can be very obvious at times but it ain't too bad either
maybe i even just got lucky with the seeds or simply missed stuff and for most people it's probably a pretty minor problem (if at all), but i thought i share my "fix" anyway

Yep, exactly. That's where I'd look as well, but I don't want to "fix" this by deleting half the hyperspace, either, if you know what I mean :)
Logged

Blurple Berry

  • Ensign
  • *
  • Posts: 48
    • View Profile
Re: white dwarf in deep hyperspace
« Reply #10 on: September 02, 2019, 08:30:09 AM »

well it's not quite so severe but i know what you mean - hyperspace travel got a tad more ... uhm, convenient ;D
Logged