Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: Star system doesnt show up  (Read 3024 times)

Titann

  • Commander
  • ***
  • Posts: 122
    • View Profile
Star system doesnt show up
« on: October 23, 2015, 02:34:29 AM »

Currently working on Discovery Freelancer mod for Starsector and Im trying to make character creating plugin.

However It keep causing this error;

Spoiler
11056 [Thread-5] ERROR com.fs.starfarer.combat.D  - java.lang.RuntimeException: Error compiling [data.scripts.plugins.CharacterCreationPluginImpl]
java.lang.RuntimeException: Error compiling [data.scripts.plugins.CharacterCreationPluginImpl]
   at com.fs.starfarer.loading.scripts.ScriptStore$3.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: File 'data/scripts/plugins/CharacterCreationPluginImpl.java', Line 136, Column 32: A method named "getStartingShipChoices" is not declared in any enclosing class nor any supertype, nor through a static import
   at org.codehaus.janino.JavaSourceClassLoader.generateBytecodes(JavaSourceClassLoader.java:226)
   at org.codehaus.janino.JavaSourceClassLoader.findClass(JavaSourceClassLoader.java:178)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   ... 2 more
Caused by: org.codehaus.commons.compiler.CompileException: File 'data/scripts/plugins/CharacterCreationPluginImpl.java', Line 136, Column 32: A method named "getStartingShipChoices" is not declared in any enclosing class nor any supertype, nor through a static import
   at org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:10174)
   at org.codehaus.janino.UnitCompiler.findIMethod(UnitCompiler.java:7392)
   at org.codehaus.janino.UnitCompiler.getType2(UnitCompiler.java:5663)
   at org.codehaus.janino.UnitCompiler.access$13800(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$16.visitMethodInvocation(UnitCompiler.java:5132)
   at org.codehaus.janino.Java$MethodInvocation.accept(Java.java:3971)
   at org.codehaus.janino.UnitCompiler.getType(UnitCompiler.java:5159)
   at org.codehaus.janino.UnitCompiler.findIMethod(UnitCompiler.java:7333)
   at org.codehaus.janino.UnitCompiler.compileGet2(UnitCompiler.java:3873)
   at org.codehaus.janino.UnitCompiler.access$6900(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$10.visitMethodInvocation(UnitCompiler.java:3263)
   at org.codehaus.janino.Java$MethodInvocation.accept(Java.java:3974)
   at org.codehaus.janino.UnitCompiler.compileGet(UnitCompiler.java:3290)
   at org.codehaus.janino.UnitCompiler.compileGetValue(UnitCompiler.java:4368)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:2662)
   at org.codehaus.janino.UnitCompiler.access$4400(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$7.visitMethodInvocation(UnitCompiler.java:2627)
   at org.codehaus.janino.Java$MethodInvocation.accept(Java.java:3974)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:2654)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1643)
   at org.codehaus.janino.UnitCompiler.access$1100(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitExpressionStatement(UnitCompiler.java:936)
   at org.codehaus.janino.Java$ExpressionStatement.accept(Java.java:2097)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compileStatements(UnitCompiler.java:1007)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:993)
   at org.codehaus.janino.UnitCompiler.access$1000(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitBlock(UnitCompiler.java:935)
   at org.codehaus.janino.Java$Block.accept(Java.java:2012)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1753)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1745)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compileStatements(UnitCompiler.java:1007)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:2293)
   at org.codehaus.janino.UnitCompiler.compileDeclaredMethods(UnitCompiler.java:822)
   at org.codehaus.janino.UnitCompiler.compileDeclaredMethods(UnitCompiler.java:794)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:507)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:393)
   at org.codehaus.janino.UnitCompiler.access$400(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$2.visitPackageMemberClassDeclaration(UnitCompiler.java:347)
   at org.codehaus.janino.Java$PackageMemberClassDeclaration.accept(Java.java:1139)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:354)
   at org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:322)
   at org.codehaus.janino.JavaSourceClassLoader.generateBytecodes(JavaSourceClassLoader.java:224)
   ... 5 more
[close]

and this code causing the error;
      if (stage == 0) {
         data.addStartingShipChoice("li_gb_a");
         
      }

I dont really know why.

Is code wrong?

Is there examples for this CharacterCreationPlugin?



Second problem;

I made a star system and added it to my mod's SectorGen then to starmap.json but still it doesnt show up in the game
« Last Edit: October 24, 2015, 12:14:21 PM by tokmak333 »
Logged

Histidine

  • Admiral
  • *****
  • Posts: 4688
    • View Profile
    • GitHub profile
Re: Character Creating Plugin Error - Star system doesnt show up
« Reply #1 on: October 23, 2015, 06:48:55 AM »

Unless you require some weird special functionality you're likely better off using rules.csv than trying to modify the character creation plugin.

Why does your plugin appear to have the same name and package as the vanilla one, anyway? I'd expect that to break. (Change your plugin name or package and change the settings config to point to the modded plugin)
Logged

Titann

  • Commander
  • ***
  • Posts: 122
    • View Profile
Re: Character Creating Plugin Error - Star system doesnt show up
« Reply #2 on: October 24, 2015, 03:45:54 AM »

Unless you require some weird special functionality you're likely better off using rules.csv than trying to modify the character creation plugin.

Why does your plugin appear to have the same name and package as the vanilla one, anyway? I'd expect that to break. (Change your plugin name or package and change the settings config to point to the modded plugin)

Im creating a total conversion mod and Im not going to use vanilla ships. Im trying to add civillian gunboat as starter ship but it keeps crashing I dont know how to fix this

Spoiler
18295 [Thread-5] ERROR com.fs.starfarer.combat.D  - java.lang.RuntimeException: Error compiling [data.scripts.DiscoveryModPlugin]
java.lang.RuntimeException: Error compiling [data.scripts.DiscoveryModPlugin]
   at com.fs.starfarer.loading.scripts.ScriptStore$3.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: File 'data/scripts/plugins/DiscoCharacterCreation.java', Line 73, Column 31: A method named "addStartingShipChoice" is not declared in any enclosing class nor any supertype, nor through a static import
   at org.codehaus.janino.JavaSourceClassLoader.generateBytecodes(JavaSourceClassLoader.java:226)
   at org.codehaus.janino.JavaSourceClassLoader.findClass(JavaSourceClassLoader.java:178)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   ... 2 more
Caused by: org.codehaus.commons.compiler.CompileException: File 'data/scripts/plugins/DiscoCharacterCreation.java', Line 73, Column 31: A method named "addStartingShipChoice" is not declared in any enclosing class nor any supertype, nor through a static import
   at org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:10174)
   at org.codehaus.janino.UnitCompiler.findIMethod(UnitCompiler.java:7392)
   at org.codehaus.janino.UnitCompiler.compileGet2(UnitCompiler.java:3873)
   at org.codehaus.janino.UnitCompiler.access$6900(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$10.visitMethodInvocation(UnitCompiler.java:3263)
   at org.codehaus.janino.Java$MethodInvocation.accept(Java.java:3974)
   at org.codehaus.janino.UnitCompiler.compileGet(UnitCompiler.java:3290)
   at org.codehaus.janino.UnitCompiler.compileGetValue(UnitCompiler.java:4368)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:2662)
   at org.codehaus.janino.UnitCompiler.access$4400(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$7.visitMethodInvocation(UnitCompiler.java:2627)
   at org.codehaus.janino.Java$MethodInvocation.accept(Java.java:3974)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:2654)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1643)
   at org.codehaus.janino.UnitCompiler.access$1100(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitExpressionStatement(UnitCompiler.java:936)
   at org.codehaus.janino.Java$ExpressionStatement.accept(Java.java:2097)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compileStatements(UnitCompiler.java:1007)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:993)
   at org.codehaus.janino.UnitCompiler.access$1000(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitBlock(UnitCompiler.java:935)
   at org.codehaus.janino.Java$Block.accept(Java.java:2012)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:1753)
   at org.codehaus.janino.UnitCompiler.access$1200(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$4.visitIfStatement(UnitCompiler.java:937)
   at org.codehaus.janino.Java$IfStatement.accept(Java.java:2157)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:958)
   at org.codehaus.janino.UnitCompiler.compileStatements(UnitCompiler.java:1007)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:2293)
   at org.codehaus.janino.UnitCompiler.compileDeclaredMethods(UnitCompiler.java:822)
   at org.codehaus.janino.UnitCompiler.compileDeclaredMethods(UnitCompiler.java:794)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:507)
   at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:393)
   at org.codehaus.janino.UnitCompiler.access$400(UnitCompiler.java:185)
   at org.codehaus.janino.UnitCompiler$2.visitPackageMemberClassDeclaration(UnitCompiler.java:347)
   at org.codehaus.janino.Java$PackageMemberClassDeclaration.accept(Java.java:1139)
   at org.codehaus.janino.UnitCompiler.compile(UnitCompiler.java:354)
   at org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:322)
   at org.codehaus.janino.JavaSourceClassLoader.generateBytecodes(JavaSourceClassLoader.java:224)
   ... 5 more
[close]
Logged

Titann

  • Commander
  • ***
  • Posts: 122
    • View Profile
Re: Star system doesnt show up
« Reply #3 on: October 24, 2015, 12:17:49 PM »

fixed the character creating problem.

Now last one;

my star system doesnt show up. I added it to discoGen (sectorgen for my mod)
discoGen;
Spoiler
package data.scripts.world;

import com.fs.starfarer.api.campaign.FactionAPI;
import com.fs.starfarer.api.campaign.RepLevel;
import com.fs.starfarer.api.campaign.SectorAPI;
import com.fs.starfarer.api.campaign.SectorGeneratorPlugin;
import com.fs.starfarer.api.impl.campaign.CoreCampaignPluginImpl;
import com.fs.starfarer.api.impl.campaign.CoreScript;
import com.fs.starfarer.api.impl.campaign.events.CoreEventProbabilityManager;
import com.fs.starfarer.api.impl.campaign.fleets.EconomyFleetManager;
import data.scripts.world.systems.Newyork;

   public class discoGen
     implements SectorGeneratorPlugin

     public void generate(SectorAPI sector)
  {
       initFactionRelationships(sector);
   
       new Newyork().generate(sector);
  }
[close]

initFactionRelationships(SectorAPI sector)  <- also this but I think its not needed

However it keeps crashing I set my spawn location to Newyork system but it crashing, this is the eror;

Spoiler
27424 [Thread-5] ERROR com.fs.starfarer.combat.D  - java.lang.NullPointerException
java.lang.NullPointerException
   at com.fs.starfarer.campaign.save.CampaignGameManager.o00000(Unknown Source)
   at com.fs.starfarer.title.OoOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.dialogDismissed(Unknown Source)
   at com.fs.starfarer.ui.do.dismiss(Unknown Source)
   at com.fs.starfarer.ui.impl.O0oO.dismiss(Unknown Source)
   at com.fs.starfarer.campaign.save.O0oO.actionPerformed(Unknown Source)
   at com.fs.starfarer.ui.thisnew.super(Unknown Source)
   at com.fs.starfarer.ui.H.processInput(Unknown Source)
   at com.fs.starfarer.ui.thisnew.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.coreui.if.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.O0OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.I.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.do.processInputImpl(Unknown Source)
   at com.fs.starfarer.campaign.save.O0oO.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.title.OoOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.super(Unknown Source)
   at com.fs.starfarer.new.Òôo000(Unknown Source)
   at com.fs.oOOO.oOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.Ò00000(Unknown Source)
   at com.fs.starfarer.combat.D.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$2.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
[close]
Logged

Histidine

  • Admiral
  • *****
  • Posts: 4688
    • View Profile
    • GitHub profile
Re: Star system doesnt show up
« Reply #4 on: October 26, 2015, 04:09:37 AM »

What does your Newyork class and the class where you set starting system look like?
Logged

Titann

  • Commander
  • ***
  • Posts: 122
    • View Profile
Re: Star system doesnt show up
« Reply #5 on: October 26, 2015, 06:34:01 AM »

What does your Newyork class and the class where you set starting system look like?
What yu mean? I ve copied corvus system to see is it workng or not

I changed the ids and planet ids

I have to make different system right?
Logged

Histidine

  • Admiral
  • *****
  • Posts: 4688
    • View Profile
    • GitHub profile
Re: Star system doesnt show up
« Reply #6 on: October 27, 2015, 06:43:33 AM »

Post your code.

The error log tells me it's trying to spawn the player fleet in a system that doesn't exist (you need to pass the star's human-readable name to CharacterCreationData.setStartingLocationName). If you let it spawn elsewhere, does the system exist?

Here's the code I use:
Spoiler
Code: java
public class NGCSetStartingLocationExerelin extends BaseCommandPlugin {
            
    @Override
    public boolean execute(String ruleId, InteractionDialogAPI dialog, List<Misc.Token> params, Map<String, MemoryAPI> memoryMap) {
        CharacterCreationData data = (CharacterCreationData) memoryMap.get(MemKeys.LOCAL).get("$characterData");
        if (ExerelinConfig.corvusMode)
        {
            String factionId = PlayerFactionStore.getPlayerFactionIdNGC();
            
            if (!ExerelinUtilsFaction.isCorvusCompatible(factionId, false))
            {
                Global.getLogger(NGCSetStartingLocationExerelin.class).warn("Faction " + factionId + " is not Corvus-compatible, falling back to hyperspace spawn");
                data.setStartingLocationName("hyperspace");
            }
            else
            {
                SpawnPointEntry spawnPoint = ExerelinCorvusLocations.getFactionSpawnPoint(factionId);
                if (spawnPoint != null)
                {
                    data.setStartingLocationName(spawnPoint.systemName);  // Corvus, Magec, Sindria, Anar, Thracia, Citadel, etc.
                    data.getStartingCoordinates().set(600, -600);
                }
                else data.setStartingLocationName("hyperspace");
            }
        }
        else
        {
            String homeStar = SectorManager.getFirstStarName();  // usually "Exerelin" (without quotes)

            data.setStartingLocationName(homeStar);
            data.getStartingCoordinates().set(1200, -1200);
        }
        
        return true;
    }
}
[close]
EDIT: Or if you're still using rules.csv, the same thing applies, just use NGCSetStartingLocation <star name> making sure you get <star name> right and the system actually exists
« Last Edit: October 27, 2015, 06:52:26 AM by Histidine »
Logged

Titann

  • Commander
  • ***
  • Posts: 122
    • View Profile
Re: Star system doesnt show up
« Reply #7 on: October 27, 2015, 08:16:06 AM »

I am using Rules.csv now I did what you write there, still same error

New york system code;

Code
package data.scripts.world.systems;

import java.awt.Color;

import com.fs.starfarer.api.Global;
import com.fs.starfarer.api.campaign.JumpPointAPI;
import com.fs.starfarer.api.campaign.LocationAPI;
import com.fs.starfarer.api.campaign.OrbitAPI;
import com.fs.starfarer.api.campaign.PlanetAPI;
import com.fs.starfarer.api.campaign.SectorAPI;
import com.fs.starfarer.api.campaign.SectorEntityToken;
import com.fs.starfarer.api.campaign.StarSystemAPI;

public class Newyork {

public void generate(SectorAPI sector) {
StarSystemAPI system = sector.createStarSystem("Newyork");
LocationAPI hyper = Global.getSector().getHyperspace();

system.setBackgroundTextureFilename("graphics/backgrounds/background4.jpg");

// create the star and generate the hyperspace anchor for this system
PlanetAPI star = system.initStar("newyork",
"star_white", // id in planets.json
750f); // radius (in pixels at default zoom)

system.setLightColor(new Color(255, 255, 255)); // light color in entire system, affects all entities

PlanetAPI ny2 = system.addPlanet("manhattan", star, "Manhattan", "arid", 200, 180, 4400, 100);
ny2.getSpec().setGlowTexture(Global.getSettings().getSpriteName("hab_glows", "sindria"));
ny2.getSpec().setGlowColor(new Color(245,255,250,255));
ny2.getSpec().setUseReverseLightForGlow(true);
ny2.applySpecChanges();

PlanetAPI ny2a = system.addPlanet("pittsburg", ny2, "Pittsburg", "barren-bombarded", 0, 35, 400, 30);

SectorEntityToken relay = system.addCustomEntity("navy_relay", // unique id
"New York Relay", // name - if null, defaultName from custom_entities.json will be used
"comm_relay", // type of object, defined in custom_entities.json
"libertynavy"); // faction
relay.setCircularOrbit(system.getEntityById("manhattan"), 90, 1000, 45);


JumpPointAPI ny2JumpPoint = Global.getFactory().createJumpPoint("navy_bridge", "Libety Navy Jump Gate");
OrbitAPI orbit = Global.getFactory().createCircularOrbit(ny2, 0, 640, 30);
ny2JumpPoint.setOrbit(orbit);
ny2JumpPoint.setRelatedPlanet(ny2);
ny2JumpPoint.setStandardWormholeToHyperspaceVisual();
system.addEntity(ny2JumpPoint);



system.autogenerateHyperspaceJumpPoints(true, true);
}
}

DiscoveryModPlugin;
Code
package data.scripts;

import com.fs.starfarer.api.BaseModPlugin;
import com.fs.starfarer.api.Global;
import data.scripts.world.discoGen;

public class DiscoveryModPlugin extends BaseModPlugin {

    private static void initDiscovery() {}

    @Override
    public void onNewGame() {
        initDiscovery();
    }
}

discoGen;
Code
package data.scripts.world;

import com.fs.starfarer.api.campaign.FactionAPI;
import com.fs.starfarer.api.campaign.RepLevel;
import com.fs.starfarer.api.campaign.SectorAPI;
import com.fs.starfarer.api.campaign.SectorGeneratorPlugin;
import com.fs.starfarer.api.impl.campaign.CoreCampaignPluginImpl;
import com.fs.starfarer.api.impl.campaign.CoreScript;
import com.fs.starfarer.api.impl.campaign.events.CoreEventProbabilityManager;
import com.fs.starfarer.api.impl.campaign.fleets.EconomyFleetManager;
import data.scripts.world.systems.Newyork;

public class discoGen
   implements SectorGeneratorPlugin
{  
   public void generate(SectorAPI sector)
  {
     initFactionRelationships(sector);
    
     new Newyork().generate(sector);
  }
   private void initFactionRelationships(SectorAPI sector)
  {
FactionAPI libertynavy = sector.getFaction("libertynavy");
    
FactionAPI pirates = sector.getFaction("pirates");
FactionAPI independent = sector.getFaction("independent");
     FactionAPI neutral = sector.getFaction("neutral");
    
     FactionAPI player = sector.getFaction("player");
libertynavy.setRelationship(pirates.getId(), RepLevel.HOSTILE);
libertynavy.setRelationship(neutral.getId(), RepLevel.NEUTRAL);
libertynavy.setRelationship(independent.getId(), RepLevel.NEUTRAL);
libertynavy.setRelationship(player.getId(), RepLevel.NEUTRAL);
player.setRelationship(libertynavy.getId(), 0);
  }

}

And error;

Spoiler
64253 [Thread-5] ERROR com.fs.starfarer.combat.D  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.scripts.world.SectorGen.initFactionRelationships(SectorGen.java:155)
   at data.scripts.world.SectorGen.generate(SectorGen.java:109)
   at com.fs.starfarer.campaign.save.CampaignGameManager.o00000(Unknown Source)
   at com.fs.starfarer.title.OoOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.dialogDismissed(Unknown Source)
   at com.fs.starfarer.ui.do.dismiss(Unknown Source)
   at com.fs.starfarer.ui.impl.O0oO.dismiss(Unknown Source)
   at com.fs.starfarer.campaign.save.O0oO.actionPerformed(Unknown Source)
   at com.fs.starfarer.ui.thisnew.super(Unknown Source)
   at com.fs.starfarer.ui.H.processInput(Unknown Source)
   at com.fs.starfarer.ui.thisnew.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.coreui.if.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.O0OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.I.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.do.processInputImpl(Unknown Source)
   at com.fs.starfarer.campaign.save.O0oO.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0o0.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.O0o0.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.processInput(Unknown Source)
   at com.fs.starfarer.title.OoOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.super(Unknown Source)
   at com.fs.starfarer.new.Òôo000(Unknown Source)
   at com.fs.oOOO.oOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.Ò00000(Unknown Source)
   at com.fs.starfarer.combat.D.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$2.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
[close]
Logged

Titann

  • Commander
  • ***
  • Posts: 122
    • View Profile
Re: Star system doesnt show up
« Reply #8 on: October 27, 2015, 10:34:26 AM »

All errors fixed by changing discoGen to SectorGen

I laughed so hard
Logged