Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Dark.Revenant]

Found another one!  Oh boy, this is why bounties kept spawning next to multiple markets.

line 503 of Misc.java:

Code: java

			if (!market.getPrimaryEntity().isInCurrentLocation()) continue;

This should be

Code: java

			if (market.getPrimaryEntity().getContainingLocation() != token.getContainingLocation()) continue;

As an aside, named bounties should probably use a market filter that takes into account diplomacy.  After all, it wouldn't be strange for a bounty to be hanging around Barad.

[Alex]

Hoo boy - thanks for spotting that, fixed!

(Yeah, named bounties are rather rough around the edges; I'll probably just end up reworking them completely at some point.)

[Dark.Revenant]

While looking at the autoresolver to see what affects it...

Line 655

Code: java

			float shieldMult = stats.getShieldAbsorptionMult().getModifiedValue() * stats.getShieldDamageTakenMult().getModifiedValue();

This doesn't use the new (proper) method of getting true shield strength, and beyond that will actually make the game think the shield is weaker if it takes less damage.  For example, an indestructible shield (damage taken mult = 0) is treated like the ship is unshielded.

[Alex]

Thanks!

So it should basically just be 1 - that, or am I missing something else here?

[Dark.Revenant]

Would be (1 / shield efficiency) * (1 / damage taken mult) * absorption mult, if I'm not mistaken on what absorption mult actually does, since I don't use it.

This will also require a division by zero check to skip all logic and set shield ratio to 1 if either efficiency or damage taken mult are sufficiently close to zero.

[Alex]

Riight, wasn't thinking straight.

Changed to:

Code: java

float shieldFluxPerDamage = hullSpec.getBaseShieldFluxPerDamageAbsorbed(); 
shieldFluxPerDamage *= stats.getShieldAbsorptionMult().getModifiedValue() * stats.getShieldDamageTakenMult().getModifiedValue();;
if (shieldFluxPerDamage < 0.1f) shieldFluxPerDamage = 0.1f;
float shieldMult = 1f / shieldFluxPerDamage;
normalizedShieldStr *= shieldMult;

Had to add a new API method; base shield flux/dam wasn't available from a hull spec API.

[Histidine]

Are the following properties of market conditions intentional?
- Marine demand from Outpost is entirely consuming demand (while Military Base's is 99% non-consuming)
- Cryosanctum demand for regular crew, volatiles, organics and machinery is multiplied by population, but supply of green crew and organs is flat

[Alex]

Thank you - bug with Outpost (fixed), not a bug with Cryosanctum.

[TJJ]

Not a code mistake as such, but "com/fs/graphics/TextureLoader" (in fs.common_obf.jar) references "de/matthiasmann/twl/utils/PNGDecoder$Format". (
PNGDecoder is not in the classpath, and is in fact not even included in the Starsector distribution.

I don't think it'll ever impact upon normal operation of the game, just an exceptional case I've had to code-around while developing SSME.

[Alex]

Yeah, that bit of code is never called, so...

(Was trying out some stuff to see if I could get faster PNG loading, but no dice on that attempt.)

[Histidine]

(0.7 spoilers!)

Spoiler

InvestigationEventGoodRepWithOther.java, line 124 (in startEvent()):

Code: java

numPrior = faction.getMemoryWithoutUpdate().getFloat(MemFlags.MEMORY_KEY_NUM_GR_INVESTIGATIONS);

Lines 288-289 (in endEvent()):

Code: java

numPrior++;
faction.getMemoryWithoutUpdate().set(MemFlags.MEMORY_KEY_NUM_GR_INVESTIGATIONS, numPrior);

It increments numPrior even if the investigation is cancelled at start due to invalid relationships or faction settings, or somehow failing to find a market.

[close]

[Alex]

Nice catch, thanks! Fixed.

[Histidine]

More 0.7 stuff (FleetFactoryV2.java, lines 109-117)

Code: java

		addRandomShips(transportPts, qf, fleet, random, market, 
				ShipRoles.PERSONNEL_SMALL,
				ShipRoles.PERSONNEL_MEDIUM,
				ShipRoles.PERSONNEL_LARGE);
		
		addRandomShips(transportPts, qf, fleet, random, market, 
				ShipRoles.PERSONNEL_SMALL,
				ShipRoles.PERSONNEL_MEDIUM,
				ShipRoles.PERSONNEL_LARGE);

I think the second batch of personnel transports are supposed to be liners instead.

[Dark.Revenant]

Not that liners are ever actually used in the core campaign.

[Alex]

Right, thanks - yeah, that was a placeholder for liners; changed it to add liners a couple of days ago