Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.95a is out! (03/26/21); Blog post: Skill Changes, Part 2 (07/15/21)

Pages: 1 [2]

Author Topic: [0.95a] Fleet Action History v1.0.6 - battle logs, ship kill counts and more  (Read 7162 times)

briansd9

  • Ensign
  • *
  • Posts: 31
    • View Profile

Can you take a look to this crash? (modversion 1.02)
After I join the battle and click to auto resolve (second in command) the game crashed. I had a save before the battle and try to repeat the same procedure but suddenly... no crash :D strange...

Spoiler
1612505 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at fleethistory.types.BattleRecord.setCaptains(BattleRecord.java:154)
   at fleethistory.types.BattleRecord.setPlayerFleetStrength(BattleRecord.java:141)
   at fleethistory.listeners.BattleListener.logPlayerFleetOutcome(BattleListener.java:130)
   at fleethistory.listeners.BattleListener.logCombatResults(BattleListener.java:61)
   at fleethistory.listeners.BattleListener.reportPlayerEngagement(BattleListener.java:52)
   at com.fs.starfarer.campaign.CampaignEngine.reportPlayerEngagement(Unknown Source)
   at com.fs.starfarer.api.impl.campaign.FleetEncounterContext.processEngagementResul ts(FleetEncounterContext.java:247)
   at com.fs.starfarer.api.impl.campaign.FleetInteractionDialogPluginImpl.backFromEng agement(FleetInteractionDialogPluginImpl.java:590)
   at exerelin.campaign.battle.NexFleetInteractionDialogPluginImpl.backFromEngagement(NexFleetInteractionDialogPluginImpl.java:90)
   at com.fs.starfarer.api.impl.campaign.FleetInteractionDialogPluginImpl$1.pickedFleetMembers(FleetInteractionDialogPluginImpl.java:1385)
   at com.fs.starfarer.ui.newui.oOOoOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.advance(Unknown Source)
   at com.fs.starfarer.ui.v.advanceImpl(Unknown Source)
   at com.fs.starfarer.ui.Oo0O.advanceImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.Stringsuper.advanceImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.advance(Unknown Source)
   at com.fs.starfarer.ui.v.advanceImpl(Unknown Source)
   at com.fs.starfarer.ui.o00O.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
[close]

Hmm, not sure how that happened, thought autoresolve was already handled...

I've just uploaded v1.0.3, please update from link in first post and check if it happens again. Thanks very much for the report
« Last Edit: June 07, 2021, 10:11:23 AM by briansd9 »
Logged

Gabs

  • Ensign
  • *
  • Posts: 1
    • View Profile
    • Email

Heyo, absolutely love your mod.
Recently i've been messing with as many mods as possible, and, after some playing around, i'll always get the following problem when loading my save.
Spoiler
7801779 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading C:\Program Files (x86)\Fractal Softworks\Starsector\starsector-core\..\saves\save_Zero_695767075943828095...
7801783 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 2
7801783 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 3
7804153 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Error loading
7804154 [Thread-3] ERROR com.fs.starfarer.campaign.save.CampaignGameManager  - Failed calling method
---- Debugging information ----
message             : Failed calling method
cause-exception     : java.lang.NullPointerException
cause-message       : null
method              : com.fs.starfarer.campaign.fleet.FleetMember.readResolve()
class               : com.fs.starfarer.campaign.fleet.FleetMember
required-type       : com.fs.starfarer.campaign.fleet.FleetMember
converter-type      : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
line number         : 859352
class[1]            : java.util.HashMap
converter-type[1]   : com.thoughtworks.xstream.converters.collections.MapConverter
class[2]            : com.fs.starfarer.campaign.ModAndPluginData
class[3]            : com.fs.starfarer.campaign.CampaignEngine
converter-type[2]   : com.fs.starfarer.campaign.save.I
version             : not available
-------------------------------
com.thoughtworks.xstream.converters.ConversionException: Failed calling method
---- Debugging information ----
message             : Failed calling method
cause-exception     : java.lang.NullPointerException
cause-message       : null
method              : com.fs.starfarer.campaign.fleet.FleetMember.readResolve()
class               : com.fs.starfarer.campaign.fleet.FleetMember
required-type       : com.fs.starfarer.campaign.fleet.FleetMember
converter-type      : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
line number         : 859352
class[1]            : java.util.HashMap
converter-type[1]   : com.thoughtworks.xstream.converters.collections.MapConverter
class[2]            : com.fs.starfarer.campaign.ModAndPluginData
class[3]            : com.fs.starfarer.campaign.CampaignEngine
converter-type[2]   : com.fs.starfarer.campaign.save.I
version             : not available
-------------------------------
   at com.thoughtworks.xstream.core.util.SerializationMembers.callReadResolve(SerializationMembers.java:82)
   at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unma rshal(AbstractReflectionConverter.java:282)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
   at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:70)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:66)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:50)
   at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.rea dItem(AbstractCollectionConverter.java:73)
   at com.thoughtworks.xstream.converters.collections.MapConverter.putCurrentEntryInt oMap(MapConverter.java:106)
   at com.thoughtworks.xstream.converters.collections.MapConverter.populateMap(MapConverter.java:98)
   at com.thoughtworks.xstream.converters.collections.MapConverter.populateMap(MapConverter.java:92)
   at com.thoughtworks.xstream.converters.collections.MapConverter.unmarshal(MapConverter.java:87)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
   at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:70)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:66)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:50)
   at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.rea dItem(AbstractCollectionConverter.java:73)
   at com.thoughtworks.xstream.converters.collections.MapConverter.putCurrentEntryInt oMap(MapConverter.java:110)
   at com.thoughtworks.xstream.converters.collections.MapConverter.populateMap(MapConverter.java:98)
   at com.thoughtworks.xstream.converters.collections.MapConverter.populateMap(MapConverter.java:92)
   at com.thoughtworks.xstream.converters.collections.MapConverter.unmarshal(MapConverter.java:87)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
   at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:70)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:66)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:50)
   at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.rea dItem(AbstractCollectionConverter.java:73)
   at com.thoughtworks.xstream.converters.collections.MapConverter.putCurrentEntryInt oMap(MapConverter.java:110)
   at com.thoughtworks.xstream.converters.collections.MapConverter.populateMap(MapConverter.java:98)
   at com.thoughtworks.xstream.converters.collections.MapConverter.populateMap(MapConverter.java:92)
   at com.thoughtworks.xstream.converters.collections.MapConverter.unmarshal(MapConverter.java:87)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
   at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:70)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:66)
   at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unma rshallField(AbstractReflectionConverter.java:503)
   at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.doUn marshal(AbstractReflectionConverter.java:429)
   at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unma rshal(AbstractReflectionConverter.java:281)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
   at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:70)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:66)
   at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unma rshallField(AbstractReflectionConverter.java:503)
   at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.doUn marshal(AbstractReflectionConverter.java:429)
   at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unma rshal(AbstractReflectionConverter.java:281)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
   at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:70)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:66)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:50)
   at com.thoughtworks.xstream.core.TreeUnmarshaller.start(TreeUnmarshaller.java:134)
   at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.unmarshal(AbstractTreeMarshallingStrategy.java:32)
   at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1486)
   at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1466)
   at com.thoughtworks.xstream.XStream.fromXML(XStream.java:1346)
   at com.fs.starfarer.campaign.save.CampaignGameManager.o00000(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.dialogDismissed(Unknown Source)
   at com.fs.starfarer.ui.Oo0O.dismiss(Unknown Source)
   at com.fs.starfarer.ui.impl.o0oO.dismiss(Unknown Source)
   at com.fs.starfarer.campaign.save.LoadGameDialog.actionPerformed(Unknown Source)
   at com.fs.starfarer.ui.newnew.buttonPressed(Unknown Source)
   at com.fs.starfarer.ui.I.Ò00000(Unknown Source)
   at com.fs.starfarer.ui.I.processInput(Unknown Source)
   at com.fs.starfarer.ui.Stringsuper.super(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
[close]
I've managed to pinpoint some of your logging as the main problem, although I don't know if the reason is your mod itself. I recovered my savefile just fine, just wanted to share the problem with you. If you want my save or anything else, I'd be glad to share.
Logged

briansd9

  • Ensign
  • *
  • Posts: 31
    • View Profile

Heyo, absolutely love your mod.
Recently i've been messing with as many mods as possible, and, after some playing around, i'll always get the following problem when loading my save.
Spoiler
---- Debugging information ----
message             : Failed calling method
cause-exception     : java.lang.NullPointerException
cause-message       : null
method              : com.fs.starfarer.campaign.fleet.FleetMember.readResolve()
class               : com.fs.starfarer.campaign.fleet.FleetMember
required-type       : com.fs.starfarer.campaign.fleet.FleetMember
converter-type      : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
line number         : 859352
class[1]            : java.util.HashMap
converter-type[1]   : com.thoughtworks.xstream.converters.collections.MapConverter
class[2]            : com.fs.starfarer.campaign.ModAndPluginData
class[3]            : com.fs.starfarer.campaign.CampaignEngine
converter-type[2]   : com.fs.starfarer.campaign.save.I
version             : not available
-------------------------------
[close]
I've managed to pinpoint some of your logging as the main problem, although I don't know if the reason is your mod itself. I recovered my savefile just fine, just wanted to share the problem with you. If you want my save or anything else, I'd be glad to share.

Hi, thanks very much for the report, will look into this.

Do you still have the savefile that throws this error when loading? Would appreciate if you can upload it for me somewhere.
Logged

Reggie

  • Ensign
  • *
  • Posts: 7
    • View Profile
    • Email

Hi there! love the mod but found a strange recurring bug while playing. (v1.0.3) and starsector version [0.95a]
some time during a new campaign when I check the fleet history tab and look through the results I will open my character sheet and find a ridiculous amount of story points added. First time this happened I had gained 120 SP and the most recent was 40 SP. after some playesting I Isolated the bug to this mod (I have alot of mods so i wasnt sure which one was doing this.) I also noticed that it doesn't happen 100% of the time. It may be after a certain amount of battles are logged since I noticed it happening 5-7 months into a campaign. I did a cursory glance through your code but couldn't find any reference to story points so this is a really weird problem.
Logged

briansd9

  • Ensign
  • *
  • Posts: 31
    • View Profile

Hi there! love the mod but found a strange recurring bug while playing. (v1.0.3) and starsector version [0.95a]
some time during a new campaign when I check the fleet history tab and look through the results I will open my character sheet and find a ridiculous amount of story points added. First time this happened I had gained 120 SP and the most recent was 40 SP. after some playesting I Isolated the bug to this mod (I have alot of mods so i wasnt sure which one was doing this.) I also noticed that it doesn't happen 100% of the time. It may be after a certain amount of battles are logged since I noticed it happening 5-7 months into a campaign. I did a cursory glance through your code but couldn't find any reference to story points so this is a really weird problem.

Oh my Ludd!



I have absolutely no recollection of adding this??

[Edit] By the way, it happens when you mouse over a ship that you lost in the "deployed forces" section of the battle report.

Thanks very much for the report, it is fixed in v1.0.4.

« Last Edit: June 26, 2021, 06:17:58 PM by briansd9 »
Logged

Reggie

  • Ensign
  • *
  • Posts: 7
    • View Profile
    • Email

Hi there! love the mod but found a strange recurring bug while playing. (v1.0.3) and starsector version [0.95a]
some time during a new campaign when I check the fleet history tab and look through the results I will open my character sheet and find a ridiculous amount of story points added. First time this happened I had gained 120 SP and the most recent was 40 SP. after some playesting I Isolated the bug to this mod (I have alot of mods so i wasnt sure which one was doing this.) I also noticed that it doesn't happen 100% of the time. It may be after a certain amount of battles are logged since I noticed it happening 5-7 months into a campaign. I did a cursory glance through your code but couldn't find any reference to story points so this is a really weird problem.

Oh my Ludd!



I have absolutely no recollection of adding this??

[Edit] By the way, it happens when you mouse over a ship that you lost in the "deployed forces" section of the battle report.

Thanks very much for the report, it is fixed in v1.0.4.



 :) :) Nice! i really like this mod and im glad you were able to figure this one out!
Logged

Mr_8000

  • Ensign
  • *
  • Posts: 38
    • View Profile

I seem to have run into the same issue as Gabs, used version is 1.0.3 so I apologize if this has already been fixed.
I've uploaded the error, the full log, and the save file here: https://drive.google.com/file/d/1AdKR-RruonLX8WTa-ReqoGYx9Mg8Akpu/view?usp=sharing
Logged

briansd9

  • Ensign
  • *
  • Posts: 31
    • View Profile

I seem to have run into the same issue as Gabs, used version is 1.0.3 so I apologize if this has already been fixed.
I've uploaded the error, the full log, and the save file here: https://drive.google.com/file/d/1AdKR-RruonLX8WTa-ReqoGYx9Mg8Akpu/view?usp=sharing

Thanks for the upload, I have found the bug and it will be fixed in the next release.

Would you like your save file repaired? I can remove the bad data and send it back to you.

Also, did you notice anything out of the ordinary before saving this game? Battles not logged properly, etc.? The root cause of the error is some temporary data not properly cleaned up (but cleanup should always happen after a battle)
Logged

Mr_8000

  • Ensign
  • *
  • Posts: 38
    • View Profile

Thank you for the offer, but I have already cleaned it up myself.

As for anything unusual ... can't say that I have, though I don't often check the battle log before saving so no guarantees.

I would also like to make a suggestion, all the current combat statistics are measured in fleet points, which aren't a player facing value. Is it possible to display them in deployment points? Alternatively, I'd like a way to see my ship's individual FP value, so that I have at least some grounds for comparison when looking at their kill log (this might already be implemented and I'm just being blind).
Logged

SoulMan

  • Ensign
  • *
  • Posts: 3
    • View Profile

Thanks for the upload, I have found the bug and it will be fixed in the next release.

Would you like your save file repaired? I can remove the bad data and send it back to you.

Also, did you notice anything out of the ordinary before saving this game? Battles not logged properly, etc.? The root cause of the error is some temporary data not properly cleaned up (but cleanup should always happen after a battle)

How does one go about repairing their save?  I have the same crash with my save file (and my last backup was a few hours prior, so I would rather not loose my progress).
Logged

briansd9

  • Ensign
  • *
  • Posts: 31
    • View Profile

all the current combat statistics are measured in fleet points, which aren't a player facing value. Is it possible to display them in deployment points?
Hmm, I will think about it, but it would be rather difficult.

Quote
Alternatively, I'd like a way to see my ship's individual FP value, so that I have at least some grounds for comparison when looking at their kill log (this might already be implemented and I'm just being blind).
Good idea, will implement in an upcoming release.
Logged

briansd9

  • Ensign
  • *
  • Posts: 31
    • View Profile

How does one go about repairing their save?  I have the same crash with my save file (and my last backup was a few hours prior, so I would rather not loose my progress).

If it's the same error, removing the "CURR_BATTLE_CHILD_PARENT_SHIPS" entry in campaign.xml will fix it. It'll look something like this:

Code
<e>
<st>CURR_BATTLE_CHILD_PARENT_SHIPS</st>
<map z="385455">
   ... lots of stuff...
</map>
</e>
This whole structure needs to be removed, including the enclosing <e></e>.
Logged

briansd9

  • Ensign
  • *
  • Posts: 31
    • View Profile

Just released version 1.0.6 to fix the bug that makes saves unloadable.

Instructions for repairing affected savefiles are in the post above this one. If anyone needs help with this, send me your save and I'll fix it for you
Logged

SoulMan

  • Ensign
  • *
  • Posts: 3
    • View Profile

How does one go about repairing their save?  I have the same crash with my save file (and my last backup was a few hours prior, so I would rather not loose my progress).

If it's the same error, removing the "CURR_BATTLE_CHILD_PARENT_SHIPS" entry in campaign.xml will fix it. It'll look something like this:

Code
<e>
<st>CURR_BATTLE_CHILD_PARENT_SHIPS</st>
<map z="385455">
   ... lots of stuff...
</map>
</e>
This whole structure needs to be removed, including the enclosing <e></e>.

Thanks! Did the trick.  Love the mod. =)
Logged
Pages: 1 [2]