Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: Defender marines counted as Elite crew when boarding  (Read 1361 times)

Kiloman

  • Ensign
  • *
  • Posts: 35
    • View Profile
Defender marines counted as Elite crew when boarding
« on: October 13, 2013, 12:33:40 AM »
Not sure if this is intentional or not, but it looks kind of like a copy-paste issue:

Code: java
		CrewCompositionAPI defenderCrew = member.getCrewComposition();
		float defenderStr = defenderCrew.getGreen() * greenMult + 
							defenderCrew.getRegular() * regularMult +
							defenderCrew.getVeteran() * veteranMult +
							defenderCrew.getElite() * eliteMult +
							defenderCrew.getMarines() * eliteMult;
		defenderStr *= defenderMarineMult;

The defender marine count is multiplied by the elite multiplier, not the marine multiplier... so strength 2 instead of 7. Seems like it would pretty heavily favor the attacker.


Also - looks like the old alg for deployment cost is used to calculate the CR hit for boarding actions? Not sure if that's a bug either.
« Last Edit: October 13, 2013, 12:50:02 AM by Kiloman »
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 24123
    • View Profile
Re: Defender marines counted as Elite crew when boarding
« Reply #1 on: October 13, 2013, 10:05:21 AM »
Thanks, fixed!

Quote from: Kiloman on October 13, 2013, 12:33:40 AM
Also - looks like the old alg for deployment cost is used to calculate the CR hit for boarding actions? Not sure if that's a bug either.

Boarding actions are supposed to incur the same CR as deploying a ship into battle. Not sure what you mean by "old algorithm", though, perhaps I'm missing something here?

... ahh, I see what you mean. Right, right, it ought to be calling getDeployCost() instead. The code inside that method is exactly the same as what it's doing, but still :) Thanks for pointing that out, fixed it up too!
Logged