Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Cycerin]

Code

346963 [Thread-6] INFO  com.fs.profiler.Profiler  -   Other                                                                                           -      0,00s      0,00%
346964 [Thread-6] ERROR com.fs.starfarer.combat.D  - java.util.UnknownFormatConversionException: Conversion = '.'
java.util.UnknownFormatConversionException: Conversion = '.'
	at java.util.Formatter.checkText(Formatter.java:2503)
	at java.util.Formatter.parse(Formatter.java:2485)
	at java.util.Formatter.format(Formatter.java:2414)
	at java.util.Formatter.format(Formatter.java:2367)
	at java.lang.String.format(String.java:2769)
	at com.fs.starfarer.loading.specs.oOoo.Ò00000(Unknown Source)
	at com.fs.starfarer.coreui.refit.ModPickerDialog$o.<init>(Unknown Source)
	at com.fs.starfarer.coreui.refit.ModPickerDialog.Ööo000(Unknown Source)
	at com.fs.starfarer.coreui.refit.ModPickerDialog.<init>(Unknown Source)
	at com.fs.starfarer.coreui.refit.ooOO.actionPerformed(Unknown Source)
	at com.fs.starfarer.ui.O00o.super(Unknown Source)
	at com.fs.starfarer.ui.F.processInput(Unknown Source)
	at com.fs.starfarer.ui.newsuper.o00000(Unknown Source)
	at com.fs.starfarer.new.øÒÒ000(Unknown Source)
	at com.fs.oOOO.super.new(Unknown Source)
	at com.fs.starfarer.combat.D.o00000(Unknown Source)
	at com.fs.starfarer.StarfarerLauncher$2.run(Unknown Source)
	at java.lang.Thread.run(Thread.java:619)

Not quite sure what this might be about. Said ship had a built in custom hullmod, dont know if it's related in any way, but I've changed hullmods several times without incidents after I implemented that.

[Wyvern]

Looks like you have a "%." in a hullmod description string, where you probably wanted a "%%." - since '%' is being used as an escape character.

[Cycerin]

Hmm, I have %s, being used to pull a number from the hullmod file.

[Wyvern]

Say the string you wanted to display to the user was "Increases blah by 5%."  What you'd expect to see in the .csv file for that is "Increases blah by %s%%."  If you instead had "Increases blah by %s%.", then you'd get exactly this error message; the second '%' sign would be treated as an escape character, and then the formatter would explode because '.' isn't a valid thing to be escaped.

[Cycerin]

Ah, I see. Thanks Still, I wonder why it only crashes rarely and not every time like this.

[Alex]

Ah, I see. Thanks Still, I wonder why it only crashes rarely and not every time like this.

It'll crash any time you try to mouseover the hullmod with the description that has an error in it and it tries to create the tooltip for it.

[Cycerin]

Strangely enough, it didn't happen every time I did that. But removed the escape now, anyway.

[Cycerin]

Okay, still happens despite the hull mod description being plaintext. Crashes to desktop when I try to change hullmods in dev mode in the variant edit menu or in missions. I think it's related to the hull-mod being built into the ships but still appearing in the hull mods menu.

This is the hull mod itself:

Code

package data.hullmods;

import com.fs.starfarer.api.combat.MutableShipStatsAPI;
import com.fs.starfarer.api.combat.ShipAPI.HullSize;

public class BlackrockFlux extends BaseHullMod {

	public static final float VENT_RATE_BONUS = 100f;
	
	public void applyEffectsBeforeShipCreation(HullSize hullSize, MutableShipStatsAPI stats, String id) {
		stats.getVentRateMult().modifyPercent(id, VENT_RATE_BONUS);
	}
	
	public String getDescriptionParam(int index, HullSize hullSize) {
		if (index == 0) return "" + (int) VENT_RATE_BONUS;
		return null;
	}


}

And in hullmods.csv, it's not set to unlocked: true and so forth. Basically this hullmod is supposed to just be a part of the ships and to be unattainable in any other way. Ideally it would never show up in menus either. What gives?

EDIT: Actually, it seems like a conflict between mods. I disabled one and now I cant reproduce it... hmmm.

[Alex]

Maybe another mod had the same hullmod id and an error with the description? In any event, quite sure it's an error with the description - the stack trace is pretty definitive.

(As for not showing up in the hullmod selection dialog: it'll only show up in the dev mod "edit variants". Or if some skill ends up unlocking it, which wouldn't be the case.)