Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[AtlanticAccent]

Hi Alex!

I've discovered that you can very effectively abuse StoryPointActionDelegate and OptionPanelAPI.addOptionConfirmation to add new options to dialogs at runtime, circumventing rules.csv and also allowing you to extend FleetInteractionDialogImpl (which afaik is not rules.csv extensible).

May I recommend renaming StoryPointActionDelegate or adding an ancestor interface to really spell out the fact it can be used to add options to OptionPanelAPIs at runtime.

Also, I'll probably figure this out in a bit or not at all, but is there a way to prevent the "Story Points: [num]" element from being added to the subsequent popup/tooltip triggered on clicking an option added as described above? If not, could one be added please?

[RustyCabbage]

It seems com.fs.starfarer.api.campaign.SubmarketPlugin has

Code

boolean isBlackMarket();
boolean isOpenMarket();

but does not have

Code

boolean isMilitaryMarket();

Could it be added?

[Jaghaimo]

Also, I'm trying to display them using tooltip maker but neither addSkillPanel nor addSkillPanelOneColumn seems to work - are these methods hardcoded to just officer skills? Seems different to `printSkills` behaviour used in rules.csv.

Hmm yeah, those methods look hardcoded to print officer skills only.

Is that intentional, or could we expect this to work with admin skills as well? Yes, making a suggestion for the `addSkillPanel` and `addSkillPanelOneColumn` to work for both admins and officers

[123nick]

Can FighterLaunchBayAPI.setExtraDeployments be modified to take negative integers to REDUCE the number of active fighters in a wing? or atleast, can there be another method like FighterLaunchBayAPI.setReducedDeployments that does the same thing? i want to make a hullmod that reduces the # of fighters in a wing/LPC/bay/whatever, but afaik it is IMPOSSIBLE with the current methods in the starsector API!!!

[float]

Can we have a CustomCampaignEntityAPI.setSalvageRating? Currently it's possible to change just about everything about a salvageable item on a per-item basis (e.g. its radius, name, etc.), so it'd make sense to also be able to set salvage ratings on a per-item basis, rather than needing to have a different custom entity spec for each rating.

[THEASD]

Code

public MutableStat getBeamSpeedMult();

for MutableShipStatsAPI, thanks

[Maru7]

Need API to modify "maxShipsInFleet" and "suppliesPerShipOverMaxInFleet" defined in config/settings.json,
I want them to be modifiable in the same way as modifyFlat(), modifyMult(), modifyPercent() in MutableShipStatsAPI.
I know these data are not stored in saveddata right now, but maybe we can store them like other data affected by character skill (such as storing them in MutableCharacterStatsAPI or MutableFleetStatsAPI)?
thanks!

[Sundog]

MutableShipStatsAPI.getFleetMember returns null prior to calculating the max CR of ships in the player fleet*. I believe this is the source of a bug in one of my mods. Could getFleetMember be improved to provide the member in this situation? Thanks for consideration!

*Edit: I'm not certain when exactly the call fails, but it happens prior to opening the fleet screen during one/some of the multiple stat applications.

[Jaghaimo]

A simple request - CutStyle.NONE - renders regular button with no cut corners.

[Liral]

Make Global.getCombatEngine().isUIShowingHUD() return true when the UI is showing the HUD and false when it is not.  This function is instead inverted, returning false when the UI is showing the HUD and true when it is not.

Edit: My apologies, it finally works as indicated now.  Woo!

[Zsar]

Please

• overload method FleetEventListener#reportBattleOccurred(CampaignFleetAPI, CampaignFleetAPI, BattleAPI, EngagementResultForFleetAPI) and call it with the obfuscated object that has filled fields backing the accessors EngagementResultForFleetAPI#getDestroyed, EngagementResultForFleetAPI#getDisabled, which is currently created and filled after every battle but completely inaccessible from mod code.
• deprecate method FleetEventListener#reportBattleOccurred(CampaignFleetAPI, CampaignFleetAPI, BattleAPI) in favour of the new one

[Nia Tahl]

EngineControllerAPI or EngineSlotAPI method for controlling or at least disabling the flaring of engines like during strafing or reversing would be much appreciated

[Sorrydough]

I'd also like to have an engine feature: I want them to behave like always-active 128 contrail engines. For example, set it to contrail 127 and the engine won't take damage in combat, but will still turn off if the ship gets fully flamed out. Therefore the engine is entirely cosmetic.

[Lukas04]

a "overwriteColor" boolean return method in BaseHullmod that lets you overwrite the build-in gray and storypoint green for a hullmod.

[SafariJohn]

For BaseLocation.LocationToken please implement a backing field for getName() and setName().