Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[LazyWizard]

SectorEntityToken:

• LocationAPI getContainingLocation()

FactoryAPI:

• CargoAPI createCargo()

That would allow us to create temporary/hidden cargo containers without creating fleets or faraway stations.

Can weapons exist without a ship? If so, could FactoryAPI get a createWeapon() so we can analyse the properties of weapon stacks (things like weapon size, etc)?

Also, could CargoAPI, CargoStackAPI, and FleetDataAPI get hashCode() implementations based on their contents? It would help when checking if they have been modified (right now we need to keep a copy of their prior contents around to diff against).

On a related note, I expect to have to break some parts of the API horribly after the 0.54.1a release...

Is there any part of the API in particular we should avoid relying on, or can you not tell us without revealing the next planned feature?

[Alex]

SectorEntityToken:

• LocationAPI getContainingLocation()

Added. Let me see about the other ones... might not get to them for this release, though.

Also, could CargoAPI, CargoStackAPI, and FleetDataAPI get hashCode() implementations based on their contents? It would help when checking if they have been modified (right now we need to keep a copy of their prior contents around to diff against).

o1.hashCode() == o2.hashCode() does not imply o1.equals(o2). Am I missing something about how you intended to use it?

On a related note, I expect to have to break some parts of the API horribly after the 0.54.1a release...

Is there any part of the API in particular we should avoid relying on, or can you not tell us without revealing the next planned feature?

'fraid not Well, I can "narrow it down" to campaign stuff.

[LazyWizard]

Also, could CargoAPI, CargoStackAPI, and FleetDataAPI get hashCode() implementations based on their contents? It would help when checking if they have been modified (right now we need to keep a copy of their prior contents around to diff against).

o1.hashCode() == o2.hashCode() does not imply o1.equals(o2). Am I missing something about how you intended to use it?

A hash should change if the contents change, correct? So instead of iterating through every stack and comparing them against a reference copy to see if they have changed, we could just use

Code

if (cargo.hashCode() != lastHash)
{
   lastHash = cargo.hashCode();
   // Do stuff
}

[Wyvern]

Not quite; the contract for hashcode is that, if object1.equals(object2), then object1.hashcode() == object2.hashcode().

So, a perfectly valid (if ridiculously suboptimal) hashcode implementation might be something like { return 1; }

Now, the code you suggested should usually work (assuming a mostly-sane hashcode implementation & a .equals method based on contents), but it's not guaranteed.

It sounds like what you want is a .equals method implemented based on contents (which would necessitate a hashcode based on same), and perhaps also a copy constructor.

[Alex]

(hashCode() javadoc, for reference...)

[Zhentar]

It sounds like what you want is a .equals method implemented based on contents (which would necessitate a hashcode based on same), and perhaps also a copy constructor.

What he wants is to be able to tell if the contents have been mutated with a single comparison. The easiest way to accomplish this is not by implementing equals/hashCode (I dunno about Java, but in .NET land making either of those depend on mutable state is considered a bad idea), but instead by exposing a "version" counter that gets incremented whenever the contents are modified.

[Wyvern]

Could we get a getHullType method?  At the moment, we're limited to something like:

Code

	 private static String getHullType( FleetMemberAPI ship ) {
		 if (ship.isFighterWing()) {
			 return ship.getSpecId();
		 }
		 int lastIndex = ship.getSpecId().lastIndexOf("_");

		 if (lastIndex > 0) {
			 return ship.getSpecId().substring(0, lastIndex);
		 }

		 return ship.getSpecId();
	 }

Which works fine most of the time, but fails if, for example, someone made a default variant with a name like "liao-freighter-standard" instead of "liao-freighter_standard".

[LazyWizard]

I'm wondering, does FleetMemberAPI have an underlying ShipAPI object for bonus calculation and display? If so, could FleetMemberAPI have a getShip() method?

[Alex]

Could we get a getHullType method?  At the moment, we're limited to something like:

Code

	 private static String getHullType( FleetMemberAPI ship ) {
		 if (ship.isFighterWing()) {
			 return ship.getSpecId();
		 }
		 int lastIndex = ship.getSpecId().lastIndexOf("_");

		 if (lastIndex > 0) {
			 return ship.getSpecId().substring(0, lastIndex);
		 }

		 return ship.getSpecId();
	 }

Which works fine most of the time, but fails if, for example, someone made a default variant with a name like "liao-freighter-standard" instead of "liao-freighter_standard".

Added FleetMemberAPI.getHullId(). Returns the hull (*not* wing) id for fighters, btw.

I'm wondering, does FleetMemberAPI have an underlying ShipAPI object for bonus calculation and display? If so, could FleetMemberAPI have a getShip() method?

It doesn't. (new Ship objects get created all over the place - for the tooltip, for the duration of a battle, every time anything about the loadout changes on the refit screen, etc), but it does have a MutableShipStats object stats for what you've said. Added MutableShipStatsAPI getStats(); to FleetMemberAPI.

[LazyWizard]

I'm wondering, does FleetMemberAPI have an underlying ShipAPI object for bonus calculation and display? If so, could FleetMemberAPI have a getShip() method?

It doesn't. (new Ship objects get created all over the place - for the tooltip, for the duration of a battle, every time anything about the loadout changes on the refit screen, etc), but it does have a MutableShipStats object stats for what you've said. Added MutableShipStatsAPI getStats(); to FleetMemberAPI.

Just to check: we could then use getStats().getEntity() to get at the currently generated ShipAPI, or would it return null in this case?

Also, DamagingProjectileAPI and BeamAPI both have a getDamageTarget(), but BeamAPI's returns a ShipAPI and DamagingProjectileAPI returns an Object. Shouldn't both of these return a CombatEntityAPI?

[LazyWizard]

CargoStackAPI:

• CargoAPI getContainer()

[Alex]

Added.

Re: getEntity() - right, that'll return null.

getDamageTarget() - both return a CombatEntityAPI now.

[LazyWizard]

ShipAPI:

• List getDrones()
• ShipAPI getDroneSource()

I think we are missing something like the above two methods for dealing with drones.

Sprog's suggestion thread makes me think a get/setOutlivesSource(boolean) would be useful for drones as well.

[Wyvern]

Another useful parameter would be something like setNoCorpse(boolean) - important for when you have drones that launch drones.
Say we've got ship A launches drones D1 which launch drones D2.  Recalling D1 pulls them back in - but doesn't make the D1 drones recall their D2 drones, resulting in dead D2 drones, typically hovering right over ship A and causing massive damage, similar to what happens when you spawn with a collection of asteroids inside your ship.

If we could set the D2 drones to leave no corpse, this would be a non-issue; as it is, recalling the D1 drones is almost always a really bad idea.

[LazyWizard]

A getIndex() for drones would also be useful if we want to code special effects for certain drones in a formation.