Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.98a is out! (03/27/25)

Author Topic: [0.98a-RC7] Deflated fleets unexpectedly drop to low CR  (Read 479 times)

Dark.Revenant

  • Admiral
  • *****
  • Posts: 2901
    • View Profile
    • Sc2Mafia
[0.98a-RC7] Deflated fleets unexpectedly drop to low CR
« on: April 16, 2025, 11:43:01 PM »

Long-lasting fleets which persist in a deflated state seem to unexpectedly have some uniform (but low, like 20%) CR upon observation in the wild.  It's unclear whether this applies to fleets which are first inflated and then deflated, or all uninflated fleets in general.  I don't know the exact CR percentage they drop to, but it's uniform across the entire fleet and is distinctly not critical CR: the bar is yellow, not red.  Upon inflation, the fleet recovers CR as usual, but it seemingly remains at a low CR permanently until it's inflated.  I do not know which specific conditions trigger the problem, but it becomes quite consistent if a fleet remains deflated for a very long time.

This is a regression of behavior compared to 0.97a-RC11.  For important fleets (i.e., bounties and such), an easy workaround is to keep the fleets permanently inflated, but this still seems like a real problem.
Logged

David

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1162
    • View Profile
Re: [0.98a-RC7] Deflated fleets unexpectedly drop to low CR
« Reply #1 on: April 17, 2025, 06:49:22 AM »

I'm very confused by what you mean by "deflated" and "inflated" in this context.

And... searching in code, OK, this is a very specific internal variable name that I've never encountered.

OK. I'll forward this to Alex to figure out *thumbs up*.
Logged

Dark.Revenant

  • Admiral
  • *****
  • Posts: 2901
    • View Profile
    • Sc2Mafia
Re: [0.98a-RC7] Deflated fleets unexpectedly drop to low CR
« Reply #2 on: April 17, 2025, 08:50:53 AM »

For reference, fleet entities have some API methods named isInflated, inflateIfNeeded, deflate, etc…

Basically it’s a way to “uncompress” (inflate) and “compress” (deflate) a fleet, so that for instance a save file doesn’t contain every single individual autogenerated variant of every single fleet in the universe.  Spawned fleets are always uninflated by default until they’re vaguely near sensor range of the player.
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 26085
    • View Profile
Re: [0.98a-RC7] Deflated fleets unexpectedly drop to low CR
« Reply #3 on: April 17, 2025, 10:24:34 AM »

Thank you for the report! Hmm, so I'm not sure how to reproduce this. Here's what I tried:

Finding a bounty fleet, and making sure it got inflated. Then deflating it, hacking in a bit of code to prevent it from being re-inflated when it's seen by the player, and waiting for a couple of months in-game. Then I checked whether it was still in fact deflated (it was). Is CR had not budged.
Logged

Dark.Revenant

  • Admiral
  • *****
  • Posts: 2901
    • View Profile
    • Sc2Mafia
Re: [0.98a-RC7] Deflated fleets unexpectedly drop to low CR
« Reply #4 on: April 17, 2025, 11:34:42 AM »

Hmm.  Okay, I think I have better steps to reproduce.

Step 1: Spawn bounty.  Fleet has never been inflated.
Step 2: Save game.
Step 3: Figure out where fleet is.  Fleet inflates.
Step 4: Load game.  Fleet has never been inflated.
Step 5: Wait a while.  The longer waited, the longer the fleet will be losing CR in the background.
Step 6: Teleport to the fleet's location.  Observe low CR.

I *think* the save/load is an essential part.  I've never been able to reproduce it without at least one load-game in the process.
« Last Edit: April 17, 2025, 11:36:13 AM by Dark.Revenant »
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 26085
    • View Profile
Re: [0.98a-RC7] Deflated fleets unexpectedly drop to low CR
« Reply #5 on: April 17, 2025, 02:19:05 PM »

Aha, thank you! Should be fixed. The issue is during the load, it would think its crewed fraction was zero, and then that would not be updated.
Logged