Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[gladius2metal]

Not sure if this is a bug or intended: Salvage Rig, Level 7.
I can choose between "Increase maximum burn level by 1." and "Increase maximum burn level by 1." 

[float]

Not sure if this is a bug or intended: Salvage Rig, Level 7.
I can choose between "Increase maximum burn level by 1." and "Increase maximum burn level by 1." 

I thought I took care of this a while ago. Personally I haven't seen this issue pop up since, so it'd be rather difficult to diagnose. Looking at the code, and assuming you haven't modified the mastery presets or assignments jsons, I'm not immediately sure how this is possible, as existing mastery effects and sub-effects should be pruned out when generating new ones. But thanks for the report, I'll keep an eye out for this.

Edit: actually, upon closer inspection of the code, there's something like a 1/10000 chance that a duplicate sub-effect gets chosen (it's not entirely pruned, the selection chance just gets set to a really small number), so maybe you just got really unlucky?

[gladius2metal]

Edit: actually, upon closer inspection of the code, there's something like a 1/10000 chance that a duplicate sub-effect gets chosen (it's not entirely pruned, the selection chance just gets set to a really small number), so maybe you just got really unlucky?

I suspected that RNG Jesus might have blessed me. 

[Tenso]

Hey starfarers! Can anyone help me please? Looking for a way to modify the "Increase S-mod capacity by 1" option to give two or more max S-mods. Tried looking into config and .csv files but found nothing that could help. Can it be done at all? Has anyone tried and succeeded?

[Rift]

Encountered rare crash when piloting a nova

Spoiler

2585737 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException: Cannot read field "x" because "<parameter1>" is null
java.lang.NullPointerException: Cannot read field "x" because "<parameter1>" is null
   at com.fs.starfarer.combat.CombatViewport.isNearViewport(Unknown Source)
   at com.fs.starfarer.combat.entities.Ship.applyDamageInner(Unknown Source)
   at com.fs.starfarer.combat.entities.Ship.applyDamageInner(Unknown Source)
   at com.fs.starfarer.combat.entities.Ship.applyDamage(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.applyDamage(Unknown Source)
   at shipmastery.mastery.impl.combat.shipsystems.OrionDeviceDamage$OrionDeviceDamageScript.lambda$reportProjectileCreated$0(OrionDeviceDamage.java:104)
   at shipmastery.deferred.CombatDeferredActionPlugin.advance(CombatDeferredActionPlugin.java:33)
   at com.fs.starfarer.title.Object.L$Oo.o00000(Unknown Source)
   at com.fs.starfarer.combat.A.B.super(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.advanceInner(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.advance(Unknown Source)
   at com.fs.starfarer.combat.CombatState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.base/java.lang.Thread.run(Unknown Source)

[close]

[float]

Edit: actually, upon closer inspection of the code, there's something like a 1/10000 chance that a duplicate sub-effect gets chosen (it's not entirely pruned, the selection chance just gets set to a really small number), so maybe you just got really unlucky?

I suspected that RNG Jesus might have blessed me. 

Ah, unfortunately, upon *even further* inspection, if every possible stat effect has been selected before, then everything counts as a duplicate, and they all cancel each other out, making duplicates much more likely than I thought. Since civilian ships don't really have much of a selection, I suspect that's what's happening here. Fixed this in dev though, so thanks for the find!

Hey starfarers! Can anyone help me please? Looking for a way to modify the "Increase S-mod capacity by 1" option to give two or more max S-mods. Tried looking into config and .csv files but found nothing that could help. Can it be done at all? Has anyone tried and succeeded?

You are looking for mastery_presets.json in data/shipmastery, under the "DEFAULT" entry. The simplest would just be to repalce "SModCapacity" with "SModCapacity 2" or "SModCapacity 3", etc.

Encountered rare crash when piloting a nova

Spoiler

2585737 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException: Cannot read field "x" because "<parameter1>" is null
java.lang.NullPointerException: Cannot read field "x" because "<parameter1>" is null
   at com.fs.starfarer.combat.CombatViewport.isNearViewport(Unknown Source)
   at com.fs.starfarer.combat.entities.Ship.applyDamageInner(Unknown Source)
   at com.fs.starfarer.combat.entities.Ship.applyDamageInner(Unknown Source)
   at com.fs.starfarer.combat.entities.Ship.applyDamage(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.applyDamage(Unknown Source)
   at shipmastery.mastery.impl.combat.shipsystems.OrionDeviceDamage$OrionDeviceDamageScript.lambda$reportProjectileCreated$0(OrionDeviceDamage.java:104)
   at shipmastery.deferred.CombatDeferredActionPlugin.advance(CombatDeferredActionPlugin.java:33)
   at com.fs.starfarer.title.Object.L$Oo.o00000(Unknown Source)
   at com.fs.starfarer.combat.A.B.super(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.advanceInner(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.advance(Unknown Source)
   at com.fs.starfarer.combat.CombatState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.base/java.lang.Thread.run(Unknown Source)

[close]

Thanks, added a failsafe to dev. On that note, are you sure it was a nova? Nova burst and orion device should have separate (but similar) mastery effects.
Edit: next version won't be save compatible, you might have to disable that mastery on your end if it's continuing to cause issues.

[Rift]

Ah, I was in a nova but a mercenary fleet in the fight I overlooked brought a retribution.

[Tenso]

You are looking for mastery_presets.json in data/shipmastery, under the "DEFAULT" entry. The simplest would just be to repalce "SModCapacity" with "SModCapacity 2" or "SModCapacity 3", etc.

Wow! It was really that simple? Thank you! Tried it just now and it worked perfectly

[Tecrys]

Hi!
The following log is from and indev version of Symbiotic Void Creatures with Ship Mastery System, the game crashes after gaining a space whale and I believe this crash could be fixed on your side. Let me if I can do anything.
Thanks!

Spoiler

Code

423348 [main] ERROR com.fs.starfarer.combat.CombatMain java.lang.NullPointerException: Cannot invoke "com.fs.starfarer.api.campaign.FleetDataAPI.getFleet()" because the return value of "com.fs.starfarer.api.fleet.FleetMemberAPI.getFleetData()" is null 359423    
java.lang.NullPointerException: Cannot invoke "com.fs.starfarer.api.campaign.FleetDataAPI.getFleet()" because the return value of "com.fs.starfarer.api.fleet.FleetMemberAPI.getFleetData()" is null
359425 at shipmastery.util.VariantLookup.addVariantInfo(VariantLookup.java:77)
359424 at shipmastery.util.VariantLookup$VariantInfo.<init>(VariantLookup.java:117)
359426 at shipmastery.campaign.FleetHandler.addHandlerMod(FleetHandler.java:82)
359427 at shipmastery.campaign.PlayerFleetHandler.addMasteryHandlerToPlayerFleet(PlayerFleetHandler.java:63)
359428 at shipmastery.campaign.PlayerFleetHandler.reportEconomyTick(PlayerFleetHandler.java:52)
359429 at com.fs.starfarer.api.campaign.listeners.ListenerUtil.reportEconomyTick(ListenerUtil.java:122)
359430 at com.fs.starfarer.campaign.econ.reach.ReachEconomyStepper.doEndOfStepStuff(Unknown Source)
359431 at com.fs.starfarer.campaign.econ.reach.ReachEconomyStepper.nextFrame(Unknown Source)
359432 at com.fs.starfarer.campaign.econ.Economy.advance(Unknown Source)
359433 at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
359434 at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
359435 at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
359436 at com.fs.state.AppDriver.begin(Unknown Source)
359437 at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
359438 at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
359439 at com.fs.starfarer.StarfarerLauncher.<init>(Unknown Source)
359440 at com.fs.starfarer.StarfarerLauncher.<init>(Unknown Source)
359441  at com.fs.starfarer.StarfarerLauncher.main(Unknown Source)

[close]

[float]

Hi!
The following log is from and indev version of Symbiotic Void Creatures with Ship Mastery System, the game crashes after gaining a space whale and I believe this crash could be fixed on your side. Let me if I can do anything.
Thanks!

Spoiler

Code

423348 [main] ERROR com.fs.starfarer.combat.CombatMain java.lang.NullPointerException: Cannot invoke "com.fs.starfarer.api.campaign.FleetDataAPI.getFleet()" because the return value of "com.fs.starfarer.api.fleet.FleetMemberAPI.getFleetData()" is null 359423    
java.lang.NullPointerException: Cannot invoke "com.fs.starfarer.api.campaign.FleetDataAPI.getFleet()" because the return value of "com.fs.starfarer.api.fleet.FleetMemberAPI.getFleetData()" is null
359425 at shipmastery.util.VariantLookup.addVariantInfo(VariantLookup.java:77)
359424 at shipmastery.util.VariantLookup$VariantInfo.<init>(VariantLookup.java:117)
359426 at shipmastery.campaign.FleetHandler.addHandlerMod(FleetHandler.java:82)
359427 at shipmastery.campaign.PlayerFleetHandler.addMasteryHandlerToPlayerFleet(PlayerFleetHandler.java:63)
359428 at shipmastery.campaign.PlayerFleetHandler.reportEconomyTick(PlayerFleetHandler.java:52)
359429 at com.fs.starfarer.api.campaign.listeners.ListenerUtil.reportEconomyTick(ListenerUtil.java:122)
359430 at com.fs.starfarer.campaign.econ.reach.ReachEconomyStepper.doEndOfStepStuff(Unknown Source)
359431 at com.fs.starfarer.campaign.econ.reach.ReachEconomyStepper.nextFrame(Unknown Source)
359432 at com.fs.starfarer.campaign.econ.Economy.advance(Unknown Source)
359433 at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
359434 at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
359435 at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
359436 at com.fs.state.AppDriver.begin(Unknown Source)
359437 at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
359438 at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
359439 at com.fs.starfarer.StarfarerLauncher.<init>(Unknown Source)
359440 at com.fs.starfarer.StarfarerLauncher.<init>(Unknown Source)
359441  at com.fs.starfarer.StarfarerLauncher.main(Unknown Source)

[close]

Hmm.. looks like setting fleet to null if fleetData is null won't break things as it's only used to temporarily set the fleet's forceNoSync to avoid infinite recursion. I can do that.
Curious why you'd have a fleet member with no fleet data, though. The VariantLookup should only be processing fleet members that are part of a fleet (the whole procedure gets done in an inflation listener), so why wouldn't the offending fleet member's fleetData just be that fleet's fleetData?

[Tecrys]

I wish I could tell you but I'm not the coder for our mod. My code literacy is limited

[MerlinCross]

In the mastery menu, I have construct command under the 'Advance' one, it costs 10 mastery. I didn't see anything about it in the first post, and searching only coughed up stuff about Construct items to just get mastery points.

[Deathawaits4]

Coul you make the condition for the OP ship bonus toggleable to not require cybernetic augmentation? I am using the mod "second in command", so i don't have access to the skill, but still don't want to miss out on the bonus. This would be a great QOL feature.

[float]

In the mastery menu, I have construct command under the 'Advance' one, it costs 10 mastery. I didn't see anything about it in the first post, and searching only coughed up stuff about Construct items to just get mastery points.

You can just click on it, it has a confirmation screen that tells you what it does.

Coul you make the condition for the OP ship bonus toggleable to not require cybernetic augmentation? I am using the mod "second in command", so i don't have access to the skill, but still don't want to miss out on the bonus. This would be a great QOL feature.

Sorry, but no. The reason why SiC removes non-combat skills is because executive officers fill that role, and its removing Cybernetic Augmentation is clearly intentional (you'd lose access to the base game Cybernetic Augmentation running SiC as well). Cyberaug is a capstone skill costing 5 skill points and basically preventing you from taking automated ships (unless you fully spec into tech), just having it be on by default would be way too strong.

[Toast_King]

I'm not sure if it's working correctly with Tahlan Shipworks Silberblut Class Ships.  These are from two ships in the same fleet.  Notice that the "Built-in" number is different even though it should not be.
https://imgur.com/a/G8FtMcc