Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Genir]

Just a minor visual glitch. In system map view, planetary rings are rendered off-center. It's mostly visible with min zoom and smaller planets.

I noticed it only after removing grid lines from the map with Mnemonic Utils mod. Without the mod the rings are still off-center, but it's harder to spot.

[Alex]

Thank you, will take a closer look at some point! Not actually seeing this happening in any of the planet/ring combinations I've looked at so far.

[Genir]

I made a pristine vanilla savegame to make sure the issue isn't caused by mods. There are at least two offending rings I found: in Ishkur and Delta Dyriad systems. Screenshots attached. The save can be downloaded here.

[Alex]

Thank you! Hmm, looking at Delta Dyriad, it looks pretty close to centered and I suspect it's within the error tolerance of "rendering a fuzzy circular sprite, it's not going to be exact".

[Genir]

It appears there's no need to search in the fringes. I attach screenshots of Mayasura and Eos Exodus systems from the same save.

I would hazard a guess there's a off-by-one error triggered in some cases.

[Alex]

Looking at Eos Exodus, it appears to change depending on zoom level. I suspect that it's just due to rounding to integer coordinates somewhere.

[Genir]

I see, if the rounding is done by discarding the fractional part, instead of to the nearest integer, the result could look like that.

[Alex]

Hmm. Just a real quick test of removing the rounding/truncating seems like it actually doesn't change things. And there *is* explicit casting to an int in the code (i.e. discarding the fractional part), which is not strictly necessary, so I suspect it's actually there for a reason (i.e. something I don't currently remember looked bad w/o it). I'll... keep an eye on this.