Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24); In-development patch notes for Starsector 0.98a (2/8/25)

Author Topic: [0.96a-RC10] Confusing Combat Readiness information in Refit screen  (Read 511 times)

AcaMetis

  • Captain
  • ****
  • Posts: 499
    • View Profile

Setting a ship's CR value in the Refit screen to 40% can have the ship be just outside malfunction range or just inside of it, depending on precisely where the CR slider is set, although both cases will report the ship having "40%" CR. This extends to running a simulation, meaning a ship will not risk malfunctions if the bar is in the white section of 40% or have them if it's in the yellow section. The same, incidentally, occurs at 20% CR being both yellow and red simultaneously.

Fortunately I've only noticed this issue on the Refit screen, not the fleet screen (though I'll admit I don't try to fly low CR ships if I can avoid it), but it is still very confusing insofar as what CR value ships start risking malfunctions.
Logged

Histidine

  • Admiral
  • *****
  • Posts: 4981
    • View Profile
    • GitHub profile
Re: [0.96a-RC10] Confusing Combat Readiness information in Refit screen
« Reply #1 on: December 13, 2023, 06:29:34 PM »

This is just an issue of rounding the displayed CR percentage to the nearest integer (and converting the numerical malfunction risk to a text description), isn't it?

Best fix I can think of for the narrow case of the refit screen is to also round the player-set CR to integers.
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 25148
    • View Profile
Re: [0.96a-RC10] Confusing Combat Readiness information in Refit screen
« Reply #2 on: December 13, 2023, 08:09:32 PM »

Dug around here and there's actually a floating point issue there - at 40% CR, the ship ends up spawning at something like 0.399999998 CR, so it technically has a non-zero malfunction chance. Fixed that up.

This is just an issue of rounding the displayed CR percentage to the nearest integer (and converting the numerical malfunction risk to a text description), isn't it?

Also this specifically in the refit screen case, yeah!
Logged