Thanks for the release! Editing descriptions & images always adds more flavor to campaigns
I played around with it a bit this morning and have a few minor issues to report.
Running 0.95.1a-RC6 on 64-bit Windows with JRE 1.8.0_271-b09. No other mods except as mentioned in repro steps.
Issue 1: Editor buttons disappear on dialogue refresh.
Steps to reproduce:
- Interact with a planet or station you can edit the description of.
- Select dialogue option 2 ("Take a shuttle down to visit a dockside bar") or 5 ("Consider your military options").
- Return to the main dialogue (e.g. via the ESC key).
Expected: Editor buttons present and interactable underneath the colony image.
Observed: Editor buttons are not present.
Notes: mktGoBack not triggering the right rules?
Issue 2: Deleting description does not restore original description for entities with pre-existing custom descriptions.
Steps to reproduce:
- Either install Nexerelin or set illent_allow_change_on_NPC_market=true.
- If using Nexerelin, own a planet or station with a pre-existing custom description (a "custom planet"), such as the Port Tse Franchise Station.
- Modify the custom planet's description.
- Delete the custom planet's description.
Expected: The custom planet's description is restored to its original state.
Observed: The custom planet's description is replaced with the default description. For stations, this results in no tooltip being rendered on mouseover in the campaign layer.
Notes: Suggest storing entity's original description ID in TextDataEntry and having TextHandler reset to that ID instead of always to null. Could also be WAI with some extra UX guardrails or more comprehensive edit history traversal.
Issue 3: Pressing the tab key while editing text puts the UI in a bad-but-recoverable state.
Steps to reproduce:
- Open a TextChangerPanel by interacting with a planet and pressing the "desc." button.
- Click on a text entry element.
- Press the tab key.
Expected: Either nothing happens (like the comm directory or sub-dialogs like the bar) or the map opens (like the main dialog or the trade screen).
Observed: The trade screen background is visible (planet zoomed-in on right edge of screen). Main campaign UI (clock, tripad, minimap) visible in foreground. Mousing over where dialog options would be plays sounds and clicking on them plays an interaction sound but nothing happens. Keyboard input is preferentially consumed by the campaign UI (e.g. skills on hotbar can be activated). Spacebar closes all dialogs. Pressing tab again opens the map and exiting the map returns to the description editing panel.
Notes: ??
Issue 4: Mouseover descriptions do not support multiline text.
Steps to reproduce:
- Create and apply a description where text1 contains a double-newline by having a blank entry between two non-empty entries, such as "asdf\n\njkl;".
- Mouse over the planet/station/etc. in the main campaign layer.
Expected: Tooltip shows two lines of text.
Observed: Tooltip only renders the first line of text (e.g. just the "asdf" from above).
Notes: Expect this is a core tooltip limitation.