Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Jackie]

A post made me investigate this issue: https://fractalsoftworks.com/forum/index.php?topic=22670.msg367257#msg367257

I had assumed the bonus was hardcoded to only ECCM Package, but this doesn't seem to be the case. ECCM Package does not reduce weapon range penalties from losing Electronic Warfare!

ElectronicWarfareScript seems to have currPenalty redefined again that ignores the ELECTRONIC_WARFARE_PENALTY_MULT!

Code

float currPenalty = penalty * member.getShip().getMutableStats().getDynamic().getValue(Stats.ELECTRONIC_WARFARE_PENALTY_MULT);
currPenalty = member.getShip().getMutableStats().getDynamic().getValue(Stats.ELECTRONIC_WARFARE_PENALTY_MOD, penalty);

I was able to fix this issue for the ECCM Package by replacing:

Code

stats.getDynamic().getStat(Stats.ELECTRONIC_WARFARE_PENALTY_MULT).modifyMult(id, EW_PENALTY_MULT);

with

Code

stats.getDynamic().getMod(Stats.ELECTRONIC_WARFARE_PENALTY_MOD).modifyMult(id, EW_PENALTY_MULT);

[Alex]

Thank you for the report! Fixed.

(By changing that second currPenalty = ... line in the script to:
currPenalty = member.getShip().getMutableStats().getDynamic().getValue(Stats.ELECTRONIC_WARFARE_PENALTY_MOD, currPenalty)