Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: Values not loading  (Read 415 times)

Yunru

  • Admiral
  • *****
  • Posts: 1560
    • View Profile
Values not loading
« on: March 06, 2022, 11:53:45 AM »

I'm hoping this is a sleepy brain moment on my part. Here's the logging reporting what values get loaded:
Code
113832 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - Yunru - Commencing hullmod value checks:
113832 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - ACE_MULT: 0.75
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - HAM_MIN: 100.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - HAM_MAX: 10.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - OBC: 50.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - PD_INC: 50.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - PD_RDC: 10.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RAM_INC: 50.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RAM_DEC: 30.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RAM_TD: 0.5
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RAM_TT: 88.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RP_INC: 25.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RLPC_SPD: 50.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RLPC_ENGAGE: 50.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RLPC_REFIT: 30.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - PDW_ROF: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - PDW_FD: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - PDW_MD: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - PDW_BDSM_MAN: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - PDW_BDSM_RNG: 0.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - DMG_RNG_RATIO: 1.5
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - BS_RNG_REDUCTION: 25.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - BS_BOOST_FRIGATE: 0.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - BS_BOOST_DESTROYER: 0.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - BS_BOOST_CRUISER: 0.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - BS_BOOST_CAPITAL: 0.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - BS_BDSM_RNG: 0.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - SVC_TIMID: 0.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - SVC_CAUTIOUS: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - SVC_STEADY: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - SVC_AGGRESSIVE: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - SVC_RECKLESS: 0.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - ARR_BOOST_ALPHA: 25.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - ARR_BOOST_BETA: 15.0
113835 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - ARR_BOOST_GAMMA: 5.0
113832 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - AIECM_ALPHA: 5.0
113832 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - AIECM_BETA: 2.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - AIECM_GAMMA: 1.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - DST_SPD: 100.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - DST_REACH: 60.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - DST_DMG: 15.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - AMR_ALPHA: 100.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - AMR_BETA: 50.0
113833 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - AMR_GAMMA: 25.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - QS_ALPHA: 50.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - QS_BETA: 25.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - QS_GAMMA: 10.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RFN_A: 10.0
113834 [Thread-3] INFO  data.plugin.yunruSettingsLoad  - RFN_B: 50.0

Here's the file it's loading from:
Code
{
    ###########
    # General #
    ###########
   
    # How much Aegis Collision Emitters reduces HE damage
    "aceMult": 0.75,
   
    # HAM
    "HAM": {
        "minArmourFraction": 100, # A percentage modifier, so at 100 a 5% min armour becomes a 10% min armour.
        "maxDamageReduction": 10, # Also a percentage modifier.
    },
   
    # Ordinance Bay Conversion
    "ordinanceBayAmmo": 50, # Percentage increase per bay removed
   
    # PD Targeting Focus
    "PDT": {
        "PDInc": 50, # Percentage increase to PD weapon range
        "NonPDReduction": 10, # Percentage reduction to other weapons
    },
   
    # Ramburn Engines
    "ramburn": {
        "charge": 50, # Max speed and acceleration percentage increase
        "lumber": 30, # Max turn and turn acceleration percentage decrease
        "movie NOS": 88, # Threshold for BDSM time dialation
        "effect": 0.5, # Percentage increase in time dialation for each su above threshold
    },
   
    # Refined Propellant percentage increase
    "rpSpeed": 25,
   
    # Retuned LPCs
    "RLPC": {
        "speed": 50, # Flat increase to Max, Accel, and Decel
        "range": 50, # Percentage increase to engangement range
        "refit": 30, # Percentage increase to refit times
    },
   
    # Escort Wings
    "PDW": {
        "firerate": 10, # Percentage increase to energy and ballistic ROF
        "fighterhate": 0, # Percentage increase to damage dealt to fighters
        "missilehate": 0, # Percentage increase to damage dealt to missiles
        "BDSM range": 10, # Percentage increase to energy and ballistic range when S-Modded with BDSM enabled
        "BDSM manueverability": 10, # Percentage increase to manueverability when S-Modded with BDSM enabled
    },
   
    ###########################
    # Range:Damage converters #
    ###########################
   
    # How much damage is equivalent to 1 range
    "globalDamagePerRange": 1.5,
   
    # How much percentage range Beam Shear removes
    "beamShearReduction": 25,
    # Extra Beam Shear damage % based on hull size
    "beamShearBoost": {
        "frigate": 0,
        "destroyer": 0,
        "cruiser": 0,
        "capital": 0,
    },
    # How much percentage range Beam Shear removes when S-Modded with BDSM enabled
    "beamShearBDSM": 20,
   
    # Percentage range alteration based on captain personality
    "silvervaleConversion": {
        "timid": 50,
        "cautious": 25,
        "steady": 0,
        "aggressive": -25,
        "reckless": -50,
    },
   
    ##########################
    # Integrated AI Hullmods #
    ##########################
   
    # Advanced Redlining Regulations: Piraty speed increase
    "Arr": {
        "alpha": 25,
        "beta": 15,
        "gamma": 5,
    },
   
    # ECM Core percentage bonus
    "AIECM": {
        "alpha": 5,
        "beta": 2,
        "gamma": 1,
    },
   
    # Dynamic Shield Tuning modifiers, must be multiples of 3. Reach must be a multiple of 6.
    "DST": {
        "speedPercent": 100,
        "reachFlat": 60,
        "damagePercent": 15,
    },
   
    # Automated Missile Racks, percentage increase to RoF.
    "AMR": {
        "alpha": 100,
        "beta": 50,
        "gamma": 25,
    },
   
    # Quickstart Protocols, percentage reductions
    "QSP": {
        "alpha": 50,
        "beta": 25,
        "gamma": 10    ,   
    },
   
    # Remote Fighter Network
    "RFN": {
        "range": 50, # Percentage increase to operations range, acceleration, deceleration, and speed
        "damage": 10, # Percentage increase to damage dealt.
    }
}

And here's the code doing the loading (interestingly, all the missing values are at the end):
Code
private static void load(String filePath) throws IOException, JSONException {
            JSONObject json = Global.getSettings().loadJSON(filePath);

            JSONObject arrgh = json.getJSONObject("Arr");
            ARR_BOOST_ALPHA = (float) arrgh.getDouble("alpha");
            ARR_BOOST_BETA = (float) arrgh.getDouble("beta");
            ARR_BOOST_GAMMA = (float) arrgh.getDouble("gamma");

            ACE_MULT = (float) json.getDouble("aceMult");

            JSONObject aiecm = json.getJSONObject("AIECM");
            AIECM_ALPHA = (float) aiecm.getDouble("alpha");
            AIECM_BETA = (float) aiecm.getDouble("beta");
            AIECM_GAMMA = (float) aiecm.getDouble("gamma");

            JSONObject dst = json.getJSONObject("DST");
            DST_SPD = (float) dst.getDouble("speedPercent");
            DST_REACH = (float) dst.getDouble("reachFlat");
            DST_DMG = (float) dst.getDouble("damagePercent");

            JSONObject amr = json.getJSONObject("AMR");
            AMR_ALPHA = (float) amr.getDouble("alpha");
            AMR_BETA = (float) amr.getDouble("beta");
            AMR_GAMMA = (float) amr.getDouble("gamma");

            JSONObject ham = json.getJSONObject("HAM");
            HAM_MAX = (float) ham.getDouble("maxDamageReduction");
            HAM_MIN = (float) ham.getDouble("minArmourFraction");

            OBC = (float) json.getDouble("ordinanceBayAmmo");

            JSONObject pdf = json.getJSONObject("PDT");
            PD_INC = (float) pdf.getDouble("PDInc");
            PD_RDC = (float) pdf.getDouble("NonPDReduction");

            JSONObject qsp = json.getJSONObject("QSP");
            QS_ALPHA = (float) qsp.getDouble("alpha");
            QS_BETA = (float) qsp.getDouble("beta");
            QS_GAMMA = (float) qsp.getDouble("gamma");

            JSONObject ram = json.getJSONObject("ramburn");
            RAM_DEC = (float) ram.getDouble("lumber");
            RAM_INC = (float) ram.getDouble("charge");
            RAM_TD = (float) ram.getDouble("effect");
            RAM_TT = (float) ram.getDouble("movie NOS");

            RP_INC = (float) json.getDouble("rpSpeed");

            JSONObject rfn = json.getJSONObject("RFN");
            RFN_A = (float) rfn.getDouble("damage");
            RFN_B = (float) rfn.getDouble("range");

            JSONObject rlpc = json.getJSONObject("RLPC");
            RLPC_SPD = (float) rlpc.getDouble("speed");
            RLPC_ENGAGE = (float) rlpc.getDouble("range");
            RLPC_REFIT = (float) rlpc.getDouble("refit");

            DMG_RNG_RATIO = (float) json.getDouble("globalDamagePerRange");

            BS_RNG_REDUCTION = (float) json.getDouble("beamShearReduction");
            JSONObject bsBoost = json.getJSONObject("beamShear");
            BS_BOOST_FRIGATE = (float) bsBoost.getDouble("frigate");
            BS_BOOST_DESTROYER = (float) bsBoost.getDouble("destroyer");
            BS_BOOST_CRUISER = (float) bsBoost.getDouble("cruiser");
            BS_BOOST_CAPITAL = (float) bsBoost.getDouble("capital");
            BS_BDSM_RNG = (float) json.getDouble("beamShearBDSM");

            JSONObject svConversion = json.getJSONObject("silvervaleConversion");
            SVC_TIMID = (float) svConversion.getDouble("timid");
            SVC_CAUTIOUS = (float) svConversion.getDouble("cautious");
            SVC_STEADY = (float) svConversion.getDouble("steady");
            SVC_AGGRESSIVE = (float) svConversion.getDouble("aggressive");
            SVC_RECKLESS = (float) svConversion.getDouble("reckless");

            JSONObject pdw = json.getJSONObject("PDW");
            PDW_FD = (float) pdw.getDouble("fighterhate");
            PDW_MD = (float) pdw.getDouble("missilehate");
            PDW_ROF = (float) pdw.getDouble("firerate");
            PDW_BDSM_RNG = (float) pdw.getDouble("BDSM range");
            PDW_BDSM_MAN = (float) pdw.getDouble("BDSM manueverability");

Yunru

  • Admiral
  • *****
  • Posts: 1560
    • View Profile
Re: Values not loading
« Reply #1 on: March 06, 2022, 01:00:23 PM »

Sutopia pointed it out to me, it's this line:
JSONObject bsBoost = json.getJSONObject("beamShear");

Which doesn't exist (it's "beamShearBoost").