Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24); New blog post: Simulator Enhancements (03/13/24)

Author Topic: Game Crash on Market close (original issue fixed, now causing a different crash)  (Read 482 times)

omegasrevenge

  • Ensign
  • *
  • Posts: 8
    • View Profile

Hello, hope you guys can help me out.
Getting a crash every single time I interact with any market and then close the window, either by pressing escape or clicking on Leave.
I would even be happy with a short term solution, where I can just type in a line of code to delete or respawn a bunch of things or whatever just to get rid of this bug for now.
Obviously what's going on is that something not thread safe is happening, some Array is being read and written in at the same time or something.

Starsector version: 0.95a-RC15

Error Message:
Code
137432 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.util.ConcurrentModificationException
java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
at java.util.ArrayList$Itr.next(Unknown Source)
at stelnet.board.storage.StorageListener.updateIntelList(StorageListener.java:51)
at stelnet.board.storage.StorageListener.reportPlayerClosedMarket(StorageListener.java:38)
at com.fs.starfarer.api.campaign.listeners.ListenerUtil.reportPlayerClosedMarket(ListenerUtil.java:170)
at com.fs.starfarer.campaign.CampaignEngine.reportPlayerClosedMarket(Unknown Source)
at com.fs.starfarer.campaign.CampaignState.dialogDismissed(Unknown Source)
at com.fs.starfarer.ui.Oo0O.dismiss(Unknown Source)
at com.fs.starfarer.ui.newui.for.dismiss(Unknown Source)
at com.fs.starfarer.ui.newui.Stringsuper.advanceImpl(Unknown Source)
at com.fs.starfarer.ui.o00O.advance(Unknown Source)
at com.fs.starfarer.ui.v.advanceImpl(Unknown Source)
at com.fs.starfarer.ui.o00O.advance(Unknown Source)
at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
at com.fs.state.AppDriver.begin(Unknown Source)
at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

Pastebin crashes when I try to upload the Error Log, so I uploaded it to Github instead.

Error Logs: https://github.com/omegasrevenge/StarsectorErrors

Raw Error Log text:
https://raw.githubusercontent.com/omegasrevenge/StarsectorErrors/main/starsector.log
https://raw.githubusercontent.com/omegasrevenge/StarsectorErrors/main/starsector.log.1
https://raw.githubusercontent.com/omegasrevenge/StarsectorErrors/main/starsector.log.2
https://raw.githubusercontent.com/omegasrevenge/StarsectorErrors/main/starsector.log.3

Mods:
Spoiler
Quote
{"enabledMods": [
  "$$$_lightshow",
  "$$$_trailermoments",
  "Adjusted Sector",
  "raccoonarms",
  "beyondthesector",
  "CaptainsLog",
  "clearCommands",
  "chatter",
  "lw_console",
  "DetailedCombatResults",
  "diableavionics",
  "dronelib",
  "dynamictariffs",
  "fast_engine_rendering",
  "fleethistory",
  "gflportraitpack",
  "gflportraitpack2",
  "HMI",
  "hostileIntercept",
  "kadur_remnant",
  "lw_lazylib",
  "logisticsNotifications",
  "MagicLib",
  "Mayasuran Navy",
  "nexerelin",
  "ORA",
  "PulseIndustry",
  "rotcesrats",
  "tahlan_scalartech",
  "SCY",
  "Seafood",
  "speedUp",
  "stelnet",
  "StopGapMeasures3",
  "superweapons",
  "tahlan",
  "star_federation",
  "transfer_all_items",
  "UNSC",
  "US",
  "unpackblueprints",
  "URW",
  "va11portraits",
  "vic",
  "vayrashippack",
  "whichmod",
  "XhanEmpire",
  "yunru_midline_expansion",
  "yunru_pirate_collection",
  "yunrucore",
  "audio_plus",
  "shaderLib",
  "ShipCatalogVariantEditor"
]}
[close]
« Last Edit: December 22, 2021, 01:07:25 PM by omegasrevenge »
Logged

Histidine

  • Admiral
  • *****
  • Posts: 4661
    • View Profile
    • GitHub profile
Re: Game Crash when closing window of any market
« Reply #1 on: December 22, 2021, 06:29:37 AM »

Logged

omegasrevenge

  • Ensign
  • *
  • Posts: 8
    • View Profile
Re: Game Crash when closing window of any market
« Reply #2 on: December 22, 2021, 12:39:29 PM »

See here

You are a god. Let me go try it out immediately.
Logged

omegasrevenge

  • Ensign
  • *
  • Posts: 8
    • View Profile
Re: Game Crash when closing window of any market
« Reply #3 on: December 22, 2021, 12:53:29 PM »

It is fixed. Thank you.
Logged

omegasrevenge

  • Ensign
  • *
  • Posts: 8
    • View Profile
Re: Game Crash when closing window of any market
« Reply #4 on: December 22, 2021, 01:06:22 PM »

See here

When I now try to open the Commodities intel tab the game hard crashes. I tried to fix it by not loading the stelnet mod, loading the save, saving, and then restarting with stelnet in the new savegame, but when I try to load the save without stelnet enabled it throws an error that the save is incompatible.
What do?

Incompatible Error:
Spoiler
[close]
« Last Edit: December 22, 2021, 01:15:59 PM by omegasrevenge »
Logged

Jaghaimo

  • Admiral
  • *****
  • Posts: 661
    • View Profile

The way to uninstall the mod is via stelnet.json setting - uninstallMod set to true. Do that, open the game, load your save and then close. Not you should not see any Stelnet content. Once verified, close the game and disable the mod.

If you need more help, please upload (or paste content of) stelnet.log (same location as starsector.log).
Logged