Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24); New blog post: Simulator Enhancements (03/13/24)

Pages: 1 ... 5 6 [7] 8 9 ... 20

Author Topic: [0.97a] Progressive S-Mods (0.11.3) — gain XP for ships, spend it on S-mods  (Read 156982 times)

korqi

  • Ensign
  • *
  • Posts: 17
    • View Profile

is this mod could conflict with Starship legends ? thank you for your work !

It should be compatible with the old (pre 2.0) version of Starship Legends, from experience. I'm not sure about the new version, sorry.

Hi, thank you for your mod, is it possible to disable all parts of this mod and only retain the part which allows you to increases number of max hullmods using story points? Some parts of this mod is really  appealing to me but using xp to build in hullmods is not so much attractive, sorry :( 

I have attached a jar file that removes the part of code that prevents building in hull mods with story points. Replace the file in Progressive S-Mods/jars with the one attached.

You can also go to progsmod_settings.json and change all of the entries in "baseExtraSModXPCost" to 0 to avoid having to pay XP to increase ships' build-in limit.

Thank you so much, it worked!
Logged

mkire

  • Commander
  • ***
  • Posts: 100
    • View Profile

would it be possible to add XP for civilian ships gained from trade or nex's mining feature? i'm playing a mining/trade run and i'd like to be able to build stuff in. I understand completely if the answer is 'no, it's not possible,' or 'no, i don't want to spend the time to do that'

Thanks for the mod, having lots of fun with it
Logged

Bradley_

  • Ensign
  • *
  • Posts: 20
    • View Profile

Civilian ships should get XP from trading. Also i whish there was more integration with Starship Legends.
Logged

Heukaryote975

  • Ensign
  • *
  • Posts: 5
    • View Profile

there seems to be some kind of weird situation, where sometime far in a save, the XP value of ships (the entire fleet) just gets stuck in 0 and cannot increase the XP from 0 no matter how many battles.



looking into the save data, they seem to be stuck in an NaN value.



i only noticed this fairly recently though.
saving the NaN value as a number (i.e 500 or whatever) seems to "unstick" the XP of a ship though
went from 0(nan), edited save file xp value to 500, loaded the save, and now it can climb to 600+ after a quick battle.



but yeah, weird thing is. It happens to the entire fleet at once
so something (probably) gets *** up at the moment the mod adds XP to ships after battle which is why it includes the civilian ships as well.


WHAT SHIP IS THIS. I MUST KNOW.

I see you put to work both of the mods "Starship legends" and "progressive s-mdos" would you please tell me which version of both are you using ? in my game i only have xp trackers don't have the traits "Well known" I'm sad... :(
Logged

IGdood

  • Commander
  • ***
  • Posts: 186
    • View Profile

I guess this is more of a mod to mod issue, but when trying to use Progressive S mods it'll crash when it hovers over XLU's Overhaul Hullmod.  Doesn't crash when I mouse over an already-installed hullmod or if I'm building it in with ordnance points


Spoiler
4634896 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.hullmods.xlu_weapons_overhaul.addPostDescriptionSection(xlu_weapons_overhaul.java:104)
   at progsmod.data.campaign.rulecmd.ui.PanelCreator$1.createTooltip(PanelCreator.java:153)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable$13.createImpl(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable.create(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable.beforeShown(Unknown Source)
   at com.fs.starfarer.ui.Q.showTooltip(Unknown Source)
   at com.fs.starfarer.ui.ooOo.super.new(Unknown Source)
   at com.fs.starfarer.ui.ooOo.processInput(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.e$Oo.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.e.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.int.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.E.I.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.N.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.super.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.N.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.o0Oo.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.processInput(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Thread.java:748)

[close]
« Last Edit: May 11, 2022, 03:53:56 PM by IGdood »
Logged

float

  • Commander
  • ***
  • Posts: 241
    • View Profile

Re: xp from trade

I could consider this but really that’s the whole point of the post-battle XP for civilian and undeployed ships. Didn’t Alex say something to the effect of aspects of the game being designed to funnel the player toward combat? I’m not sure what a pacifist playthrough would look like or entail, but regardless this has always been a combat-oriented mod.

Re: xp from mining

Not really considering this as it would be a cross-mod implementation which would mean more maintenance should the other mod get updated.

Re: integration with starship legends (whatever that means)

See above.

I guess this is more of a mod to mod issue, but when trying to use Progressive S mods it'll crash when it hovers over XLU's Overhaul Hullmod.  Doesn't crash when I mouse over an already-installed hullmod or if I'm building it in with ordnance points


Spoiler
4634896 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.hullmods.xlu_weapons_overhaul.addPostDescriptionSection(xlu_weapons_overhaul.java:104)
   at progsmod.data.campaign.rulecmd.ui.PanelCreator$1.createTooltip(PanelCreator.java:153)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable$13.createImpl(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable.create(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable.beforeShown(Unknown Source)
   at com.fs.starfarer.ui.Q.showTooltip(Unknown Source)
   at com.fs.starfarer.ui.ooOo.super.new(Unknown Source)
   at com.fs.starfarer.ui.ooOo.processInput(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.e$Oo.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.e.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.int.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.E.I.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.N.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.super.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.N.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.o0Oo.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.processInput(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Thread.java:748)

[close]

Looks like the NPE is in xlu_weapons_overhaul.java. Latest version of XLU doesn’t even have that method in xlu_weapons_overhaul, which means it would just use the empty version in BaseHullMod. The file is also only 94 lines long while your error appears at line 104, so I’m wondering if your XLU is out of date or the provided source files for that mod don’t match the compiled jar.
Logged

IGdood

  • Commander
  • ***
  • Posts: 186
    • View Profile



I guess this is more of a mod to mod issue, but when trying to use Progressive S mods it'll crash when it hovers over XLU's Overhaul Hullmod.  Doesn't crash when I mouse over an already-installed hullmod or if I'm building it in with ordnance points


Spoiler
4634896 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.hullmods.xlu_weapons_overhaul.addPostDescriptionSection(xlu_weapons_overhaul.java:104)
   at progsmod.data.campaign.rulecmd.ui.PanelCreator$1.createTooltip(PanelCreator.java:153)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable$13.createImpl(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable.create(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2Expandable.beforeShown(Unknown Source)
   at com.fs.starfarer.ui.Q.showTooltip(Unknown Source)
   at com.fs.starfarer.ui.ooOo.super.new(Unknown Source)
   at com.fs.starfarer.ui.ooOo.processInput(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.impl.StandardTooltipV2.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.e$Oo.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.e.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.int.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.E.I.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.N.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.super.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.N.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.newui.o0Oo.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.ui.v.dispatchEventsToChildren(Unknown Source)
   at com.fs.starfarer.ui.v.processInputImpl(Unknown Source)
   at com.fs.starfarer.ui.Q.processInput(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.processInput(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Thread.java:748)

[close]

Looks like the NPE is in xlu_weapons_overhaul.java. Latest version of XLU doesn’t even have that method in xlu_weapons_overhaul, which means it would just use the empty version in BaseHullMod. The file is also only 94 lines long while your error appears at line 104, so I’m wondering if your XLU is out of date or the provided source files for that mod don’t match the compiled jar.

Interesting, it looks like this error is new after the most recent XLU update
Logged

Protonus

  • Captain
  • ****
  • Posts: 444
  • AAAAAAAAAAAA
    • View Profile

Man, I'll look into this.

Edit: Found it, the hullmod is still attempting to look for the ship in the Progress XP window when there isn't. I'll make a fix.
« Last Edit: May 11, 2022, 07:52:16 PM by Protonus »
Logged

The cookies are a weird one, okay.

float

  • Commander
  • ***
  • Posts: 241
    • View Profile

Man, I'll look into this.

Edit: Found it, the hullmod is still attempting to look for the ship in the Progress XP window when there isn't. I'll make a fix.

Oh... based on this I think I have an idea what's going on. I'm passing null as the ship in the addPostDescriptionSection call and setting isForModSpec to true, which I guess is the flag for "generic mod description not attached to a particular ship."

I suppose I shouldn't be doing that since the build-in screen does, in fact, have knowledge of a particular ship. I'll make some changes on my end.
And on further inspection I realize why I did that. There is no ShipAPI, only a FleetMemberAPI. It turns out the refit screen actually has access to a ShipAPI (presumably by instantiating one from a fleet member using non-exposed methods), but the modding API unfortunately isn't comprehensive enough to mimic this. So there's really no way I can pass in a ship to that method.
« Last Edit: May 11, 2022, 08:27:34 PM by this_is_a_username »
Logged

TheTangy

  • Ensign
  • *
  • Posts: 14
    • View Profile

...  NPC fleets can have built-in hull mods, so they aren't really as exceptional as, say, being able to disengage freely or "making improvements" to colonies.

Does this mean that NPC fleets already have S-Mods or that the Mod gives them S-mods?

I can't see any but the standard built-in mods (ie, no extra S-Mods) in NPC fleets when I click on a ship and click the 'Information" hotkey (i), so I don't think NPC fleets have them, do they?

Logged

Corelious

  • Lieutenant
  • **
  • Posts: 63
    • View Profile

there seems to be some kind of weird situation, where sometime far in a save, the XP value of ships (the entire fleet) just gets stuck in 0 and cannot increase the XP from 0 no matter how many battles.



looking into the save data, they seem to be stuck in an NaN value.



i only noticed this fairly recently though.
saving the NaN value as a number (i.e 500 or whatever) seems to "unstick" the XP of a ship though
went from 0(nan), edited save file xp value to 500, loaded the save, and now it can climb to 600+ after a quick battle.



but yeah, weird thing is. It happens to the entire fleet at once
so something (probably) gets *** up at the moment the mod adds XP to ships after battle which is why it includes the civilian ships as well.


WHAT SHIP IS THIS. I MUST KNOW.

I see you put to work both of the mods "Starship legends" and "progressive s-mdos" would you please tell me which version of both are you using ? in my game i only have xp trackers don't have the traits "Well known" I'm sad... :(

Uh what mod is this ship from?
Logged

float

  • Commander
  • ***
  • Posts: 241
    • View Profile

...  NPC fleets can have built-in hull mods, so they aren't really as exceptional as, say, being able to disengage freely or "making improvements" to colonies.

Does this mean that NPC fleets already have S-Mods or that the Mod gives them S-mods?

I can't see any but the standard built-in mods (ie, no extra S-Mods) in NPC fleets when I click on a ship and click the 'Information" hotkey (i), so I don't think NPC fleets have them, do they?

This mod doesn't affect s-mods in NPC fleets in any way. The way s-mods are handled in NPC fleets is different from how the player obtains them. I believe fleets can be explicitly set to have a certain "average" number of s-mods. For vanilla games, most NPC fleets don't have s-mods, expect for mercenary fleets from the main story and as part of bounties. Some mods do add s-modded fleets as routine patrols.
Logged

TheHZDev

  • Lieutenant
  • **
  • Posts: 60
    • View Profile

Sir, may I ask for your permission to translate your mod into Chinese and update it to the Chinese Starsector Forum(https://fossic.org) with your author infomation?
Logged

float

  • Commander
  • ***
  • Posts: 241
    • View Profile

Sir, may I ask for your permission to translate your mod into Chinese and update it to the Chinese Starsector Forum(https://fossic.org) with your author infomation?

Yes, that’s fine. Keep in mind though that I haven’t made any effort to externalize the text used by this mod, so you’d have to manually go through the source files. If you’d like me to extract the strings, I can do that, it just might take a while before I get to it.
Logged

TheHZDev

  • Lieutenant
  • **
  • Posts: 60
    • View Profile

Sir, may I ask for your permission to translate your mod into Chinese and update it to the Chinese Starsector Forum(https://fossic.org) with your author infomation?

Yes, that’s fine. Keep in mind though that I haven’t made any effort to externalize the text used by this mod, so you’d have to manually go through the source files. If you’d like me to extract the strings, I can do that, it just might take a while before I get to it.

I have posted your translated mod with author infomation in https://www.fossic.org/forum.php?mod=viewthread&tid=5190 .
Thank you very much!
Logged
Pages: 1 ... 5 6 [7] 8 9 ... 20