Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Vayra]

If you scuttle a ship with weapons that have the SYSTEM hint and the no_drop and no_drop_salvage tags in normal weapon slots, the weapons still show up in your inventory, which seems like potentially unintended behavior.

I've heard reports that you can also get them from some form of salvage but I haven't confirmed those myself, might be worth checking if you do decide to change this though. I suppose this is technically a (modded) report since there aren't any ships that do this in vanilla.

[Alex]

Hmm - you would presumably also be able to get at these weapons by uninstalling them in the refit screen, no? The problem seems to be rooted in those weapons ending up in those slots in the first place, unless I'm missing something.

[Vayra]

Hmm - you would presumably also be able to get at these weapons by uninstalling them in the refit screen, no? The problem seems to be rooted in those weapons ending up in those slots in the first place, unless I'm missing something.

Oh, true - I remove them from the inventory immediately with a hullmod script in that case. I'll find another way around it then, thanks for your time!

[Tartiflette]

You have the same issue with buit-in weapons if they are assigned in the variant instead of the hull file.

I have a ship with a hullmod allowing to cycle between 3 "built-in" loadouts in refit, and those built-in, SYSTEM, no_drop, no_drop_salvage weapons still show up in post battle loot.

Speaking of tags, no_drop_salvage, no_sell weapons can still show up in research stations salvage, which is inconvenient when making bosses with fancy weapons that should only be available by defeating them and looting their corpse.

[Alex]

I have a ship with a hullmod allowing to cycle between 3 "built-in" loadouts in refit, and those built-in, SYSTEM, no_drop, no_drop_salvage weapons still show up in post battle loot.

Hmm - that *should* be fixed. Though, actually... I'm fairly sure the Tags.NO_DROP check for not dropping weapons is in the current release, so this is kind of confusing. Could you see if that's used in the latest version of FleetEncounterContext? The SYSTEM hint doesn't factor in here iirc, it's just the no_drop tag.

Speaking of tags, no_drop_salvage, no_sell weapons can still show up in research stations salvage, which is inconvenient when making bosses with fancy weapons that should only be available by defeating them and looting their corpse.

That should be fixed for the next release. Or, rather - it'll need a "no_drop" tag. There's also a new "restricted" tag that's more suitable for things like this which iirc also makes them not show up in mission refit.

[Tartiflette]

Mmmh, there seems to be a if (spec.hasTag(Tags.NO_DROP)) continue; in FleetEncouterContext in the current version yet the weapon drops. Small correction, the weapons I'm talking about are in a built-in slot (to prevent players from uninstalling them), so they shouldn't drop at all.

Now thinking about it, in the second case if I add a SYSTEM hint to the no_drop_salvage and no_sell of the boss weapons, they should drop in post battle salvage, but no longer appear in research stations I think.

[Alex]

Yeah, they really shouldn't, hmm. I do remember making some fixes here, so it's possible that this will be resolved. If you're able to cook up a minimal test case, I'll be happy to give it a try to confirm the fix.

[Tartiflette]

Alright, I'll try to do that.