Evening Jaghaimo, this is an interesting mod you have here and I got some feedback for you.
- Subjectively? I think it is odd they go in *every* non Pirate market, by default.
More objectively?
- Any market that has a military and a custom sub-market already added? Will "overflow" the UI and it looks quite bad.
- I would recommend checking for sub-market count before adding your thing.
- I like that by default you are not adding them to Pirate markets, this is good! But what is not good? Is that you do not allow blocking it for mod Pirates or other factions that might not want them added for lore or mechanic reasons.
- I would recommend adding a merging .csv or json file that allows a modder to make their faction opt-out of your thing being added.
- These being added to some markets, can be an issue for edge case stuff in some mods. Think hidden places, quest stuff etc etc.
- I would recommend adding a merging .csv or json file that allows a modder to make X market of theirs opt-out of your thing being added.
- These being added to some star systems, both hand made and procgen can be an issue for edge case stuff in some mods. Think hidden places, quest stuff etc etc.
- I would recommend adding a .csv or json file that looks at both star system ID (for hand made), and star system tags (for procgen) that allows a modder to opt-out of your thing being added.
Also these lists if done? Should ideally ignore your settings file. Because the cases where a modder would opt-out will always be for very good reasons where it could soft and/or hard break their stuff. Anyways if you could please do all that it would be deeply appreciated by the Modiverse overall