Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[epixinvites]

I really love this mod due to its unique ships and hullmods, but ED seems like he's gone for an unknown amount of time. So, will this mod be updated to 0.95a? Or will it not?

[Ed]

Eventually... if no one else is interested in taking over the mod.

[Chairman Suryasari]

How about the Discord server? Is there no one want to forked your mod or maintaining it until you come back?

Also i hope you are doing well there 

[PlatinumSun]

Eventually... if no one else is interested in taking over the mod.

Say, I plan on learning to program basic Java during the summer, how complicated would simply updating the mod to 0.95 be? I have almost zero programming experience other than a small random text picker program (It asks a question and gives you a random positive or negetive fortune depending on how you asnwered the questions. The Python version had a tally system where it gives you one fortune at the end after adding together the sum of the answers.) I wrote years ago in C#, which I also made again in Python. But if I am going to be honest I can't remember anything of programing them or programming in general. Other than I made heavy use of arrays for them. And both of them (C# and Python) had something wrong that caused a crash which I couldn't figure out what for the life of me.

[ModdedLaharl]

I'd also be quite interested in helping to continue ED Shipyards. I'm already in the process of setting up a jar and teaching myself some slightly more complicated scripting in order to execute what I want to do.

Glancing through the files, there's definitely some things here I'd need to chew on; not least of which being that onHit effects need to be updated for 0.95 for weapons like the Grapeshot; and frankly I can't even pretend to mimic the artstyle.

I'm currently out of state and thus away from my work computer so it'd be a bit if I did do this, but I'd definitely throw my hat in the ring.

[theDragn]

Glancing through the files, there's definitely some things here I'd need to chew on; not least of which being that onHit effects need to be updated for 0.95 for weapons like the Grapeshot; and frankly I can't even pretend to mimic the artstyle.

Updating on hit effects is very easy- you just need to add the ApplyDamageResultAPI argument. For example:
public void onHit(DamagingProjectileAPI projectile, CombatEntityAPI target, Vector2f point, boolean shieldHit, CombatEngineAPI engine) becomes
public void onHit(DamagingProjectileAPI projectile, CombatEntityAPI target, Vector2f point, boolean shieldHit, ApplyDamageResultAPI damageResult, CombatEngineAPI engine)
and that's it.

[Lord Sputnik]

Glancing through the files, there's definitely some things here I'd need to chew on; not least of which being that onHit effects need to be updated for 0.95 for weapons like the Grapeshot; and frankly I can't even pretend to mimic the artstyle.

Updating on hit effects is very easy- you just need to add the ApplyDamageResultAPI argument. For example:
public void onHit(DamagingProjectileAPI projectile, CombatEntityAPI target, Vector2f point, boolean shieldHit, CombatEngineAPI engine) becomes
public void onHit(DamagingProjectileAPI projectile, CombatEntityAPI target, Vector2f point, boolean shieldHit, ApplyDamageResultAPI damageResult, CombatEngineAPI engine)
and that's it.

That totally explains this error when I tried updating it myself to 0.95...

Spoiler

12304987 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.AbstractMethodError: data.scripts.weapons.Magnablast.onHit(Lcom/fs/starfarer/api/combat/DamagingProjectileAPI;Lcom/fs/starfarer/api/combat/CombatEntityAPI;Lorg/lwjgl/util/vector/Vector2f;ZLcom/fs/starfarer/api/combat/listeners/ApplyDamageResultAPI;Lcom/fs/starfarer/api/combat/CombatEngineAPI;)V
java.lang.AbstractMethodError: data.scripts.weapons.Magnablast.onHit(Lcom/fs/starfarer/api/combat/DamagingProjectileAPI;Lcom/fs/starfarer/api/combat/CombatEntityAPI;Lorg/lwjgl/util/vector/Vector2f;ZLcom/fs/starfarer/api/combat/listeners/ApplyDamageResultAPI;Lcom/fs/starfarer/api/combat/CombatEngineAPI;)V
   at com.fs.starfarer.combat.entities.BallisticProjectile.setDidDamage(Unknown Source)
   at com.fs.starfarer.combat.entities.BallisticProjectile.notifyDealtDamage(Unknown Source)
   at com.fs.starfarer.combat.E.oOOO.O0OO.super(Unknown Source)
   at com.fs.starfarer.combat.E.oOOO.o00000(Unknown Source)
   at com.fs.starfarer.combat.E.oOOO.o00000(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.advanceInner(Unknown Source)
   at com.fs.starfarer.combat.CombatEngine.advance(Unknown Source)
   at com.fs.starfarer.combat.CombatState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

[close]

[fattytheking]

Love this mod Ed! Cant wait for it to get updated for 0.95

[bombasticmori]

I enjoyed this mod back in 0.91a so I was considering updating it for 0.95a since the author was asking about it. I have a build for personal use but a few other people said they were going to try updating it so I wanted to check first before I try uploading anything.  I couldn't do like, any long term development on it outside of like, gamebreaking problems though.

[Coldbolt]

{
   "id":"edshipyard",
   "name":"ED Shipyard",
   "author":"Ed",
   "version":"2.1.2",
   "description":"Adds some fun ships, fair and balanced!",
   "gameVersion":"0.95a-RC15",
   "jars":["jars/EDShipyard.jar"],   
   "modPlugin":"data.scripts.ED_modPlugin",
}
try replace it to 0.95a-RC15 under gameVersion it run well and didn't crash when starting up the game but during the game play on battle it will crash so play at your own risk

[bombasticmori]

{
   "id":"edshipyard",
   "name":"ED Shipyard",
   "author":"Ed",
   "version":"2.1.2",
   "description":"Adds some fun ships, fair and balanced!",
   "gameVersion":"0.95a-RC15",
   "jars":["jars/EDShipyard.jar"],   
   "modPlugin":"data.scripts.ED_modPlugin",
}
try replace it to 0.95a-RC15 under gameVersion it run well and didn't crash when starting up the game but during the game play on battle it will crash so play at your own risk

The issue is many of the weapons use special OnHit effects that have to be updated to the modern implementation of those methods.  Its super easy to do, but requires you to recompile the mod's jar file.  Otherwise it'll crash whenever you try to use those weapons.

[AlhazredTheMad]

We must have a savior out there! I need those ED Ships in my life. Anyone done the update and it's just posted somewhere?

[GaryVary]

We must have a savior out there! I need those ED Ships in my life. Anyone done the update and it's just posted somewhere?

I'll be your savior, I've fixed onHit method and now it's compatible with [0.95a]. So far didn't find any other issues.
I hope mod author will not be angry that I ported his mod.

https://github.com/GaryVary/ED-Shipyard/releases/download/1.0.0/ED.Shipyard.zip

If anyone will find other issues, then post exception text and (if possible) reproduction steps, I'll try to fix it (until Sunday, I will not have access to the computer, so I will not be able to start looking at the problems earlier.).

[RoquetheRogue]

We must have a savior out there! I need those ED Ships in my life. Anyone done the update and it's just posted somewhere?

I'll be your savior, I've fixed onHit method and now it's compatible with [0.95a]. So far didn't find any other issues.
I hope mod author will not be angry that I ported his mod.

https://github.com/GaryVary/ED-Shipyard/releases/download/1.0.0/ED.Shipyard.zip

If anyone will find other issues, then post exception text and (if possible) reproduction steps, I'll try to fix it (until Sunday, I will not have access to the computer, so I will not be able to start looking at the problems earlier.).

You did a good job, thanks for the link!

[GaryVary]

Found problem with ED ships systems.
Fix https://github.com/GaryVary/ED-Shipyard/releases/download/1.0.2/ED.Shipyard.zip