Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  
Pages: 1 ... 45 46 [47] 48

Author Topic: [0.9.1a] 'Junk Pirates' 3.5.3 (including ASP & P.A.C.K.)  (Read 525358 times)

Dazs

  • Commander
  • ***
  • Posts: 169
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #690 on: February 08, 2021, 02:58:23 AM »

Sigh, sorry yet another update:

I was able to start a game a play with the new code which is an improvement however after roughly 5-10 minute of gameplay I get the following crash:

911247 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.scripts.campaign.fleets.JunkPiratesExplorerFleetAssignmentAI.findPartyPlan et(JunkPiratesExplorerFleetAssignmentAI.java:285)
   at data.scripts.campaign.fleets.JunkPiratesExplorerFleetAssignmentAI.advance(JunkPiratesExplorerFleetAssignmentAI.java:61)
   at com.fs.starfarer.campaign.BaseCampaignEntity.runScripts(Unknown Source)
   at com.fs.starfarer.campaign.BaseCampaignEntity.advance(Unknown Source)
   at com.fs.starfarer.campaign.fleet.CampaignFleet.advance(Unknown Source)
   at com.fs.starfarer.campaign.BaseLocation.advance(Unknown Source)
   at com.fs.starfarer.campaign.StarSystem.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #691 on: February 08, 2021, 03:27:53 AM »

Hey, please don't worry about this it is unimaginably helpful for the cases I don't get to test!

https://bitbucket.org/mendoncka/my-files/downloads/JunkPirates.jar

Sorry about the trouble; I've added another null check here (which I thought was null-checked, but obviously not in the right place!); download above JAR and replace in JP_RC / jars folder whilst I upload another hotfix version; and hope for the best ...

Thanks again!
« Last Edit: February 08, 2021, 12:17:54 PM by mendonca »
Logged


"I'm doing it, I'm making them purple! No one can stop me!"

Dazs

  • Commander
  • ***
  • Posts: 169
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #692 on: February 08, 2021, 07:18:36 AM »

I've played for over an hour with no crash with the hotfix installed. Haven't come across any explorers but I'm not sure if being neutral/friendly to your factions while playing as HMI effects that.

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #693 on: February 08, 2021, 07:26:32 AM »

I've played for over an hour with no crash with the hotfix installed. Haven't come across any explorers but I'm not sure if being neutral/friendly to your factions while playing as HMI effects that.

That's great, thanks for letting me know.

Your relation will not specifically affect that; basically you get more intel if you are friendly with JP - but no fundamental impact to what the behaviours are.

I'll have to double check when I can that I haven't completely switched them off accidentally, but on balance you'll probably be expecting to run with maybe 3-4 troublemakers mucking around - probably in the core worlds; and 4-5 explorers in the wilds - and the explorers are likely to be anywhere in the sector ... so I guess that's not necessarily unexpected.
Logged


"I'm doing it, I'm making them purple! No one can stop me!"

Dazs

  • Commander
  • ***
  • Posts: 169
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #694 on: February 08, 2021, 08:54:25 AM »

Found another crash. Lost in a  fight with the Starlight Cabal and when I respawned I crashed:

4175472 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.campaign.intel.misc.JunkExplorerDecisionIntel.initTransientData(JunkExplorerDecisionIntel.java:84)
   at data.campaign.intel.misc.JunkExplorerDecisionIntel.createIntelInfo(JunkExplorerDecisionIntel.java:162)
   at com.fs.starfarer.campaign.comms.ooOO.<init>(Unknown Source)
   at com.fs.starfarer.campaign.comms.super.addMessage(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.addMessage(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.IntelManager.addIntel(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.IntelManager.addIntel(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.IntelManager.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #695 on: February 08, 2021, 09:31:35 AM »

Thanks again!

I can sort of see why this might happen; ultimately it seems a fleet which doesn't exist is trying to queue a message up about what it's intentions are.

But not sure exactly why it got to that point, but I guess it did so there is no point in worrying about it!

I'm going to try and stick a null check in again to circumvent what I think is the issue.
Logged


"I'm doing it, I'm making them purple! No one can stop me!"

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #696 on: February 08, 2021, 12:21:59 PM »

https://bitbucket.org/mendoncka/my-files/downloads/JunkPirates.jar

Slight bump; hotfix; more nullchecks. Had a little pass through and tried to pick up potential pitfalls ... Any more issues just let me know and I'll sort it.

EDIT: if it's not clear; this JAR has been rolled into the main download - so only grab JAR file if you downloaded prior to about 8pm GMT February 8th ...
« Last Edit: February 08, 2021, 02:18:34 PM by mendonca »
Logged


"I'm doing it, I'm making them purple! No one can stop me!"

G5

  • Ensign
  • *
  • Posts: 2
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #697 on: February 08, 2021, 10:49:58 PM »

I started a new game with the most up to date version. I had been playing for about 10 minutes when I was flying to Breh'inni (Christchurch is a needy little planet that spams small trade requests, a good place for a new fleet to make a few bucks while waiting for a more lucrative opportunity) when:

java.lang.NullPointerException
   at data.campaign.intel.misc.AspCourierDepartureIntel.initTransientData(AspCourierDepartureIntel.java:118)
   at data.campaign.intel.misc.AspCourierDepartureIntel.createIntelInfo(AspCourierDepartureIntel.java:215)
   at com.fs.starfarer.campaign.comms.ooOO.<init>(Unknown Source)
   at com.fs.starfarer.campaign.comms.super.addMessage(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.addMessage(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.IntelManager.addIntel(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.IntelManager.addIntel(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.IntelManager.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

Installed mods:
Spoiler
  "$$$_lightshow",
  "Adjusted Sector",
  "anotherportraitpack",
  "anvil_industries",
  "capturecrew",
  "chatter",
  "lw_radar",
  "lw_console",
  "istl_dam",
  "DisassembleReassemble",
  "edshipyard",
  "galmart",
  "gates_awakened",
  "hypernet",
  "IndEvo",
  "interestingportraitspack",
  "Imperium",
  "junk_pirates_release",
  "kadur_remnant",
  "lw_lazylib",
  "ArkLeg",
  "luddenhance",
  "MagicLib",
  "dk_mis_09",
  "missingships",
  "more_hullmods",
  "nexerelin",
  "wyv_planetaryShieldAccessControl",
  "sun_ruthless_sector",
  "swp",
  "bonomel_skilledup",
  "StopGapMeasures",
  "tahlan",
  "Terraforming and Station Construction",
  "exalted",
  "star_federation",
  "THI",
  "TORCHSHIPS",
  "underworld",
  "vayrashippack",
  "vesperon",
  "shaderLib"
[close]
Logged

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #698 on: February 09, 2021, 03:55:51 AM »

Thank you for the report!

This is a fun* one! I don't think this will be a mod incompatibility thing, just some strange things happening that shouldn't ... I have this one already protected (or so I thought) by several null checks, but obviously not close enough to the bit that counts ... I'll have a little poke around for similar implementations and see if there is more I can do to cut this kind of thing off.

Thanks again, appreciate it - sorry you have to be my testers and it's a shame these things don't happen to me before I release! but what can you do ...

*not fun
Logged


"I'm doing it, I'm making them purple! No one can stop me!"

Dazs

  • Commander
  • ***
  • Posts: 169
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #699 on: February 11, 2021, 04:42:59 AM »

Been awhile, here is another crash report.

3200609 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.scripts.campaign.fleets.JunkPiratesExplorerFleetAssignmentAI.findPartyPlan et(JunkPiratesExplorerFleetAssignmentAI.java:290)
   at data.scripts.campaign.fleets.JunkPiratesExplorerFleetAssignmentAI.advance(JunkPiratesExplorerFleetAssignmentAI.java:61)
   at com.fs.starfarer.campaign.BaseCampaignEntity.runScripts(Unknown Source)
   at com.fs.starfarer.campaign.BaseCampaignEntity.advance(Unknown Source)
   at com.fs.starfarer.campaign.fleet.CampaignFleet.advance(Unknown Source)
   at com.fs.starfarer.campaign.BaseLocation.advance(Unknown Source)
   at com.fs.starfarer.campaign.StarSystem.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

This is from roughly 10 minutes into a new game. The mods I changed from my last report was I updated Magic lib and installed the new version of The exalted. Not sure if they have anything to do with it but for due diligence I figured I'd mention it.

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #700 on: February 11, 2021, 06:31:00 AM »

Thank you.

I think I got this one; potential null return from something; I posted an update on discord late last night (lots of extra null checking in new code) but I was tired and wanted to run some more extended tests / have another pass through the code prior to 'officially' releasing / publicising it widely.

(grab the Jar from previous link if you fancy it ... should link to a later version which can be slotted in)

Also worth noting these unexpected null returns are in new code which can be turned off by disabling Junk Explorers and ASP Couriers in mendoncaModSettings.ini, but other than general tiredness / crosseyed reviewing of code I'm hopeful the new JAR is more robust and should stop this.
Logged


"I'm doing it, I'm making them purple! No one can stop me!"

Dazs

  • Commander
  • ***
  • Posts: 169
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.2 (including ASP & P.A.C.K.)
« Reply #701 on: February 11, 2021, 01:17:24 PM »

Update: Been playing for over 2 hours with the new JAR and no crashing. Seemed to do the trick, thanks for the quick reply!

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.3 (including ASP & P.A.C.K.)
« Reply #702 on: February 11, 2021, 03:11:05 PM »

Update: Been playing for over 2 hours with the new JAR and no crashing. Seemed to do the trick, thanks for the quick reply!

Awesome. Thanks for letting me know, that makes me feel more comfortable!

Cleared a couple of 1 years - 2 year games my side last night and tonight (various mods including HMI, Nex, Vayra), so that's looking positive at least.

Pushed out the 3.5.3 to version checker and main package updated; fingers / toes etc. crossed!
Logged


"I'm doing it, I'm making them purple! No one can stop me!"

Dazs

  • Commander
  • ***
  • Posts: 169
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.3 (including ASP & P.A.C.K.)
« Reply #703 on: February 12, 2021, 02:18:37 AM »

Here we go again :)

5089112 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.campaign.intel.misc.AspCourierDepartureIntel.getMapLocation(AspCourierDepartureIntel.java:337)
   at com.fs.starfarer.api.impl.campaign.intel.BaseIntelPlugin.getIntelTags(BaseIntelPlugin.java:236)
   at data.campaign.intel.misc.AspCourierDepartureIntel.getIntelTags(AspCourierDepartureIntel.java:295)
   at com.fs.starfarer.campaign.comms.v2.EventsPanel.o00000(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.EventsPanel.ØÖ0000(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.EventsPanel.øÖ0000(Unknown Source)
   at com.fs.starfarer.campaign.comms.v2.EventsPanel.sizeChanged(Unknown Source)
   at com.fs.starfarer.ui.for.setSize(Unknown Source)
   at com.fs.starfarer.campaign.comms.return.this.void(Unknown Source)
   at com.fs.starfarer.campaign.comms.return.sizeChanged(Unknown Source)
   at com.fs.starfarer.ui.for.setSize(Unknown Source)
   at com.fs.starfarer.ui.o00OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.setSize(Unknown Source)
   at com.fs.starfarer.ui.newui.O0oO$7.actionPerformed(Unknown Source)
   at com.fs.starfarer.ui.newnew.buttonPressed(Unknown Source)
   at com.fs.starfarer.ui.I.Ò00000(Unknown Source)
   at com.fs.starfarer.ui.I.processInput(Unknown Source)
   at com.fs.starfarer.ui.O0Oo.o00000(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

Updated mods since last report: Vayra's Sector, Vayra's ship pack, Kadur Remnant

Crash happened while docked at a station and I pressed the "Intel" button
« Last Edit: February 12, 2021, 02:24:26 AM by Dazs »
Logged

mendonca

  • Global Moderator
  • Admiral
  • *****
  • Posts: 1159
    • View Profile
Re: [0.9.1a] 'Junk Pirates' 3.5.3 (including ASP & P.A.C.K.)
« Reply #704 on: February 12, 2021, 03:03:42 AM »

Hey thanks; I'm going to blame Vayra for this one ... seems convenient!

It's trying to look at a market that exists itself (because it's stepped past that null check), but doesn't have a 'primary location'?

Slammed a few more null checks in ... and hotfixed the main download ...

https://bitbucket.org/mendoncka/my-files/downloads/JunkPirates.jar
« Last Edit: February 12, 2021, 03:15:00 AM by mendonca »
Logged


"I'm doing it, I'm making them purple! No one can stop me!"
Pages: 1 ... 45 46 [47] 48