Hey, thanks for the feedback, guys!
The reduction of lasting damage due to fame is not cumulative with the trait earned by safety procedures on level 3 which reduces negative effects of d-mods by 50%.
That means the reduction of lasting damage due to fame gets pretty much useless after gaining some levels. I thnk it should be connected multiplicative so you wuld get around 66% reduction ( 50% + 50%*33%).
What do you think?
I just tested, and it looks like it already works that way. Can you point me to a specific case in which it doesn't? There might be a bug somewhere.
I see that isTraitRelevantForShip checks the trait type against the hull specs (e.g. shield traits only for hulls that have shields) and considers built-in hull mods. Do you think it would be practical to consider other hull mods? At least in vanilla, I don't think there are too many that would affect traits (shield bypass, makeshift shield generator, and converted hanger) in vanilla. What do you think about considering those as well?
Well, you're well informed, aren't you
I've thought about it in the past, but I've always chosen not to consider temporary hullmods when choosing traits because traits are essentially permanent in most cases. However, 1.4 will include a system for gradually removing dmod related traits from restored ships, which could easily be applied to
any irrelevant traits. So, yeah, I'll probably end up doing that at some point, it's just a matter of figuring out how to do it right. Your example with shield bypass (vanilla or not) is definitely a problem I'd want to address.
It seems like the only way for me to remove those two traits and replace them with others (or allow others to be chosen) is to reset the ship's reputation and manually add all its traits back in order. Is that right?
Yes, that's right.
While looking for the code for isTraitRelevantForShip, I noticed that there's a RemoveTrait command slated for version 1.4. Any ETA on it?
Not sure. I wanted to cram a few more things in before releasing, but I'm starting to think I should remove a few incomplete additions and release what's done so far. If you PM me on Discord and promise to report any bugs you find I'll send you the dev build.