Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.95.1a is out! (12/10/21); Blog post: Hyperspace Topography (10/12/22)

Pages: 1 ... 9 10 [11] 12

Author Topic: [0.95.1a] MagicLib v0.45.2 (2023/01/07)  (Read 446560 times)

Tartiflette

  • Admiral
  • *****
  • Posts: 3517
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #150 on: May 01, 2022, 11:10:36 PM »

I think I found a bug in the spawnFleet method of MagicCampaign

Right, actually the method assumes that the fleet will have a target defined, and can optionally be spawned somewhere else (it defaults to spawning on the target if a location isn't defined). But both can be left null to not spawn the fleet and just use it in special cases such as displaying it in the bounty board.

Long story short, put garnir as the target, not the spawn location. (I added a failsafe for the next MagicLib update)
Logged
 

prav

  • Commander
  • ***
  • Posts: 223
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #151 on: May 06, 2022, 02:24:46 PM »

Small exploit in MagicBounty: discovering a bounty locks in the fleet composition, but not any FP-scaled credit reward. Version 4.2.1rc3.

1. Leave all your ships in storage.
2. Look at a FP-scaling bounty, but don't accept it.
3. Add ten paragons to your fleet.
4. Bounty reward is now sky-high, while the target fleet is still small.
Expected: Credit reward matches bounty fleet size.

Json I was using when I stumbled across it, I suspect that the same behavior shows up with vanilla ship/faction ids:
Spoiler
{
    "prv_gnejserhead_rare_gd":{
   
        "required_mods_id": [],

        #TRIGGERS (ALL OPTIONAL)
        "trigger_min_fleet_size": 25,
       
        #BOUNTY DESCRIPTION
       
        "job_name": "Sanna, The Greed Devil",
        "job_description": "Wanted dead, not alive: The Green Devil\nCharged and convicted in absentia for crimes against both humanity and the corporation. By repeatedly preying on food convoys travelling to the Ryak High-Energy Labs this scourge has put thousands at risk of starvation and seriously impacted day-to-day economic operations at the Lab. End the predations of this vile creature.",
        "job_comm_reply": "A young woman with a ridiculous locust tattoo on her cheek answers your hail. ”Boss ain’t having with you.” she says. Then she takes off a glove and slowly raises her middle finger to the monitor, before equally slowly lowering it onto the red button that shuts down the connection. So much for manners.",
        #"job_intel_success": "",
        #"job_intel_failure": "",
        #"job_intel_expired": "",
        "job_forFaction": "prv",
        "job_deadline": 0,
        "job_credit_reward": 125000,
        "job_reward_scaling": 0.3,
        "job_reputation_reward":5,
        "job_item_reward": {"prv_rare_package_gnejserhead":1,},
        "job_type":"assassination",
        "job_show_type": true,
        "job_show_captain": true,
        "job_show_fleet": "vanilla",
        "job_show_distance": "vanillaDistance",
        "job_show_arrow": false,
        "job_difficultyDescription": "auto",
        #"job_pick_option": "",
        #"job_pick_script": "data.script.script",
        #"job_memKey":"$key",
        #"job_conclusion_script":"data.script.script",
       
      #"existing_target_memkey":"$memKey",

        #TARGET COMMANDER (OPTIONAL)
       
        "target_first_name":"Sanna",
        "target_last_name":"Gröön",
        "target_portrait":"graphics/portraits/portrait_luddic03.png",
        "target_gender":"FEMALE",
        "target_rank": "spaceCommander",
        "target_post": "spacer",
        "target_personality": "cautious",
        "target_aiCoreId": null,
        "target_level": 6,
        "target_elite_skills":2,
        "target_skill_preference": "NO_ENERGY_NO_BALLISTIC_YES_MISSILE_YES_DEFENSE",
        #"target_skills": {"skill":1,},
   
   
        #TARGET FLEET
       
        "fleet_name":"Pirate Raiders",
        "fleet_faction": "pirates",
        "fleet_flagship_variant":"prv_gnejserhead_rare_gd",
        "fleet_flagship_name":"Green Devil",
        "fleet_flagship_recoverable": true,
        "fleet_flagship_autofit": false,
        "fleet_preset_ships": {"prv_gnejserhead_pirate":2,},
        "fleet_preset_autofit": false,
        "fleet_scaling_multiplier": 0.7,
        "fleet_min_FP": 60,
        "fleet_composition_faction": "pirates",
        "fleet_composition_quality": 1,
        "fleet_transponder": false,
     "fleet_no_retreat": false,
        "fleet_behavior": "ROAMING",
       
        #LOCATION
       
        #"location_entitiesID": [],
        "location_marketIDs":["prv_kylan_fjarran_store",],
        "location_marketFactions": ["pirates",],
        "location_distance": "CORE",
        "location_themes": [
      "theme_core_unpopulated",
            "theme_core_populated",
            "theme_core",
            ],
        "location_themes_blacklist": ["theme_hidden", "no_pulsar_blackhole"],
        "location_entities": ["entity",],
        "location_prioritizeUnexplored": true,
        "location_defaultToAnyEntity": false,
    },
}
[close]
Logged

Tartiflette

  • Admiral
  • *****
  • Posts: 3517
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #152 on: May 06, 2022, 11:57:32 PM »

Small exploit in MagicBounty: discovering a bounty locks in the fleet composition, but not any FP-scaled credit reward. Version 4.2.1rc3.

1. Leave all your ships in storage.
2. Look at a FP-scaling bounty, but don't accept it.
3. Add ten paragons to your fleet.
4. Bounty reward is now sky-high, while the target fleet is still small.
Expected: Credit reward matches bounty fleet size.

There's a "min_fp" attribute to deal with that: it prevents the bounty from showing up under a certain player fleet size.
Logged
 

prav

  • Commander
  • ***
  • Posts: 223
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #153 on: May 07, 2022, 12:20:16 AM »

There's a "min_fp" attribute to deal with that: it prevents the bounty from showing up under a certain player fleet size.
The bug is that if you change the size of the player fleet after the bounty fleet has been seen, but the bounty has not yet been accepted, it will still change the credit value of the bounty.

I have a small fleet.
The bounty is at its base value, I do not accept it.
I buy a big fleet, or get it out of storage.
The credit reward is now much higher, but the bounty's ships have not changed.
The actual target fleet is also affected.
If I beef up my fleet before looking at the bounty, the targeted fleet does scale as it should.

What I expected was for the credit reward to be locked in at the same time as the target fleet is created.
« Last Edit: May 07, 2022, 12:23:54 AM by prav »
Logged

wasara

  • Ensign
  • *
  • Posts: 7
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #154 on: May 09, 2022, 08:54:33 AM »

Bug Report with the new test version(0.44.1)
(Also, your bug report form is missing an option to select MagicLib report subject, which is why I'm posting this here)

I get a CTD on new game generation. Nexerelin calls the magic lib plugin: data.scripts.terrain.MagicAsteroidBeltTerrainPlugin and gets a classcastexception. This is using the random sector mode. Issue only appeared after update.

Relevant log snippet below
Spoiler
76986 [Thread-3] INFO  exerelin.world.NexMarketBuilder  - Creating market for Pera-Tartarus (PLANET), faction tritachyon
76987 [Thread-3] INFO  exerelin.world.NexMarketBuilder  - Creating market for Basmaida (PLANET), faction sindrian_diktat
76989 [Thread-3] INFO  exerelin.world.ExerelinProcGen  - Trying station Ohai Trading Post for interstellarimperium, image station_side02
76989 [Thread-3] INFO  exerelin.world.ExerelinProcGen  - Added free station Ohai Trading Post for interstellarimperium
76989 [Thread-3] INFO  exerelin.world.NexMarketBuilder  - Creating market for Ohai Trading Post (STATION), faction interstellarimperium
76990 [Thread-3] INFO  exerelin.world.NexMarketBuilder  - Ohai Trading Post is in ring, adding volatiles condition
77180 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.ClassCastException: data.scripts.terrain.MagicAsteroidBeltTerrainPlugin cannot be cast to com.fs.starfarer.api.impl.campaign.terrain.AsteroidBeltTerrainPlugin
java.lang.ClassCastException: data.scripts.terrain.MagicAsteroidBeltTerrainPlugin cannot be cast to com.fs.starfarer.api.impl.campaign.terrain.AsteroidBeltTerrainPlugin
   at exerelin.world.ExerelinProcGen.createStation(ExerelinProcGen.java:1310)
   at exerelin.world.ExerelinProcGen.populateSector(ExerelinProcGen.java:1953)
   at exerelin.world.ExerelinProcGen.generate(ExerelinProcGen.java:1274)
   at exerelin.world.ExerelinProcGen.generate(ExerelinProcGen.java:1173)
   at exerelin.plugins.ExerelinModPlugin.onNewGameAfterProcGen(ExerelinModPlugin.java:462)
   at com.fs.starfarer.campaign.save.CampaignGameManager.o00000(Unknown Source)
   at com.fs.starfarer.title.TitleScreenState.dialogDismissed(Unknown Source)
   at com.fs.starfarer.ui.N.dismiss(Unknown Source)
   at com.fs.starfarer.ui.impl.K.dismiss(Unknown Source)
   at com.fs.starfarer.campaign.save.if.actionPerformed(Unknown Source)
   at com.fs.starfarer.ui.OoO0.buttonPressed(Unknown Source)
   at com.fs.starfarer.ui.oooO.Ò00000(Unknown Source)
   at com.fs.starfarer.ui.oooO.processInput(Unknown Source)
   at com.fs.starfarer.ui.V.o00000(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
[close]

ModList
Spoiler
{"enabledMods": [
  "NoIllAdvised",
  "better_deserving_smods",
  "BSC",
  "chatter",
  "lw_console",
  "DetailedCombatResults",
  "dronelib",
  "extra_system_reloaded",
  "FPE",
  "fleethistory",
  "GrandColonies",
  "HMI",
  "hcok",
  "IndEvo",
  "Imperium",
  "lw_lazylib",
  "luddenhance",
  "mag_protect",
  "MagicLib",
  "more_hullmods",
  "nexerelin",
  "Polaris_Prime",
  "SEEKER",
  "swp",
  "speedUp",
  "stelnet",
  "alcoholism",
  "ungp",
  "UGH",
  "vayrashippack",
  "wasabounties",
  "audio_plus",
  "shaderLib",
  "ShipCatalogVariantEditor"
]}
[close]
Logged

SafariJohn

  • Admiral
  • *****
  • Posts: 2665
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #155 on: May 09, 2022, 06:28:05 PM »

I am the one behind the new MagicAsteroids code, so thank you for the report. I have looked into this and messaged Histidine with a simple fix on Nexerelin's end.
Logged

Big Bee

  • Commander
  • ***
  • Posts: 113
  • bugs are cool
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #156 on: May 10, 2022, 12:11:31 PM »

Hey, does this mod have a conflict with Bounties Expanded? I got both (as I didn't realize MagicLib has its own bounty system). BE's bounties all seem to spawn in the same system so I thought it was just that mod being weird cause it's unfinished, but the MagicLib bounty boards also seem to mostly use the same system.

I'm playing with Nexerelin random core worlds and the system all the bounties spawn in is a yellow-star system in the core worlds with no colonies, but is not the only uninhabited system in the core.
Logged
Hi I'm not very used to forums sorry

Ruddygreat

  • Captain
  • ****
  • Posts: 317
  • Seals :^)
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #157 on: May 10, 2022, 01:54:04 PM »

Hey, does this mod have a conflict with Bounties Expanded? I got both (as I didn't realize MagicLib has its own bounty system). BE's bounties all seem to spawn in the same system so I thought it was just that mod being weird cause it's unfinished, but the MagicLib bounty boards also seem to mostly use the same system.

I'm playing with Nexerelin random core worlds and the system all the bounties spawn in is a yellow-star system in the core worlds with no colonies, but is not the only uninhabited system in the core.

nah, that's just BE being vaguely unfinished
as far as i know, BE & mlib don't interact at all

leafy

  • Ensign
  • *
  • Posts: 1
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #158 on: May 14, 2022, 11:17:15 PM »

ran the game with magiclib and got this error
Fatal:java.lang.runtimeException: Command[AddBarEvent] not found in package:
com.js.starfarer.api.impl.campaign.rulecmd
com.js.starfarer.api.impl.campaign.rulecmd.salvage
com.js.starfarer.api.impl.campaign.rulecmd.newgame
com.js.starfarer.api.impl.campaign.rulecmd.missions
data.script.bounty.rulecmd
pls help and appericated
Logged

Big Bee

  • Commander
  • ***
  • Posts: 113
  • bugs are cool
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #159 on: May 15, 2022, 03:19:44 AM »

Does MagicBounties support Underworld's cursed IBB bounties?
Logged
Hi I'm not very used to forums sorry

Ruddygreat

  • Captain
  • ****
  • Posts: 317
  • Seals :^)
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #160 on: May 17, 2022, 11:02:44 AM »

ran the game with magiclib and got this error
Fatal:java.lang.runtimeException: Command[AddBarEvent] not found in package:
com.js.starfarer.api.impl.campaign.rulecmd
com.js.starfarer.api.impl.campaign.rulecmd.salvage
com.js.starfarer.api.impl.campaign.rulecmd.newgame
com.js.starfarer.api.impl.campaign.rulecmd.missions
data.script.bounty.rulecmd
pls help and appericated

update your game, you can download the latest version here

Does MagicBounties support Underworld's cursed IBB bounties?

IBBs are part of SWP, magiclib doesn't interfere with them

Big Bee

  • Commander
  • ***
  • Posts: 113
  • bugs are cool
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #161 on: May 17, 2022, 01:05:44 PM »

Does MagicBounties support Underworld's cursed IBB bounties?
IBBs are part of SWP, magiclib doesn't interfere with them

Damn, that sucks. It would be nice if MagicBounties could make all HVB and IBB bounties work without their respective mods. I don't like most of the ships from SWP but I guess I'll have to use it to see the cursed Underworld ships then...
Logged
Hi I'm not very used to forums sorry

Naturalweeb47

  • Ensign
  • *
  • Posts: 4
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #162 on: May 18, 2022, 05:13:17 AM »

Whenever I boot this mod, it throws up an error, how do I fix this?
Log folder not attached, too large. How can I post this here to bypass the kb limit?
Other mods also failed to load, advice on those errors would also be appreciated.
Mods with errors:
UNSC
Superweapons arsenal
Industrial evolution
GraphicsLib (downloads as a single file rather than a zip)
Progressive S-mods
CONCORD
Beyond the sector
Logged

Mira Lendin

  • Captain
  • ****
  • Posts: 315
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #163 on: May 18, 2022, 10:21:44 AM »

Whenever I boot this mod, it throws up an error, how do I fix this?
Log folder not attached, too large. How can I post this here to bypass the kb limit?
Other mods also failed to load, advice on those errors would also be appreciated.
Mods with errors:
UNSC
Superweapons arsenal
Industrial evolution
GraphicsLib (downloads as a single file rather than a zip)
Progressive S-mods
CONCORD
Beyond the sector
Post the last 10 lines from your log file
Logged
^^

Naturalweeb47

  • Ensign
  • *
  • Posts: 4
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #164 on: May 18, 2022, 11:48:47 AM »

With other mods:
FULL LOG: https://1drv.ms/u/s!Ajnp7diZSzLlgjXcwDaI-iPYwoUZ?e=n2qIgu
20351 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/perform_survey_exp_gain.ogg]
20365 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/ui_campaign_sensor_detect_fleet_01.ogg]
20371 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/ui_campaign_sensor_detect_fleet_02.ogg]
20376 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/ui_campaign_sensor_detect_fleet_03.ogg]
20381 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/ui_campaign_sensor_detect_fleet_04.ogg]
20387 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/ui_campaign_sensor_detect_fleet_05.ogg]
20387 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/ui_campaign_sensor_detect_fleet_06.ogg]
20395 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_wpn_guns/heavy_machinegun_fire_01.ogg]
20395 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/fx/trigger/UNGP_glados_chosen.ogg]
20397 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_engines/engine_boost_01.ogg]
20406 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_engines/engine_boost_02.ogg]
20417 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_engines/engine_boost_03.ogg]
20423 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_wpn_guns/mjolnir_fire_01.ogg]
20423 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_impacts/gun_hit_solid_01.ogg]
20429 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_impacts/gun_hit_solid_02.ogg]
20429 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_impacts/gun_hit_solid_03.ogg]
20434 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_wpn_energy/ion_pulser_fire_01.ogg]
20435 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_refit/refit_energy_03.ogg]
20436 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_cargo/cargo_metals_pickup.ogg]
20446 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_01.ogg]
20449 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_02.ogg]
20459 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_03.ogg]
20471 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_04.ogg]
20478 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_05.ogg]

With only magic:
FULL LOG: https://1drv.ms/u/s!Ajnp7diZSzLlgjbY9j0NCxHEx0gI?e=KYhWj1
error message: (see attachment):
20387 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_interface/ui_campaign_sensor_detect_fleet_06.ogg]
20395 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_wpn_guns/heavy_machinegun_fire_01.ogg]
20395 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/fx/trigger/UNGP_glados_chosen.ogg]
20397 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_engines/engine_boost_01.ogg]
20406 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_engines/engine_boost_02.ogg]
20417 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_engines/engine_boost_03.ogg]
20423 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_wpn_guns/mjolnir_fire_01.ogg]
20423 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_impacts/gun_hit_solid_01.ogg]
20429 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_impacts/gun_hit_solid_02.ogg]
20429 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_impacts/gun_hit_solid_03.ogg]
20434 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_wpn_energy/ion_pulser_fire_01.ogg]
20435 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_refit/refit_energy_03.ogg]
20436 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_cargo/cargo_metals_pickup.ogg]
20446 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_01.ogg]
20449 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_02.ogg]
20459 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_03.ogg]
20471 [pool-1-thread-1] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_04.ogg]
20478 [pool-1-thread-2] INFO  sound.Sound  - Loading sound [sounds/sfx_terrain/terrain_hyperspace_deep_storm_lightning_05.ogg]
Logged
Pages: 1 ... 9 10 [11] 12