Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24); New blog post: Simulator Enhancements (03/13/24)

Pages: 1 ... 8 9 [10] 11 12

Author Topic: [OUTDATED] MagicLib  (Read 536690 times)

Tartiflette

  • Admiral
  • *****
  • Posts: 3529
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42rc6 (2022/01/18)
« Reply #135 on: January 25, 2022, 11:22:17 PM »

Re-enabling dismissed bounties is just not feasible. There are too many things that would have to be reverted and could break bounties that require and earlier one to be done (some chain of bounties require specific states that can include just dismissing a previous one). As for the flooding, that's on the bounty itself. There are parameters to give a higher priority to a bounty as well as triggers that prevent it from showing up before you have an appropriately sized fleet, or sufficient level.
Logged
 

fr33l

  • Ensign
  • *
  • Posts: 4
    • View Profile
Re: [0.95.1a] MagicLib v0.42rc6 (2022/01/18)
« Reply #136 on: January 27, 2022, 11:08:18 AM »

Hi, It looks like I faced some bug with bounty.
So my bounty(Faced Remnant Abomination) expired and instead of one notification about that I got a loop of those and they never end, they keep spaming in the game dozens per sec probably, otherwise the game keeps running fine.

Here's how the log looks like:

34713 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova
34723 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 36
34723 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 37
34724 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 38
34725 [Thread-3] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 39 - last
35293 [Thread-3] INFO  net.andylizi.starsector.planetsearch.CoreUIWatchScript  - CoreUI changed
35302 [Thread-3] INFO  net.andylizi.starsector.planetsearch.CoreUIWatchScript  - CoreUI injected
36289 [Thread-7] INFO  sound.public  - Cleaning up music with id [miscallenous_main_menu.ogg]
37814 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova
37841 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova
37861 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova
37881 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova
37899 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova
37917 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova
37935 [Thread-3] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_nova...

Anyway to solve that in that save?

Restarting game doesn't help.
Logged

fr33l

  • Ensign
  • *
  • Posts: 4
    • View Profile
Re: [0.95.1a] MagicLib v0.42rc6 (2022/01/18)
« Reply #137 on: January 27, 2022, 11:40:32 AM »

Managed to solve that using https://fractalsoftworks.com/forum/index.php?topic=4106.0 with

`MagicLib_ResetBounty SKR_nova`
Logged

Tartiflette

  • Admiral
  • *****
  • Posts: 3529
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc2 (2022/02/06)
« Reply #138 on: February 06, 2022, 09:30:32 AM »


Hopefully this update will fix the intel spam issue, as well as the HVB chains being broken. There are a few other bug-fixes too.

changelog
0.42.1
MagicBounties:
   - Fixed an issue with HVBs memkeys improperly set for trigger requirements,
   - Probably fixed the intel spam when ending some bounties (please report it to me immediately if it still occurs after the patch!),
   - Fixed some memkeys requirements not evaluated properly when combined together,
   - Weapons and hullmods can be offered as extra rewards,
   - Extra rewards are no longer given for bounties failed through flagship recovery.

MagicVariables:
   - Changed the way they are pulled to ensure a proper evaluation beforehand.

MagicRender:
   - Fixed issue where objectspace sprite jittering was not applied correctly.

MagicIndustryItemWrangler:
   - Code cleanup.
[close]

This update is save compatible.

Always DELETE the old version before extracting the new one
Requires LazyLib
Logged
 

VivaLozTioz

  • Ensign
  • *
  • Posts: 11
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc2 (2022/02/06)
« Reply #139 on: February 07, 2022, 12:15:07 AM »

Hey, i noticed that my game is no longer loading any bounties and iI still had some to complete from e.g. tahlan. Using the console commands simply returns that there are "no bounties loaded". I removed the older version prior to updating and reinstalled the mod completly but i'm still missing the bounties
Logged

Tartiflette

  • Admiral
  • *****
  • Posts: 3529
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc2 (2022/02/06)
« Reply #140 on: February 07, 2022, 12:26:31 AM »

Could you try to start the game in devmode, load your save and send me the log right after that?
Logged
 

VivaLozTioz

  • Ensign
  • *
  • Posts: 11
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #141 on: February 07, 2022, 04:57:59 AM »

Sure, should i copy some lines to this forum or should i send it to you in some other way?
Logged

Tartiflette

  • Admiral
  • *****
  • Posts: 3529
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #142 on: February 07, 2022, 06:55:50 AM »

Send me the whole thing as a zip, it's simpler.
Logged
 

Yunru

  • Admiral
  • *****
  • Posts: 1560
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #143 on: February 09, 2022, 08:01:20 AM »

Would it be possible to have something like "trigger_marketFaction_always" to specify a faction that ignores the other market faction requirements (but not all other requirements)?

ayylmao4lulz

  • Ensign
  • *
  • Posts: 15
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #144 on: February 16, 2022, 09:39:23 PM »

The intel spam is gone, but several times per second I get this in my console:

Spoiler
Code
6032333 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032333 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032377 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032377 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032423 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032423 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032463 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032463 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032501 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032501 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032538 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032538 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032584 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032584 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032623 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032623 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032662 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032662 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032698 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032698 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032738 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032738 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032779 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032779 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032816 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032816 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
6032856 [Thread-4] INFO  data.scripts.bounty.MagicBountyIntel  - Ending expired bounty SKR_safeguard
6032856 [Thread-4] INFO  data.scripts.bounty.ActiveBounty  - Bounty SKR_safeguard has already ended with stage ExpiredAfterAccepting, not ending again with stage FailedOutOfTime
[close]
Logged

Tartiflette

  • Admiral
  • *****
  • Posts: 3529
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #145 on: February 16, 2022, 11:14:42 PM »

Thanks, that was helpful. Could you try to replace this file in MagicLib/jar and tell me if the issue is (finally) fixed now?
https://www.dropbox.com/s/hz8qdefm8unshjy/MagicLib.jar?dl=1
Logged
 

ayylmao4lulz

  • Ensign
  • *
  • Posts: 15
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #146 on: February 17, 2022, 05:33:55 PM »

Thanks, that was helpful. Could you try to replace this file in MagicLib/jar and tell me if the issue is (finally) fixed now?
https://www.dropbox.com/s/hz8qdefm8unshjy/MagicLib.jar?dl=1

Renamed the old one to `MagicLib.oldjar`, loaded up with this `MagicLib.jar` - still screaming.   :-\
Logged

itBeABruhMoment

  • Commander
  • ***
  • Posts: 157
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #147 on: March 31, 2022, 08:42:07 AM »

I use Ubuntu Linux and all the files in the magic lib folder are owned by the root user for some reason. I managed to fix this after some googling, but is there any particular reason for this?
Logged

Tartiflette

  • Admiral
  • *****
  • Posts: 3529
  • MagicLab discord: https://discord.gg/EVQZaD3naU
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #148 on: March 31, 2022, 11:38:05 PM »

I have no idea? I don't use Linux.
Logged
 

itBeABruhMoment

  • Commander
  • ***
  • Posts: 157
    • View Profile
Re: [0.95.1a] MagicLib v0.42.1rc3 (2022/02/07)
« Reply #149 on: April 29, 2022, 02:21:00 PM »

I think I found a bug in the spawnFleet method of MagicCampaign

Crash log showed the message:

32226 [Thread-4] WARN  data.scripts.util.MagicCampaign  - Spawned your opponent around corvus_IIIa in the corvus system.
32235 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at data.scripts.util.MagicCampaign.spawnFleet(MagicCampaign.java:854)
   at data.scripts.util.MagicCampaign.createFleet(MagicCampaign.java:380)
   at data.scripts.util.MagicCampaign.createFleet(MagicCampaign.java:109)
   at better_variants.bar_events.BetterVariantsBountyEvent.optionSelected(BetterVariantsBountyEvent.java:110)
   at com.fs.starfarer.api.impl.campaign.intel.bar.BarEventDialogPlugin.optionSelecte d(BarEventDialogPlugin.java:53)
   at com.fs.starfarer.ui.newui.W$1.o00000(Unknown Source)
   at com.fs.starfarer.ui.newui.OoOO.actionPerformed(Unknown Source)
   at com.fs.starfarer.ui.newnew.buttonPressed(Unknown Source)
   at com.fs.starfarer.ui.oooO.Ò00000(Unknown Source)
   at com.fs.starfarer.ui.oooO.processInput(Unknown Source)
   at com.fs.starfarer.ui.V.o00000(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

The call to the function was the folowing

Code
                    // get Garnir
                    List<PlanetAPI> corvusPlanets = Global.getSector().getStarSystem("corvus").getPlanets();
                    SectorEntityToken garnirPlanet = null;
                    for(PlanetAPI planet : corvusPlanets) {
                        if(planet.getId().equals("corvus_IIIa")) {
                            garnirPlanet = planet;
                        }
                    }


                    SectorEntityToken fleet = MagicCampaign.createFleet("your opponent", "pirates", null, null, "omen_PD", null,
                        null, 100, "pirates", 1.0f, garnirPlanet, null, null, true, true);

The crash seems to be from the third line of this block of code in the spawnFleet method
Code
        if(verbose){
            log.warn("Spawned "+fleet.getName()+" around "+location.getId()+" in the "+location.getStarSystem().getId()+" system.");
            log.warn("Order: "+order.name()+", target: "+target.getId()+" in the "+target.getStarSystem().getId()+" system.");
        }
Logged
Pages: 1 ... 8 9 [10] 11 12