Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

46

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 17, 2022, 10:10:21 AM »

I think console command is using error prone implementation of reflection and my SettingsAPI shell to mock S-mod display made console command getting the wrong level of the stack depth.

I have little idea about why it is acting up with progressive S-mod. In vanilla environment the refit UI works perfectly and S-modding doesn't show duplicates.
I want to assume progressive S-mod has function call oversight, but after taking a brief view on source I can only summarize that it's vanilla API returning unexpected result.
Specifically
https://github.com/qcwxezda/Starsector-Progressive-S-Mods/blob/main/src/progsmod/data/campaign/rulecmd/PSM_BuildInHullMod.java
On line 53 the hullmod set getter may be reporting doppelganger for some reason

Huh, interesting. 
I think I know what I got to do then. 
Mods might just not work with each other then

Updated to be console command compatible.
Thank you for the reports. I'll work with lazywizard to dig to the source of it.
Currently it's a workaround deferring S-mod mocking override at onGameLoad (was onApplicationLoad) and it somehow works.

Hi there, sorry I was asleep earlier.
Tested with old savegame and new game, Progressive-S mod still showing doubles. 
Depending on which one I choose, it'll either get labeled with (S) or not when hovering over the unit after installation.

I also just noticed the Combat Chatter mod also has a bunch of blocks instead of text

Progressive S-Mod has an error prone implementation of showall, I%u2019ve submitted a pull request for the mod to fix it. Don%u2019t use showall.

Is combat chatter broken after the console command fix?

After reviewing the code I think it%u2019s Lazyfont not getting the font properly, as both mods are having lazy font bricked if SettingsAPI gets an override shell. I%u2019ll work with lazy wizards and see what we can do about it.

Got it, I won't use showall.

It's possible combat chatter was broken before the fix, as I didn't go into a battle in the previous fixes.
I think it's a Lazyfont issue, as I noticed the blocky "Text" also when starting a new Nexerelin game as my own faction and in the beginning where you pick blueprints there's text issues.


Edit:  I wonder if this will be of any help.  Messing around with removing the built-in hullmods, I can no longer remove some of them.  It'll refund me the XP but hull mod stays.  I can keep attempting to remove, thus farming for infinite ship XP

That’s due to progressive S-mod obtaining otherwise impossible to be used Doppelgängers.

The way it works is that when you select the Doppelgänger in the refit, Starsector calls the getId() method to get the Id. Concord intentionally set the Id to be the original hullmod so you’re only ever going to get the original hullmod on your ships. Progressive S-mod bypass the restriction and build in the hullmod that are simply impossible to remove because when you attempt to do that the spec will tell the game to remove the hullmod by calling getId(), which is not possible since it’ll return the original hullmod that was never built in.

47

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 17, 2022, 08:56:40 AM »

I think console command is using error prone implementation of reflection and my SettingsAPI shell to mock S-mod display made console command getting the wrong level of the stack depth.

I have little idea about why it is acting up with progressive S-mod. In vanilla environment the refit UI works perfectly and S-modding doesn't show duplicates.
I want to assume progressive S-mod has function call oversight, but after taking a brief view on source I can only summarize that it's vanilla API returning unexpected result.
Specifically
https://github.com/qcwxezda/Starsector-Progressive-S-Mods/blob/main/src/progsmod/data/campaign/rulecmd/PSM_BuildInHullMod.java
On line 53 the hullmod set getter may be reporting doppelganger for some reason

Huh, interesting. 
I think I know what I got to do then. 
Mods might just not work with each other then

Updated to be console command compatible.
Thank you for the reports. I'll work with lazywizard to dig to the source of it.
Currently it's a workaround deferring S-mod mocking override at onGameLoad (was onApplicationLoad) and it somehow works.

Hi there, sorry I was asleep earlier.
Tested with old savegame and new game, Progressive-S mod still showing doubles. 
Depending on which one I choose, it'll either get labeled with (S) or not when hovering over the unit after installation.

I also just noticed the Combat Chatter mod also has a bunch of blocks instead of text

Progressive S-Mod has an error prone implementation of showall, I’ve submitted a pull request for the mod to fix it. Don’t use showall.

Is combat chatter broken after the console command fix?

After reviewing the code I think it’s Lazyfont not getting the font properly, as both mods are having lazy font bricked if SettingsAPI gets an override shell. I’ll work with lazy wizards and see what we can do about it.

48

Mods / Re: [0.95.1a] Progressive S-Mods (0.8.6) — gain XP for ships, spend it on S-mods

« on: February 17, 2022, 01:03:04 AM »

Hello,

I've created a pull request due to conflict with CONCORD's new mechanics, can you take a look?

49

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 17, 2022, 12:20:21 AM »

I think console command is using error prone implementation of reflection and my SettingsAPI shell to mock S-mod display made console command getting the wrong level of the stack depth.

I have little idea about why it is acting up with progressive S-mod. In vanilla environment the refit UI works perfectly and S-modding doesn't show duplicates.
I want to assume progressive S-mod has function call oversight, but after taking a brief view on source I can only summarize that it's vanilla API returning unexpected result.
Specifically
https://github.com/qcwxezda/Starsector-Progressive-S-Mods/blob/main/src/progsmod/data/campaign/rulecmd/PSM_BuildInHullMod.java
On line 53 the hullmod set getter may be reporting doppelganger for some reason

Huh, interesting. 
I think I know what I got to do then. 
Mods might just not work with each other then

Updated to be console command compatible.
Thank you for the reports. I'll work with lazywizard to dig to the source of it.
Currently it's a workaround deferring S-mod mocking override at onGameLoad (was onApplicationLoad) and it somehow works.

50

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 16, 2022, 10:55:30 PM »

I think console command is using error prone implementation of reflection and my SettingsAPI shell to mock S-mod display made console command getting the wrong level of the stack depth.

I have little idea about why it is acting up with progressive S-mod. In vanilla environment the refit UI works perfectly and S-modding doesn't show duplicates.
I want to assume progressive S-mod has function call oversight, but after taking a brief view on source I can only summarize that it's vanilla API returning unexpected result.
Specifically
https://github.com/qcwxezda/Starsector-Progressive-S-Mods/blob/main/src/progsmod/data/campaign/rulecmd/PSM_BuildInHullMod.java
On line 53 the hullmod set getter may be reporting doppelganger for some reason

Huh, interesting. 
I think I know what I got to do then. 
Mods might just not work with each other then

I uploaded a new patch specifically for progressive S mod, can you check if it still shows duplicate?

51

Mods / Re: [0.95.1a] Console Commands v2021.12.25

« on: February 16, 2022, 10:47:04 PM »

Hello,

Do you have an insight as of why an override implementation of SettingsAPI can break your mod?

Hi there

I do mean S-mods, and I'm using the Progressive S-mod mod with the XP etc etc.  I patched with the update that you uploaded (I think it's the update, the files are dated to 2/16 after RAR extraction) and issue still persists.  If I disable the mod the game save cannot be loaded, says hullmod doesn't exist or something

Here's the screens, you can see the Bazaar Falcon and the Cetan (LG) mech green markers for the s-mods do not always show unless clicked on.  When I click my Cerus the markers disappear

Spoiler

[close]

I believe I can fix that.

In the second screenshot it seems like you have two S-mods but only one bar is showing, is that expected?

Usually the in-built S-mods show up together rather than separate and are labeled as (S) when you hover the cursor over the ship.  However if I hover over the mech you can see that only Heavy Armor has a (S) after it but Integrated Targeting Unit doesn't.

Spoiler

[close]

Patch c is released that fixed *most* of it except for when you select your own ship (flagship, player character as officer). I'm still trying to figure out that one.

Update: patch D fully fixed the S-mod display issue, sorry for the inconvenience!

Hi sorry for all the posts, but figured I'd keep you updated.

Using version "2.1.0b" that's the most recent download I think?

So the built-in hull mod green markers seem to show correctly, but the duplicates are still there. 
Only weird thing now is for some reason console commands are being affected, the text has turned into blocks.
I did this with a new game because I thought it was not save game compatible, same issue.
Ran the game without Concord enabled, issue with text display is gone.
Sorry

Spoiler

[close]

52

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 16, 2022, 10:36:28 PM »

Hi there

I do mean S-mods, and I'm using the Progressive S-mod mod with the XP etc etc.  I patched with the update that you uploaded (I think it's the update, the files are dated to 2/16 after RAR extraction) and issue still persists.  If I disable the mod the game save cannot be loaded, says hullmod doesn't exist or something

Here's the screens, you can see the Bazaar Falcon and the Cetan (LG) mech green markers for the s-mods do not always show unless clicked on.  When I click my Cerus the markers disappear

Spoiler

[close]

I believe I can fix that.

In the second screenshot it seems like you have two S-mods but only one bar is showing, is that expected?

Usually the in-built S-mods show up together rather than separate and are labeled as (S) when you hover the cursor over the ship.  However if I hover over the mech you can see that only Heavy Armor has a (S) after it but Integrated Targeting Unit doesn't.

Spoiler

[close]

Patch c is released that fixed *most* of it except for when you select your own ship (flagship, player character as officer). I'm still trying to figure out that one.

Update: patch D fully fixed the S-mod display issue, sorry for the inconvenience!

Hi sorry for all the posts, but figured I'd keep you updated.

Using version "2.1.0b" that's the most recent download I think?

So the built-in hull mod green markers seem to show correctly, but the duplicates are still there. 
Only weird thing now is for some reason console commands are being affected, the text has turned into blocks.
I did this with a new game because I thought it was not save game compatible, same issue.
Ran the game without Concord enabled, issue with text display is gone.
Sorry

Spoiler

[close]

I think console command is using error prone implementation of reflection and my SettingsAPI shell to mock S-mod display made console command getting the wrong level of the stack depth.
No, viewing the source code I don't understand why it broke, as it shouldn't


I have little idea about why it is acting up with progressive S-mod. In vanilla environment the refit UI works perfectly and S-modding doesn't show duplicates.
I want to assume progressive S-mod has function call oversight, but after taking a brief view on source I can only summarize that it's vanilla API returning unexpected result.
Specifically
https://github.com/qcwxezda/Starsector-Progressive-S-Mods/blob/main/src/progsmod/data/campaign/rulecmd/PSM_BuildInHullMod.java
On line 53 the hullmod set getter may be reporting doppelganger for some reason

53

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 16, 2022, 05:52:05 PM »

Hi there

I do mean S-mods, and I'm using the Progressive S-mod mod with the XP etc etc.  I patched with the update that you uploaded (I think it's the update, the files are dated to 2/16 after RAR extraction) and issue still persists.  If I disable the mod the game save cannot be loaded, says hullmod doesn't exist or something

Here's the screens, you can see the Bazaar Falcon and the Cetan (LG) mech green markers for the s-mods do not always show unless clicked on.  When I click my Cerus the markers disappear

Spoiler

[close]

I believe I can fix that.

In the second screenshot it seems like you have two S-mods but only one bar is showing, is that expected?

Usually the in-built S-mods show up together rather than separate and are labeled as (S) when you hover the cursor over the ship.  However if I hover over the mech you can see that only Heavy Armor has a (S) after it but Integrated Targeting Unit doesn't.

Spoiler

[close]

Patch c is released that fixed *most* of it except for when you select your own ship (flagship, player character as officer). I'm still trying to figure out that one.

Update: patch D fully fixed the S-mod display issue, sorry for the inconvenience!

54

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 16, 2022, 02:03:44 PM »

Hi there

I do mean S-mods, and I'm using the Progressive S-mod mod with the XP etc etc.  I patched with the update that you uploaded (I think it's the update, the files are dated to 2/16 after RAR extraction) and issue still persists.  If I disable the mod the game save cannot be loaded, says hullmod doesn't exist or something

Here's the screens, you can see the Bazaar Falcon and the Cetan (LG) mech green markers for the s-mods do not always show unless clicked on.  When I click my Cerus the markers disappear

Spoiler

[close]

I believe I can fix that.

In the second screenshot it seems like you have two S-mods but only one bar is showing, is that expected?

55

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 16, 2022, 01:20:49 PM »

I downloaded and enabled this mod and for some reason I'm seeing 2 of every hullmod

For missions you need to strip the ship for it to work. The underlying code relies on a hidden hullmod to dynamically change which one you see. Regardless of which one you’re using it’s the same one on the ship.



Actually, let me fix that as well (variant update). Updated

Thanks.
It seems to let me install 2 of each hullmod as a result, though some will be labeled as (S) while others won't be.  The green markers also do not appear unless the ship is selected in the refit section.

Can you give me a screenshot on how that looks like?  Do you mean S-mods?
Does any of the issue persists after the patch?

It may be marked as fitted twice in refit selection but on the ship you only get one and the effect is only applied by the original hullmod, not the doppelgänger.

56

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 16, 2022, 12:41:00 PM »

I downloaded and enabled this mod and for some reason I'm seeing 2 of every hullmod

For missions you need to strip the ship for it to work. The underlying code relies on a hidden hullmod to dynamically change which one you see. Regardless of which one you’re using it’s the same one on the ship.


Actually, let me fix that as well (variant update). Updated

57

Mods / Re: [0.95.1a] Modern Carriers 1.8.3

« on: February 16, 2022, 08:07:14 AM »

Avatar core + Drone carrier + Alpha Core

Praise the machine lords!

I don’t think I’ve released the latest “fighter automation interface” allowing drone carriers to use regular fighters but glad you like it!

58

Suggestions / Re: API request thread (please read OP before posting!)

« on: February 16, 2022, 07:25:16 AM »

A method to do stuff when a hullmod is removed, something like `BaseHullMod.onRemoval(ShipAPI ship)` perhaps?

Edit: More reasonable method name suggestion.

Necro'ing this one! An 'onRemoval' would certainly be useful for some crazy hullmods. If it can also refresh the refit screen with a boolean perhaps, that'd be golden!

'BaseHullMod.onRemoval(ShipAPI ship, boolean refresh)'

I think it’s a terrible idea given the ways of removal are inconsistent
For example, remove by undo will simply restore to the initial variant “checkpoint”  and skip pretty much any call, as it should. If your call is counting on this behavior or the other way (call onRemove even on undo), it’s inherently bad design that ignores the interface.

59

Mods / Re: [0.95.1a] Concord 2.0.0

« on: February 16, 2022, 12:33:44 AM »

2.0.0 updated, now supports concord implementation without coding and native incompatibility!

60

Bug Reports & Support (modded) / HullModSpecAPI.setEffectClass not updating instance

« on: February 14, 2022, 08:29:51 PM »

  It creates the HullModEffect object, calls init but the spec itself never updates?