16
Bug Reports & Support / Re: (0.95a) Free D mod removal
« on: March 27, 2021, 01:06:05 AM »
Just found this myself, can confirm that just opening and closing the 'build in' hullmod menu for the ship causes this.
Starsector 0.97a is out! (02/02/24); New blog post: Save/Load UI, Autosave, Intel Map Markers, and More (04/10/24)
I'll look into this problem. Could you send me a copy of your save file with the bug present? It would also be very helpful if you could create a ZIP of your mod folder as well so I don't have to track down each individual mod to load the save. Thank you!
It looks like those hullmods are uninstallable because the code checking if each hullmod is valid excludes the hullmod itself. For example, PoweredArmour.java contains the following code:I'm not sure when isApplicableToShip is called exactly, but it automatically excludes/removes the hullmod if any of the above are already on the ship. Because Powered Armour = Powered Armour, the hullmod gets kicked off the list every time it is selected. I made it installable by removing the bit of code that checks for it, which shouldn't affect anything in a bad way because the game doesn't allow hullmods to be installed twice regardless of if isApplicableToShip gets overridden. Here's an example of the change:Spoiler@Override
public boolean isApplicableToShip(ShipAPI ship) {
return
((!ship.getVariant().getHullMods().contains("PoweredArmour")) &&
(!ship.getVariant().getHullMods().contains("EnergyAbsorbers")) &&
(!ship.getVariant().getHullMods().contains("comp_armor")) &&
(!ship.getVariant().getHullMods().contains("Deflectors")));
}[close]I tested it on an RSF battleship in the simulator and now Energy Absorbers, comp armor, and Deflectors can't be installed alongside it, as intended, but Powered Armour doesn't accidentally break itself.Spoiler@Override
public boolean isApplicableToShip(ShipAPI ship) {
return
((!ship.getVariant().getHullMods().contains("EnergyAbsorbers")) &&
(!ship.getVariant().getHullMods().contains("comp_armor")) &&
(!ship.getVariant().getHullMods().contains("Deflectors")));
}[close]
Hello, I’ve found a minor bug report; I found a MSS Sipahi Tail for sale in the Sindria black market.And thats a bug how? Black Markets sell a lot of random stuff given the chance.