Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

1

Suggestions / shipRoles in luddic_church faction file affecting hull spawns

« on: December 10, 2020, 08:09:05 AM »

I have been using a lot of mods in my runs, but I started to notice that Alfonzo's Luddic Enhancement mod does not seem that have several skins appearing for the luddic church. Most notably, the LC_Legion and LC_Onslaught which I found have not been spawning in any of the luddic church fleets. Some people, including Alfonzo the mod maker himself has pointed out that the cause is Vayra's Sector hullFrequency and factionDoctrine. I have considered that this is partially responsible for the spawning of some modded ships, but it does not take account of some other ships, notably the LC_onslaught even though I have removed hullFrequency from Vayra's luddic_church.faction file.

After checking the mod several times and testing several changes to the luddic_church.faction file of the mod, as well as comparing other ship skins in various other mods on what could be the possible cause that the LC_Onslaught skin is not spawning, I have still unable to find the cause of why a particular skin (lc_legion) is unable to spawn. I have considered it is due to priorityShips but it still does not fully solve the issue. In the end, I have taken a look at the vanilla luddic_church.faction file and found these lines.

Vanilla luddic_church faction code

Code

	"shipRoles":{
		"carrierSmall":{
			"includeDefault":true,
			"condor_Strike":50,
		},
		"carrierMedium":{
			"includeDefault":true,
			"mora_Strike":50,
		},
		"carrierLarge":{
			"legion_FS":50,
			"legion_Strike":50,
			#"fallback":{"combatCapital":1},
		},
		"combatMedium":{
			"includeDefault":true,
			"buffalo2_Fighter_Support":50,
			"enforcer_Fighter_Support":50,
		},
		"combatFreighterMedium":{
			"includeDefault":true,
			"mule_Fighter_Support":50,
		},
		"combatLarge":{
			"includeDefault":true,
			"dominator_Fighter_Support":50,
		},
		"phaseSmall":{
			"fallback":{"combatSmall":1},
		},
		"phaseMedium":{
			"fallback":{"combatMedium":1},
		},
		"phaseLarge":{
			"fallback2":{"combatLarge":1},
		},
	},

[close]

I have found that these shipRoles lines, although I would assume that the original intention is to enforce certain variants for the luddic church fleets, have resulted in heavily affecting entire spawns as well. Although this is not an issue for Vanilla as the only notable carrierMedium and carrierLarge are the Mora and Legion, it has a great impact on modded content that wish to add ships to these shipRoles. In this example, the lc_legion skin for carrierLarge.

This is the result of spawning a fleet with:
- Unedited Vanilla luddic_church.faction
- Edited Luddic Enhancement Mod luddic_church.faction (edited with priorityShips to allow its ships to spawn)

Image #1

[close]

This is the result of spawning a fleet with:
- Edited Vanilla luddic_church.faction (shipRoles, which is the code above completely removed)
- Same as above

Image #2

[close]

This is the result of spawning a fleet with:
- Unedited Vanilla luddic_church.faction
- Further edited Luddic Enhancement Mod luddic_church.faction (added carrierLarge shipRoles of value 50 to legion_lc variants)

Added Code

Code

	"shipRoles":{
		"carrierLarge":{
			"legion_lc_Assault":50,
			"legion_lc_Escort":50,
			"legion_lc_FS":50,
			"legion_lc_Strike":50,
		},
	},	

[close]

Image #3

[close]

In image #1, there is a complete absence of legion skins. Meanwhile, Image #2 and #3 have legion skins, indicating that shipRoles code has an impact on spawn rates (not just priorityShips).

My proposed suggestion is to not have shipRoles affect the ship spawns and limit the effects to the respective ships they are trying to influence as this would affect mods that would like to add additional variety in ships for luddic church fleets.

TL;DR: Ship variants under shipRoles in vanilla luddic_church.faction containing value of 50 is able to affect other ship spawn rates in their respective ship roles. This impedes mods that wish to add new ships to luddic church's arsenal. The suggestion is to not have shipRoles affect the ship spawns and limit the effects to the respective ships they are trying to influence