Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: OfficerManagerEvent cause a NPE  (Read 1142 times)

Deathfly

  • Modders' Vanguard
  • Commander
  • ***
  • Posts: 245
  • Murdered by T. H. Morgan
    • View Profile
OfficerManagerEvent cause a NPE
« on: November 26, 2015, 09:03:48 AM »

When testing Neutrino DEV ver for 0.7a, seem like a NPE cause by OfficerManagerEvent will randomly happen.

1023105 [Thread-5] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at com.fs.starfarer.campaign.econ.Market.removePerson(Unknown Source)
   at com.fs.starfarer.api.impl.campaign.events.OfficerManagerEvent.removeAvailable(OfficerManagerEvent.java:130)
   at com.fs.starfarer.api.impl.campaign.events.OfficerManagerEvent.advance(OfficerManagerEvent.java:99)
   at com.fs.starfarer.campaign.events.CampaignEventManager.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$2.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)

seems like that manager tried to fire an officer did not exist.
Logged
A not-so-noob functional geneticist
And a free bug hunter
Code and decode almost everythings with a genomics approach.
Served in Neutrino corporation as a long-term services and supports staff.

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 24118
    • View Profile
Re: OfficerManagerEvent cause a NPE
« Reply #1 on: November 26, 2015, 09:36:17 AM »

Thanks - fixed. At least, there should be no crash. The issue comes up when it tries to remove a person from a market that has no "people" on it at all. Not quite sure how OME would get in that state, though, or why it comes up for Neutrino and not also vanilla.
Logged

Deathfly

  • Modders' Vanguard
  • Commander
  • ***
  • Posts: 245
  • Murdered by T. H. Morgan
    • View Profile
Re: OfficerManagerEvent cause a NPE
« Reply #2 on: November 26, 2015, 05:34:51 PM »

Ah, that must be the abandon Neutrino station that hold the unsung in "somewhere". For no reason it have a Abandoned market to hold that ship. I think I should look at some other way to do so.
Logged
A not-so-noob functional geneticist
And a free bug hunter
Code and decode almost everythings with a genomics approach.
Served in Neutrino corporation as a long-term services and supports staff.