Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: [0.65.2a] Roman numeral overflow crash on ship names  (Read 2450 times)

Histidine

  • Admiral
  • *****
  • Posts: 4682
    • View Profile
    • GitHub profile
[0.65.2a] Roman numeral overflow crash on ship names
« on: March 28, 2015, 06:04:01 AM »

From the Nexerelin thread:

Got this strange error:

Code
299345565 [Thread-5] INFO  com.fs.starfarer.api.impl.campaign.fleets.MercAndPirateFleetManager  - Checking whether to spawn pirate or merc fleet for market [Effecer]
299345565 [Thread-5] INFO  com.fs.starfarer.api.impl.campaign.fleets.MercAndPirateFleetManager  - 2 out of a maximum 4 pirate/merc fleets in play for market [Effecer]
299346264 [Thread-5] ERROR com.fs.starfarer.combat.D  - java.lang.NumberFormatException: Numbers must be in range 1-3999
java.lang.NumberFormatException: Numbers must be in range 1-3999
at com.fs.starfarer.util.oOOO.super(Unknown Source)
at com.fs.starfarer.loading.ShipNameStore.o00000(Unknown Source)
at com.fs.starfarer.loading.ShipNameStore.o00000(Unknown Source)
at com.fs.starfarer.campaign.fleet.FleetData.addFleetMember(Unknown Source)
at com.fs.starfarer.campaign.fleet.FleetData.addFleetMember(Unknown Source)
at com.fs.starfarer.campaign.Faction.pickShipAndAddToFleet(Unknown Source)
at com.fs.starfarer.api.impl.campaign.fleets.FleetFactory.createMerc(FleetFactory.java:508)
at com.fs.starfarer.api.impl.campaign.fleets.MercAndPirateFleetManager.advance(MercAndPirateFleetManager.java:97)
at com.fs.starfarer.campaign.BaseCampaignEntity.advance(Unknown Source)
at com.fs.starfarer.campaign.CampaignPlanet.advance(Unknown Source)
at com.fs.starfarer.campaign.BaseLocation.advance(Unknown Source)
at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
at com.fs.starfarer.campaign.ooOO.super(Unknown Source)
at com.fs.starfarer.new.Òôo000(Unknown Source)
at com.fs.oOOO.oOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.Ò00000(Unknown Source)
at com.fs.starfarer.combat.D.o00000(Unknown Source)
at com.fs.starfarer.StarfarerLauncher$2.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

Not sure what caused it, was just flying around after killing a few pirate fleets and it gave me a CTD with that error message listed (the number 1-3999 thing). Could it be a mod having variant issues?

(c.f. NumberFormatRomanAbstract.java)

This may or may not be something that only happens in mods, but it's also something that (AFAIK) modders don't have easy control over, and seems like something that really shouldn't cause a crash anyway. Could it be fixed?
Logged

Dark.Revenant

  • Admiral
  • *****
  • Posts: 2806
    • View Profile
    • Sc2Mafia
Re: [0.65.2a] Roman numeral overflow crash on ship names
« Reply #1 on: March 28, 2015, 09:33:04 AM »

I know that a full SS+ game can get to really high numbers overall, like in the range of a hundred, but 4000?  Either the game was incredibly long or a faction has too limited name options.
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 24112
    • View Profile
Re: [0.65.2a] Roman numeral overflow crash on ship names
« Reply #2 on: March 28, 2015, 10:39:46 AM »

Thanks - made it not crash by rolling over. Still, yeah, this seems indicative of another problem.
Logged