Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: intel screen: 60000 reward bounties cause erroneous text highlight  (Read 2959 times)

TJJ

  • Admiral
  • *****
  • Posts: 1905
    • View Profile

Bounties for 60000 credits end up having the 60 in "60000 credit" highlighted in yellow, instead of the usual "Offered for 60 days"

Logged

Midnight Kitsune

  • Admiral
  • *****
  • Posts: 2847
  • Your Friendly Forum Friend
    • View Profile
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #1 on: October 22, 2014, 05:59:43 AM »

I've seen this as well. Also the 60 in "Offered for 60 days" part is NOT highlighted
Logged
Help out MesoTroniK, a modder in need

2021 is 2020 won
2022 is 2020 too

TJJ

  • Admiral
  • *****
  • Posts: 1905
    • View Profile
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #2 on: October 22, 2014, 06:14:55 AM »

Present in the notification popup too.

Logged

Midnight Kitsune

  • Admiral
  • *****
  • Posts: 2847
  • Your Friendly Forum Friend
    • View Profile
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #3 on: October 22, 2014, 08:51:08 AM »

Looks like it is present in any of the named bounty notifications that have 60 in the amount of money
Logged
Help out MesoTroniK, a modder in need

2021 is 2020 won
2022 is 2020 too

Dark.Revenant

  • Admiral
  • *****
  • Posts: 2806
    • View Profile
    • Sc2Mafia
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #4 on: October 22, 2014, 10:55:08 AM »

A simple solution would be to highlight "60 days" instead of "60".
Logged

TJJ

  • Admiral
  • *****
  • Posts: 1905
    • View Profile
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #5 on: October 22, 2014, 11:47:07 AM »

A simple solution would be to highlight "60 days" instead of "60".

I'll admit it did perplex me for some time as to how such a bug could exist; imagining the implementation that could produce this bug made me shiver  ;D

I'd have just embedded the necessary formatting metadata into the text stream (probably as simple xml), and made the font renderer capable of parsing it. You know.... like html does it. ::)
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 24109
    • View Profile
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #6 on: October 23, 2014, 05:40:09 PM »

Thanks for the report; fixed.

A simple solution would be to highlight "60 days" instead of "60".

I'll admit it did perplex me for some time as to how such a bug could exist; imagining the implementation that could produce this bug made me shiver  ;D

I'd have just embedded the necessary formatting metadata into the text stream (probably as simple xml), and made the font renderer capable of parsing it. You know.... like html does it. ::)

Ah, it's one of those things where doing it "right" never quite seems worth it, and still doesn't, given all the other things to do that have more visible impact :) For reference, all it does is replace tokens in order, here, the order was wrong. If it gets to be any more a pain, I'll probably cave and write a simple parser, though. But then I'd probably want to convert everything to use it (basically, anywhere highlighted text appears in the game), and that wouldn't be any fun.
Logged

SafariJohn

  • Admiral
  • *****
  • Posts: 3020
    • View Profile
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #7 on: October 23, 2014, 08:31:08 PM »

Incidentally it also shows up in 260,000 bounties. Same bug, obviously.
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 24109
    • View Profile
Re: intel screen: 60000 reward bounties cause erroneous text highlight
« Reply #8 on: October 23, 2014, 08:31:54 PM »

Yep.
Logged