Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[xenoargh]

Basically, if Hitpoints < 0f, then a ship just goes poof, no explosion and no Hulk. 

I presume this is some sort of safety catch to prevent div-by-zero somewhere; could it maybe force the hitpoints back to zero or whatever is safe at that point and convert it into a Hulk instead?  I'm preventing it over here with a catch that sets Hitpoints to 0.00001f in that case, but I thought I'd mention that this can happen and that it's probably not the desired behavior.

[Alex]

Changed so they don't disappear, as I don't think this actually affects anything in vanilla.

Not sure how this would come up as a problem - you probably shouldn't be setting hitpoints to <0, and as far as I can tell, vanilla doesn't do that.

[Debido]

We're you directly applying damage to the hull?  I'll have to take note of that as I've been thinking of looking at weapons that bypass shields and armour.

On another note, if you 'heal' a ship too much it will cause a crash as well. I'll need to check the logs but I think it had something to do with the hull strength bar length becoming too long.

That said I don't think this would come up on vanilla gameplay, ever.

[xenoargh]

Yeah, I was setting Hitpoint values directly. 

This has been 100% safe in testing:

Code

ship.setHitpoints(Math.max(0.00001f,ship.getHitpoints() - dam));

But I saw this error with:

Code

ship.setHitpoints(Math.max(0f,ship.getHitpoints() - dam));

...probably floating-point silliness

[Debido]

I'm still getting around to it, but can you kill an shop with 'direct' hitpoint manipulation? Aka, cause it to explode. Or do you need to cause normal in-game mechanic damage to get the final kill?

BTW I'm having so much fun messing with the ShipAPI

[xenoargh]

Yes, that always results in a dead ship, at least over here.

Oh, snap.  I forgot about the "critical reactor meltdown" script... I'll bet that's what's happening; some weird interaction where it's deleting the entity or something.  Got to check what happens there if Hitpoints < 0f...

Anyhow, like Alex said, setting to 0f should be safe and should result in a dead ship.

[xenoargh]

Nope, that doesn't do it; that's all direct damage.  So hitting 0f really does appear to be triggering the sudden removal of the entity.  Anyhow, fixed over here and setting to 0.00001f always results in "dead"