Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Alex]

Complaint
I recently had a bug which resulted from ActionStage's enoughMadeIt() check not taking into account whether the fleet was spawned with ignoreMarketFleetSizeMult, when calculating how many ships made it vs. how many should have. This means that a sufficiently high fleet size mult on the origin market will cause the stage to fail even if no fleet took any losses.

It's pretty straightforward to add my own check in derived classes, but might be good for the vanilla code to do it as well. Perhaps mark the fleet as having ignored size mult as a memory flag, then have enoughMadeIt() check for that?

Ahh, that's a really good point. Added a $spawnFPMult to fleet memory; this is set in FleetFactoryV3 and is the number-of-ships multiplier. So in enoughMadeIt() that's used instead of checking the market's value.

Quick update on this: changed $spawnFPMult to be the ratio of actual fleet points in the spawned fleet to the total points specified in the FleetParamsV3.

That way it also covers cases like asking for too many points, i.e. when the fleet has to be cut down to fit in the 30 ship limit, or even just when the total number of points doesn't quite match the asked-for number because, say, there's 2 points left and no ship that costs that little.

[Histidine]

Thanks for the help and the work, Alex

How long does the "Recent trade/events" modification to commodity availability last?
Is there an API method to apply/modify the recent trade availability bonus to a market? (Searched for "Recent trade/events" in API but couldn't find anything)

[Alex]

How long does the "Recent trade/events" modification to commodity availability last?
Is there an API method to apply/modify the recent trade availability bonus to a market? (Searched for "Recent trade/events" in API but couldn't find anything)

30 days, see: BaseSubmarketPlugin.TRADE_IMPACT_DAYS

Also see CommodityOnMarketAPI:
addTradeMod()
addTradeModPlus()
addTradeModMinus()
getTradeMod()
getTradeModPlus()
getTradeModMinus()

The duration is passed in as a parameter to those methods.

The Plus and Minus versions can only ever increase (or decrease, for Minus) the "available" units. It's a bit dodgy, though, I forget exactly the circumstances that cause it, but using *Minus can lead to profitable buy/sell cycles (i.e. infinite money), so I'd say probably don't use that. AFAIK the other (i.e. not *Minus) methods work fine.

[Ross]

Is there a way to get what key/button is bound for a certain action in-game? For example, if I wanted to get the "strafe left" key?

[Alex]

Sort of.

Global.getSettings().getControlStringForEnumName(<string>)

However, the enum in question is not exposed in the API. Here's the subset for ship commands:

Spoiler

SHIP_FIRE("Fire selected weapon group", Category.FLIGHT),
      SHIP_SHIELDS("Toggle shields or phase cloak", Category.FLIGHT),
      //SHIP_SHIELDS_LOCK("Lock omni-directional shields to a relative facing", Category.FLIGHT),
      SHIP_USE_SYSTEM("Use ship's active system", Category.FLIGHT),
      SHIP_VENT_FLUX("Vent flux", Category.FLIGHT),
      SHIP_HOLD_FIRE("Hold fire", Category.FLIGHT),
      SHIP_PULL_BACK_FIGHTERS("Toggle fighter engage/regroup", Category.FLIGHT),
      SHIP_ACCELERATE("Accelerate", Category.FLIGHT),
      SHIP_ACCELERATE_BACKWARDS("Accelerate backwards", Category.FLIGHT),
      SHIP_DECELERATE("Decelerate", Category.FLIGHT),
      SHIP_TURN_LEFT("Turn left", Category.FLIGHT),
      SHIP_TURN_RIGHT("Turn right", Category.FLIGHT),
      SHIP_STRAFE_KEY("Strafe and turn to cursor", Category.FLIGHT),
      SHIP_STRAFE_LEFT_NOTURN("Strafe left", Category.FLIGHT),
      SHIP_STRAFE_RIGHT_NOTURN("Strafe right", Category.FLIGHT),
      SHIP_SELECT_GROUP_1("Select weapon group 1", Category.FLIGHT),
      SHIP_SELECT_GROUP_2("Select weapon group 2", Category.FLIGHT),
      SHIP_SELECT_GROUP_3("Select weapon group 3", Category.FLIGHT),
      SHIP_SELECT_GROUP_4("Select weapon group 4", Category.FLIGHT),
      SHIP_SELECT_GROUP_5("Select weapon group 5", Category.FLIGHT),
      SHIP_TOGGLE_GROUP_1("Toggle autofire for weapon group 1", Category.FLIGHT),
      SHIP_TOGGLE_GROUP_2("Toggle autofire for weapon group 2", Category.FLIGHT),
      SHIP_TOGGLE_GROUP_3("Toggle autofire for weapon group 3", Category.FLIGHT),
      SHIP_TOGGLE_GROUP_4("Toggle autofire for weapon group 4", Category.FLIGHT),
      SHIP_TOGGLE_GROUP_5("Toggle autofire for weapon group 5", Category.FLIGHT),
      SHIP_TARGET_SHIP("Target ship/clear target", Category.FLIGHT),
      SHIP_TOGGLE_XPAN_MODE("Switch view to target", Category.FLIGHT),
      SHIP_SHOW_WARROOM("Show map & command UI", Category.FLIGHT, Category.C2, Category.C2_WAYPOINT, Category.C2_FRIENDLY, Category.C2_HOSTILE),
      SHIP_TOGGLE_WEAPON_ARCS("Toggle weapon arcs", Category.FLIGHT),
      SHIP_RETREAT("Initiate travel drive to retreat", Category.FLIGHT),
      SHIP_RAISE_FLUX("Raise flux levels", Category.UNCONFIGURABLE),

[close]

[Ross]

Cool, thanks!

And it looks like I can use Keyboard.getKeyIndex() to get the integer key code from the control string. (In case anyone else is trying the same thing I am.)

[Histidine]

Calling market.setFreePort(true) on a market with free port boolean set to false but having the Free Port market condition, still adds a second Free Port condition

I suppose someone should yell at the modders to fix their market generation code (to not add the condition without applying the boolean), but I doubt we can count on them actually doing so. Meh, I'll just add the check for the condition to my own code.

[Alex]

Argh. Yeah, it's not a condition that ought to be added manually, just via setFreePort(). Made it not add duplicates, although that doesn't fix the underlying problem of "adding the condition manually gets it out of sync with the boolean so don't do that"...

[Harmful Mechanic]

I suppose someone should yell at the modders to fix their market generation code (to not add the condition without applying the boolean), but I doubt we can count on them actually doing so.

Well, this is the first I'm hearing about it, so I guess you'll never know.

[Histidine]

When I create a SectorEntityToken with LocationAPI.createToken(), then assign it an orbit with setCircularOrbit, it remains stationary (I can tell from the things I put in orbit around the token). How should I work around this?

[Alex]

I think the missing step is to location.addEntity(token), which will make sure the orbit's advance() method gets called. The createToken method does not actually add it to the location as it's not required for many of the uses.

[Sundog]

Am I correct in thinking that these are the only methods available for dynamically adjusting the specs of a ship system?

Code

    @Override
    public void applyEffectsAfterShipCreation(ShipAPI ship, String id) {
        ShipSystemAPI myShipSystem = ship.getSystem();
        myShipSystem.setCooldown((float) Math.PI);
        myShipSystem.setFluxPerSecond((float) Math.E);
        myShipSystem.setFluxPerUse(Float.MAX_VALUE);
    }

I'm trying to adjust ship system values like those, but I was hoping for a way to adjust charge regen rate as well.

Also, is there a better way to get ship system specs than loading ship_systems.csv?

[Alex]

Correct, yeah.

Made a few additions:

Added to SettingsAPI:
   ShipSystemSpecAPI getShipSystemSpec(String id);
   List<ShipSystemSpecAPI> getAllShipSystemSpecs();
Added a lot of methods to ShipSystemSpecAPI

[Stargazer7x]

How would I go about increasing the maximum amount of random constellations and planets generated in the sector?
I already modified the sector's size and I am not sure if that makes a difference or not, but I would like to use a method that allows more fine tuning if at all possible.

[Sundog]

Many thanks!