This mod is weird on a logic point of view, and bad in an implementation point of view. Allow me to start with the easiest one:
Why would someone like what are basically "space terrorists" accept a bribe from a random person or faction? Same thing goes for totalitarian, extremist or simply "bad guys" with nothing but the desire of conquering more stuff and destroying anything that is not one of them, not to mention certain factions where the "AI" will certainly not desire peace by any means, assuming they even know what a bribe is. Why would any of them accept peace through bribe (and in some cases, peace at all?)?
Now for the worst part...
The way you implemented this is wrong in several levels:
- It injects code into other people's mods, it would be MUCH preferable to go the same way mods such as Nexerelin or Commissioned Crews went, and if people want to have this feature on their mod, they WILL add it, in most cases you won't even need to ask people to add compatibility on their end because they'll do it gladly, no need for this (or any other mod) to forcibly change their files;
- It has the potential to break mods that require scripted interactions or certain faction relationships to be true within certain parameters, and even though you have a whitelist available allowing people to add the factions they want to be at peace with is NOT a desirable option to give to the common user the option to do so, as they'll be breaking mods without knowing it, and hoping that they will read one of the comments you have in the whitelist or even the forum thread in hope that they'll know your mod is the culprit if something goes wrong is putting your faith in the wrong hands when some fail to read messages right next to the download button itself;
- What if some modder DOES want his mod to be compatible with this mod? Will said person have to talk with you so you can update the whitelist with the next patch? Wouldn't it be easier to follow the same way many other mods did compatibility with faction mods? By doing so each faction could even set a tax or custom bribe values for their own faction, allowing for customization, ease and freedom to make a faction compatible if each faction mod's owner so decides;
- What if the user simply wants to install this mod and have all it's features available out of the box? Will they always be forced to edit the files if they want to (in practice) truly "enable" this mod?
Some notes:
- Yes, I mentioned the "space terrorists" and I know the Luddic Path is not in the whitelist, but that paragraph still applies to some modded factions as well;
- The existance of a whitelist does not invalidate the fact that this is not a safe implementation and makes turning a faction mod compatible with this mod a pain for the user, while all the user should have to do is download the mod, paste it in the correct folder and it's all done;
- I've seen the convos that happened in the discord server, and I'd recommend that you re-read them and accept the suggestions and tips people gave you. I don't expect you (or hope you don't) get backlash for doing things the way you did, but I can expect modders to start channeling errors at you and eventually people will start getting mad, nobody likes to have to deal with issues caused by someone else, and this will be no exception. You can prevent that from happening, and changing the way this mod works by giving modders the option to either make their faction compatible with this mod or not will be better for everyone: you, the modders, and the users.
