Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[DeathSG]

hey i would just like to point out that the getEntityByName is not fixed yet.

[Apophis]

i think i have found the problem with the minimash, maybe getEntityByName() is not broken

[Alex]

Hmm. Just did some testing, and it appears to be working fine. Certainly possible that it won't work under some circumstances, but I tried spawning a fleet at a planet (the token for which I got using getEntityByName()), inside a custom SectorGeneratorPlugin.generate(), and that worked.

@Apophis: can you let me know what the issue turned out to be? Looking at DeathSG's Corvus.java, I'm not seeing anything that jump out - beyond overwriting Corvus.java, which isn't the right thing to do.

@DeathSG: if you can link to a broken copy of the mod (in case Apophis's fix doesn't work), I'll take a look at it.

[Apophis]

The problem was a generator.csv in Minimash\data\world.

But in my mod i have found that if you use getEntityByName() in a generator it will not work at the start. In my case i used getEntityByName inside the spawnfleet method of my custom spawn point. If i manually call spawnfleet from my generator getEntityByName don't work, but in the next "automatic"(after daysInterval time) calls to the method everything work

[Alex]

Can you post a copy of the mod somewhere? I tested exactly what you're describing (spawnFleet from the generator) and it worked.

[Apophis]

here the mod that crash

[Alex]

Thanks!

I think I see the problem - unless I'm missing something, doesn't look like you're actually adding the stations to the game (using system.addOrbitalStation).

[Apophis]

Yes, i am using stations already present

[Alex]

Are they created by another mod? The order in which the generator scripts are run isn't guaranteed, aside from the base game's SectorGen running first.

[Apophis]

I use the 3 default stations

[Alex]

Ahh, I was misreading your code (saw the last station not being a default one, didn't read the rest in enough detail).

So - it'll break if using a station only, before the game has started running (now fixed). It'll correctly get planets, though - and, actually, any stations that were added before another planet will work too.

Thank you for helping!