Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: [0.9a RC10] NPE on picking ship for role which faction doesn't have  (Read 1134 times)

Histidine

  • Admiral
  • *****
  • Posts: 4688
    • View Profile
    • GitHub profile

Console command to reproduce:
Code: java
runcode Global.getSector().getFaction("luddic_path").pickShip("combatCapital", com.fs.starfarer.api.campaign.FactionAPI.ShipPickParams.priority())

Example error log:
Code
336295 [Thread-4] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
at com.fs.starfarer.campaign.Faction.pickShip(Unknown Source)
at com.fs.starfarer.campaign.Faction.pickShip(Unknown Source)
at com.fs.starfarer.campaign.Faction.pickShip(Unknown Source)
at exerelin.campaign.submarkets.PrismMarket.addShips(PrismMarket.java:289)
at exerelin.campaign.submarkets.PrismMarket.updateCargoPrePlayerInteraction(PrismMarket.java:118)
at com.fs.starfarer.campaign.ui.o0OO.<init>(Unknown Source)
at com.fs.starfarer.coreui.O00o.<init>(Unknown Source)
at com.fs.starfarer.coreui.O00o.<init>(Unknown Source)
at com.fs.starfarer.ui.newui.J$5.actionPerformed(Unknown Source)
at com.fs.starfarer.ui.newui.J.setCurrentTab(Unknown Source)
at com.fs.starfarer.ui.newui.J.setCurrentTab(Unknown Source)
at com.fs.starfarer.ui.newui.U.showCoreInternal(Unknown Source)
at com.fs.starfarer.ui.newui.U.showCore(Unknown Source)
at com.fs.starfarer.api.impl.campaign.rulecmd.OpenCoreTab.execute(OpenCoreTab.java:40)
at com.fs.starfarer.ui.newui.oOOO.actionPerformed(Unknown Source)
at com.fs.starfarer.ui.OoO0.buttonPressed(Unknown Source)
at com.fs.starfarer.ui.oooOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.?00000(Unknown Source)
at com.fs.starfarer.ui.oooOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO.processInput(Unknown Source)
at com.fs.starfarer.ui.V.super(Unknown Source)
at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
at com.fs.state.AppDriver.begin(Unknown Source)
at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 24126
    • View Profile
Re: [0.9a RC10] NPE on picking ship for role which faction doesn't have
« Reply #1 on: December 02, 2018, 08:55:48 AM »

Thank you, fixed! Really appreciate you making it so easy to reproduce.

(I wonder why this isn't happening anywhere in vanilla... hmm. Well, I guess that doesn't matter too much.)
Logged