Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.97a is out! (02/02/24); New blog post: Simulator Enhancements (03/13/24)

Pages: 1 ... 6 7 [8]

Author Topic: [0.97a] Officer Extension (0.6.6)  (Read 112707 times)

float

  • Commander
  • ***
  • Posts: 245
    • View Profile
Re: [0.97a] Officer Extension (0.6)
« Reply #105 on: March 06, 2024, 07:30:04 AM »

Woah, you're right, the zip file is empty. It's 170 bytes now... I always check my file sizes and I'm certain it was in the KBs when I uploaded it yesterday. This happened with another mod too where the jar file mysteriously disappeared when I uploaded it to GitHub, pretty strange behavior.

@Blacknsilver,
I can't reproduce this bug. Just to be clear, you are on Starsector 0.97a-RC11, correct? This could happen if you're using an older Starsector version, if FleetEncounterContext is different there.


@Polite Pufferfish,
Can you be more specific about the nature of the bug you're encountering and how it's being triggered?

Edit: added a hotfix to address the empty zip folder issue and to apply a tentative fix for older SS versions / versions where FleetEncounterContext is different, which would potentially cause the issue Blacknsilver mentioned.
« Last Edit: March 06, 2024, 08:12:44 AM by float »
Logged

Tyrialian

  • Ensign
  • *
  • Posts: 1
    • View Profile
Re: [0.97a] Officer Extension (0.6.1)
« Reply #106 on: March 06, 2024, 10:56:06 AM »

Just reporting the crashed log.

4658903 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57)
   at sun.reflect.UnsafeObjectFieldAccessorImpl.get(UnsafeObjectFieldAccessorImpl.java:36)
   at java.lang.reflect.Field.get(Field.java:393)
   at officerextension.FleetListener.modifyDifficultyCalculator(FleetListener.java:55)
   at officerextension.FleetListener.reportShownInteractionDialog(FleetListener.java:71)
   at com.fs.starfarer.campaign.CampaignEngine.reportShowInteractionDialog(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.startEncounterInvolvingPlayerFleet(Unknown Source)
   at com.fs.starfarer.campaign.BaseLocation.advance(Unknown Source)
   at com.fs.starfarer.campaign.StarSystem.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.super(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Thread.java:748)
Logged

float

  • Commander
  • ***
  • Posts: 245
    • View Profile
Re: [0.97a] Officer Extension (0.6.1)
« Reply #107 on: March 06, 2024, 11:26:55 AM »

Just reporting the crashed log.

4658903 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
java.lang.NullPointerException
   at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57)
   at sun.reflect.UnsafeObjectFieldAccessorImpl.get(UnsafeObjectFieldAccessorImpl.java:36)
   at java.lang.reflect.Field.get(Field.java:393)
   at officerextension.FleetListener.modifyDifficultyCalculator(FleetListener.java:55)
   at officerextension.FleetListener.reportShownInteractionDialog(FleetListener.java:71)
   at com.fs.starfarer.campaign.CampaignEngine.reportShowInteractionDialog(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.startEncounterInvolvingPlayerFleet(Unknown Source)
   at com.fs.starfarer.campaign.BaseLocation.advance(Unknown Source)
   at com.fs.starfarer.campaign.StarSystem.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
   at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
   at com.fs.state.AppDriver.begin(Unknown Source)
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher.super(Unknown Source)
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
   at java.lang.Thread.run(Thread.java:748)

This seems to only be possible if an earlier exception happened with a null FleetEncounterContext. Can you look through your log and see if there are any other stack traces? It'd also be helpful to know when and how this crash occurred as I can't reproduce it.

Edit: I have theorized a possible way this could happen: if a mod is using its own extension of FleetInteractionDialogPluginImpl. Hotfixed.
« Last Edit: March 06, 2024, 11:48:02 AM by float »
Logged

Polite Pufferfish

  • Ensign
  • *
  • Posts: 7
    • View Profile
Re: [0.97a] Officer Extension (0.6)
« Reply #108 on: March 06, 2024, 12:04:10 PM »

Can you be more specific about the nature of the bug you're encountering and how it's being triggered?

The bug was happening whenever I encountered a hostile fleet. The moment the game tried to bring up the dialogue options, it would crash.

Whatever you've done, this crash is no longer happening.

Thank you for your timely response.
« Last Edit: March 06, 2024, 06:49:55 PM by Polite Pufferfish »
Logged

Iwe Eri

  • Ensign
  • *
  • Posts: 11
    • View Profile
Re: [0.97a] Officer Extension (0.6.1)
« Reply #109 on: March 06, 2024, 12:14:20 PM »

Hi, the hotfix crashes the game on startup.

Error log:
56446 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.RuntimeException: Error loading [officerextension.campaign.CryopodAwareOfficerLevelUpPlugin]
java.lang.RuntimeException: Error loading [officerextension.campaign.CryopodAwareOfficerLevelUpPlugin]
   at com.fs.starfarer.loading.scripts.ScriptStore$3.run(Unknown Source) ~[port_obf.jar:?]
   at java.base/java.lang.Thread.run(Thread.java:1575) [?:?]
Caused by: java.lang.ClassNotFoundException: officerextension.campaign.CryopodAwareOfficerLevelUpPlugin
   at org.codehaus.janino.JavaSourceClassLoader.findClass(JavaSourceClassLoader.java:183) ~[janino-3.0.12.jar:?]
   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592) ~[?:?]
   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?]
   ... 2 more
Logged

float

  • Commander
  • ***
  • Posts: 245
    • View Profile
Re: [0.97a] Officer Extension (0.6.1)
« Reply #110 on: March 06, 2024, 12:30:33 PM »

Hi, the hotfix crashes the game on startup.

Error log:
56446 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.RuntimeException: Error loading [officerextension.campaign.CryopodAwareOfficerLevelUpPlugin]
java.lang.RuntimeException: Error loading [officerextension.campaign.CryopodAwareOfficerLevelUpPlugin]
   at com.fs.starfarer.loading.scripts.ScriptStore$3.run(Unknown Source) ~[port_obf.jar:?]
   at java.base/java.lang.Thread.run(Thread.java:1575) [?:?]
Caused by: java.lang.ClassNotFoundException: officerextension.campaign.CryopodAwareOfficerLevelUpPlugin
   at org.codehaus.janino.JavaSourceClassLoader.findClass(JavaSourceClassLoader.java:183) ~[janino-3.0.12.jar:?]
   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592) ~[?:?]
   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?]
   ... 2 more

Delete the entire Officer Extension mod folder, then redownload the mod. CryopodAwareOfficerLevelUpPlugin has been removed.
Logged

Iwe Eri

  • Ensign
  • *
  • Posts: 11
    • View Profile
Re: [0.97a] Officer Extension (0.6.1)
« Reply #111 on: March 06, 2024, 12:33:30 PM »



Delete the entire Officer Extension mod folder, then redownload the mod. CryopodAwareOfficerLevelUpPlugin has been removed.

I see, thank you very much
Logged

Blacknsilver

  • Ensign
  • *
  • Posts: 17
    • View Profile
Re: [0.97a] Officer Extension (0.6.1)
« Reply #112 on: March 06, 2024, 09:26:29 PM »

0.6.2 seems to have fixed the issue for me. I am on 0.97 RC11, btw.
Logged

Xex

  • Ensign
  • *
  • Posts: 12
    • View Profile
Re: [0.97a] Officer Extension (0.6.4)
« Reply #113 on: March 09, 2024, 07:14:05 PM »

Crashing when entering or exiting combat.

337815 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.ClassCastException: class officerextension.campaign.ModifiedFleetEncounterContext cannot be cast to class exerelin.campaign.battle.NexFleetEncounterContext (officerextension.campaign.ModifiedFleetEncounterContext and exerelin.campaign.battle.NexFleetEncounterContext are in unnamed module of loader java.net.URLClassLoader @75678e0a)
java.lang.ClassCastException: class officerextension.campaign.ModifiedFleetEncounterContext cannot be cast to class exerelin.campaign.battle.NexFleetEncounterContext (officerextension.campaign.ModifiedFleetEncounterContext and exerelin.campaign.battle.NexFleetEncounterContext are in unnamed module of loader java.net.URLClassLoader @75678e0a)
   at exerelin.campaign.battle.NexFleetInteractionDialogPluginImpl.restoreOrigCaptain s(NexFleetInteractionDialogPluginImpl.java:69) ~[?:?]
   at com.fs.starfarer.api.impl.campaign.FleetInteractionDialogPluginImpl.backFromEng agement(FleetInteractionDialogPluginImpl.java:616) ~[starfarer.api.jar:?]
   at exerelin.campaign.battle.NexFleetInteractionDialogPluginImpl.backFromEngagement(NexFleetInteractionDialogPluginImpl.java:87) ~[?:?]
   at com.fs.starfarer.campaign.CampaignState.prepare(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source) ~[port_obf.jar:?]
   at com.fs.state.AppDriver.begin(Unknown Source) ~[port.common_obf.jar:?]
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.StarfarerLauncher.super(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source) ~[port_obf.jar:?]
   at java.base/java.lang.Thread.run(Thread.java:1575) [?:?]
« Last Edit: March 09, 2024, 07:52:35 PM by Xex »
Logged

float

  • Commander
  • ***
  • Posts: 245
    • View Profile
Re: [0.97a] Officer Extension (0.6.4)
« Reply #114 on: March 09, 2024, 09:19:01 PM »

Crashing when entering or exiting combat.

337815 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.ClassCastException: class officerextension.campaign.ModifiedFleetEncounterContext cannot be cast to class exerelin.campaign.battle.NexFleetEncounterContext (officerextension.campaign.ModifiedFleetEncounterContext and exerelin.campaign.battle.NexFleetEncounterContext are in unnamed module of loader java.net.URLClassLoader @75678e0a)
java.lang.ClassCastException: class officerextension.campaign.ModifiedFleetEncounterContext cannot be cast to class exerelin.campaign.battle.NexFleetEncounterContext (officerextension.campaign.ModifiedFleetEncounterContext and exerelin.campaign.battle.NexFleetEncounterContext are in unnamed module of loader java.net.URLClassLoader @75678e0a)
   at exerelin.campaign.battle.NexFleetInteractionDialogPluginImpl.restoreOrigCaptain s(NexFleetInteractionDialogPluginImpl.java:69) ~[?:?]
   at com.fs.starfarer.api.impl.campaign.FleetInteractionDialogPluginImpl.backFromEng agement(FleetInteractionDialogPluginImpl.java:616) ~[starfarer.api.jar:?]
   at exerelin.campaign.battle.NexFleetInteractionDialogPluginImpl.backFromEngagement(NexFleetInteractionDialogPluginImpl.java:87) ~[?:?]
   at com.fs.starfarer.campaign.CampaignState.prepare(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source) ~[port_obf.jar:?]
   at com.fs.state.AppDriver.begin(Unknown Source) ~[port.common_obf.jar:?]
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.StarfarerLauncher.super(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source) ~[port_obf.jar:?]
   at java.base/java.lang.Thread.run(Thread.java:1575) [?:?]

Well, that's annoying. OK, I think at this point I'll just accept that the modified battle difficulty computation stuff won't be compatible with Nex or any other mod that uses its own FleetEncounterContext. If you have Nex, you'll have to deal with suspended officers causing you to potentially lose battle XP.
Logged

Xex

  • Ensign
  • *
  • Posts: 12
    • View Profile
Re: [0.97a] Officer Extension (0.6.4)
« Reply #115 on: March 09, 2024, 10:47:18 PM »

Crashing when entering or exiting combat.

337815 [Thread-2] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.ClassCastException: class officerextension.campaign.ModifiedFleetEncounterContext cannot be cast to class exerelin.campaign.battle.NexFleetEncounterContext (officerextension.campaign.ModifiedFleetEncounterContext and exerelin.campaign.battle.NexFleetEncounterContext are in unnamed module of loader java.net.URLClassLoader @75678e0a)
java.lang.ClassCastException: class officerextension.campaign.ModifiedFleetEncounterContext cannot be cast to class exerelin.campaign.battle.NexFleetEncounterContext (officerextension.campaign.ModifiedFleetEncounterContext and exerelin.campaign.battle.NexFleetEncounterContext are in unnamed module of loader java.net.URLClassLoader @75678e0a)
   at exerelin.campaign.battle.NexFleetInteractionDialogPluginImpl.restoreOrigCaptain s(NexFleetInteractionDialogPluginImpl.java:69) ~[?:?]
   at com.fs.starfarer.api.impl.campaign.FleetInteractionDialogPluginImpl.backFromEng agement(FleetInteractionDialogPluginImpl.java:616) ~[starfarer.api.jar:?]
   at exerelin.campaign.battle.NexFleetInteractionDialogPluginImpl.backFromEngagement(NexFleetInteractionDialogPluginImpl.java:87) ~[?:?]
   at com.fs.starfarer.campaign.CampaignState.prepare(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.BaseGameState.traverse(Unknown Source) ~[port_obf.jar:?]
   at com.fs.state.AppDriver.begin(Unknown Source) ~[port.common_obf.jar:?]
   at com.fs.starfarer.combat.CombatMain.main(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.StarfarerLauncher.super(Unknown Source) ~[port_obf.jar:?]
   at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source) ~[port_obf.jar:?]
   at java.base/java.lang.Thread.run(Thread.java:1575) [?:?]

Well, that's annoying. OK, I think at this point I'll just accept that the modified battle difficulty computation stuff won't be compatible with Nex or any other mod that uses its own FleetEncounterContext. If you have Nex, you'll have to deal with suspended officers causing you to potentially lose battle XP.

I appreciate the quick fix! I'm sorry things aren't working out how you wanted. Great mod!
Logged

Selfcontrol

  • Commander
  • ***
  • Posts: 102
    • View Profile
Re: [0.97a] Officer Extension (0.6.5)
« Reply #116 on: March 10, 2024, 05:33:18 AM »

Hi.

The changes made to skills in version 0.97 and to officers (the introduction of "templates") lead to numerous bugs when trying to respec a level 7 officer. In 0.97, level 7 officers are using the new template system and they have 5 elite skills (while a normal officer can only reach level 6 -with Officer Training- with a maximum of 3 elite skills -with Officer Training and Cybernetic Augmentation-).

Trying to demote a level 7 officer (to respecialize him) causes him to lose between 1 or 5 (!) maximum elite skills forever, regardless of the skills the player already possesses. However, this bug has some quirks to it : the number of elite skills you lose forever depends on the already elite skills you made the officer forget.

1. Exemple 1 : my legendary officer has 5 elite skills and 2 non elite skills. I make him only forget his 2 non elite skills. He still has a maximum of 5 elite skills ;
2. Exemple 2 : same officer. I make him forget his 2 non elite skills and 1 elite skill. Because I made him forget 1 elite skill, he will now have a maximum of 4 elite skills even though I leveled him up to 7 again (lost 1 elite skill forever) ;
3. Exemple 3 : same officer. This time, I make him forget 2 non elite skills and 3 elite skills. He will now have a maximum of 2 elite skills max.

Trying to circumvent this bug by first making all elite skills non elite through retraining and then demoting the officer, also doesn't work. As soon as you do this, your officer sort-of loses his "legendary" property and he becomes a regular officer with only 1 elite skill (with a maximum level 7). You can still get 2 extra elite skills with Officer Training and Cybernetic Augmentation, but you cannot get back to a maximum of 5 elite skills.
Logged

float

  • Commander
  • ***
  • Posts: 245
    • View Profile
Re: [0.97a] Officer Extension (0.6.5)
« Reply #117 on: March 10, 2024, 09:31:27 AM »

Hi.

The changes made to skills in version 0.97 and to officers (the introduction of "templates") lead to numerous bugs when trying to respec a level 7 officer. In 0.97, level 7 officers are using the new template system and they have 5 elite skills (while a normal officer can only reach level 6 -with Officer Training- with a maximum of 3 elite skills -with Officer Training and Cybernetic Augmentation-).

Trying to demote a level 7 officer (to respecialize him) causes him to lose between 1 or 5 (!) maximum elite skills forever, regardless of the skills the player already possesses. However, this bug has some quirks to it : the number of elite skills you lose forever depends on the already elite skills you made the officer forget.

1. Exemple 1 : my legendary officer has 5 elite skills and 2 non elite skills. I make him only forget his 2 non elite skills. He still has a maximum of 5 elite skills ;
2. Exemple 2 : same officer. I make him forget his 2 non elite skills and 1 elite skill. Because I made him forget 1 elite skill, he will now have a maximum of 4 elite skills even though I leveled him up to 7 again (lost 1 elite skill forever) ;
3. Exemple 3 : same officer. This time, I make him forget 2 non elite skills and 3 elite skills. He will now have a maximum of 2 elite skills max.

Trying to circumvent this bug by first making all elite skills non elite through retraining and then demoting the officer, also doesn't work. As soon as you do this, your officer sort-of loses his "legendary" property and he becomes a regular officer with only 1 elite skill (with a maximum level 7). You can still get 2 extra elite skills with Officer Training and Cybernetic Augmentation, but you cannot get back to a maximum of 5 elite skills.
Thanks for the report, fixed this. Also added a console command to locate said level 7 officers, mostly for my own use so that I can actually test them properly, but I think players may find this command helpful as well.
Logged

delta4873

  • Ensign
  • *
  • Posts: 2
    • View Profile
Re: [0.97a] Officer Extension (0.6.6)
« Reply #118 on: March 18, 2024, 07:47:24 PM »

Really enjoy the mod so far, would it be possible to get a button to unassign all officers currently assigned to ships?
Logged

Rudragun

  • Ensign
  • *
  • Posts: 11
    • View Profile
Re: [0.97a] Officer Extension (0.6.6)
« Reply #119 on: March 24, 2024, 09:48:09 AM »

Love this mod. Would like if you could also change how many skills an officer could select from upon level-up as I would prefer to have all skills available than promote/demote until I get the one I need.
Logged
Pages: 1 ... 6 7 [8]