Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[xenoargh]

I'd like JSONS to be able to Inherit, rather than id.equals --> overwrite.  Basically, if id.equals, then use JSONObject.has() to check the fields / JSONArrays that are present, and overwrite only where there isn't a match with the existing data. 

This works for Settings.json, but it doesn't work for .wpn, .proj, .ship, .skin, .variant etc.- the engine crashes if all of the required fields aren't present.  A "inherits" Boolean might be the way here.

This issue with how the JSONs are not inheritable, even though the data in the game is inherently able to support it, keeps coming up for me, now that I'm not working on a TC where I can control all the data going in. 

Inheritance might produce weird results depending on load-order (something I've also had to work around, and honestly I think should get addressed, but it's a much bigger feature request) but I feel that it's preferable to the alternative, where Mod X wants to tweak Variable A but Mod Y wants to tweak Variable B, with no conflicts between them, other than the engine

[Alex]

This works for Settings.json, but it doesn't work for .wpn, .proj, .ship, .skin, .variant etc.- the engine crashes if all of the required fields aren't present.

Are you sure? Taking a quick look at .wpn file loading, the game does the same thing as it does for settings and merges stuff. Same for skins and ships and variants.

Doesn't seem to for projectiles, though - fixed that up.

[xenoargh]

I just tried it for a .wpn here:

Code

{
	"id":"annihilator",

	"projectileSpecId":"annihilator_rocket2",

}

Game crashes; says that specClass can't be found.

This is basically what I'm looking for, btw; just altering the key lines, leaving the rest of the data at Vanilla values (partly future-proofing of the FX system where that's practical).

[Alex]

Maybe it's complaining about annihilator_rocket2 not being found?

(If you could knock together a mini-mod to reproduce the crash, I'd love to take a look.)

[xenoargh]

Definitely not that.  I'll put one together immediately

[xenoargh]

OK, here's a mod that demonstrates this.  Causes a crash if loaded with just Vanilla here.

[Alex]

Getting an http 500 trying to download it.

[xenoargh]

Oops.  Fixed!

[Alex]

Aha, thank you! It was broken further up the line than I was looking - it was indeed trying to merge files, but was using absolute paths (rather than relative to mod location) and so was only finding one copy of said files. Fixed it up across the board - variants, hulls, skills, weapons, projectiles.

[xenoargh]

Thank you!  That will mean I can get rid of a ton of hassles