Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Wyvern]

As per usual for me, I've got mods running (and this was also after a marathon eight hour game session to look around for possible memory leaks, so I had jvisualvm attached as well) - but the stack trace looks pretty vanilla to me.

Code

 29027631 [Thread-35] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Saving progress: 0.9993528
 29027638 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Saving stage 3
 29027638 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Saving stage 4
 29027638 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Saving stage 6
 29027647 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Saving stage 7
 29027648 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Saving stage 8
 29027648 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 9
 29027648 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 10
 29027648 [Thread-35] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Saving progress: 1.0
 29027648 [Thread-35] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Releasing context
 29027648 [Thread-35] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Released context
 29027648 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 11
 29027648 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 12
 29027648 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 13
 29027648 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 14
 29027652 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 15
 29027652 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Loading stage 16
 29027652 [Thread-6] INFO  com.fs.starfarer.campaign.save.CampaignGameManager  - Finished saving
 29027753 [Thread-6] INFO  sound.O  - Cleaning up music with id [miscallenous_corvus_campaign_music.ogg]
 29028041 [Thread-6] ERROR com.fs.starfarer.combat.CombatMain  - java.lang.NullPointerException
 java.lang.NullPointerException
	at com.fs.starfarer.api.impl.campaign.CargoPodsEntityPlugin.updateBaseMaxDays(CargoPodsEntityPlugin.java:79)
	at com.fs.starfarer.api.impl.campaign.CargoPodsEntityPlugin.advance(CargoPodsEntityPlugin.java:68)
	at com.fs.starfarer.campaign.CustomCampaignEntity.advance(Unknown Source)
	at com.fs.starfarer.campaign.BaseLocation.advance(Unknown Source)
	at com.fs.starfarer.campaign.StarSystem.advance(Unknown Source)
	at com.fs.starfarer.campaign.CampaignEngine.advance(Unknown Source)
	at com.fs.starfarer.campaign.CampaignState.advance(Unknown Source)
	at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
	at com.fs.state.AppDriver.begin(Unknown Source)
	at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
	at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
	at java.lang.Thread.run(Thread.java:744)

Looks like it did, in fact, save, though.  And loading up the save doesn't immediately crash, either.

[Alex]

Thanks for the report! This came up some time back and is fixed for .1.

Thank you for looking for leaks, too, I really appreciate that.

[Wyvern]

I'm sure it'll make you feel better to know that I didn't find any, then!

(I mean, okay, I can't say for sure that there are -no- leaks - but I can say that, with the mods I was using, there were no leaks that had an appreciable impact across eight hours of wandering around hunting bounty fleets; memory in use never grew above about 2GB, and memory in use immediately after running GC never grew above about 500MB.)

[Alex]

A bit - it does crash from OOM while saving now and again, though. If you ever manage to get it to crash with an OutOfMemory, what'd be really helpful is a heap dump taken while the error message window is still up. If that's actually possible; not 100% sure that you can get a heap dump using jvisualvm at that point.

Same deal if you notice any progress bar stuttering/unusual behavior while saving or loading - those are usually indicative of a leak.