Fractal Softworks Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Starsector 0.9.1a is out! (05/10/19); Blog post: Personal Contacts (08/13/20)

Pages: 1 ... 5 6 [7] 8 9

Author Topic: [0.9.1a] Combat Analytics & Detailed Combat Results v4.6.1 (2020-05-25)  (Read 97383 times)

Captain Trek

  • Lieutenant
  • **
  • Posts: 62
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.4 (2019-08-18)
« Reply #90 on: November 20, 2019, 04:21:53 PM »

I noticed a curious bug - damage dealt by the heavy pulsar cannon weapon from Interstellar Imperium is not kept track of, reading as zero even though I quite specifically watched my ship blaze away at the enemy station with it.
Logged

Nick XR

  • Captain
  • ****
  • Posts: 413
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.4 (2019-08-18)
« Reply #91 on: November 20, 2019, 08:04:30 PM »

I noticed a curious bug - damage dealt by the heavy pulsar cannon weapon from Interstellar Imperium is not kept track of, reading as zero even though I quite specifically watched my ship blaze away at the enemy station with it.
Thanks for the report!  Unfortunately I can't fix this until the next version of starsector because of how onhit things work in this version.

Haalon

  • Ensign
  • *
  • Posts: 1
    • View Profile
    • Email
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.4 (2019-08-18)
« Reply #92 on: December 12, 2019, 12:17:48 PM »

I noticed that Invocation from ORA shows up much more damage than it has actually done.
That may be due to the main projectile splitting into several lighter ones.

I think same happens with Vindicator's siege cannon from SWP.
Logged

Nick XR

  • Captain
  • ****
  • Posts: 413
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.4 (2019-08-18)
« Reply #93 on: December 12, 2019, 08:17:41 PM »

Testing a fix for it, being a little cautious since last time I tried to fix this I broke other stuff.

Nick XR

  • Captain
  • ****
  • Posts: 413
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.4 (2019-08-18)
« Reply #94 on: December 15, 2019, 10:05:04 AM »

I noticed that Invocation from ORA shows up much more damage than it has actually done.
That may be due to the main projectile splitting into several lighter ones.

I think same happens with Vindicator's siege cannon from SWP.

Fix for this is live in Version 4.5

intrinsic_parity

  • Admiral
  • *****
  • Posts: 1393
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #95 on: December 22, 2019, 11:04:21 PM »

I've noticed that damage done by the plasma cannons on my odyssey is not being counted. Is this a known bug?
Logged

Nick XR

  • Captain
  • ****
  • Posts: 413
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #96 on: December 23, 2019, 09:56:04 AM »

I've noticed that damage done by the plasma cannons on my odyssey is not being counted. Is this a known bug?

Yeah, known issue.  The root of the problem is some weapons do damage based on an explosion that doesn't have a source so there's no way to trace back to which weapon & ship actually did the damage :/   In the next version of StarSector this should be fixable based on some work that Alex has done with an event driven damage model.

Avanitia

  • Lieutenant
  • **
  • Posts: 84
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #97 on: January 09, 2020, 03:52:03 PM »

Hey, 4.5 version of Combat Analytics somehow doubles damage dealt by weapons - it affect all weapons from quick testing.

Spoiler
[close]

Left shot is from Hypervelocity Driver.
It should deal... 275 base x 2.0 x 1.4 (target's shield) = 770 on shield, while it deals 1540 on screenshot.
Right shot is from Heavy Mauler.
It should deal... 200 base x 0.5 x 1.4 = 140 on shield, while it deals 280 on screenshot.
« Last Edit: January 09, 2020, 04:24:38 PM by Avanitia »
Logged

Nick XR

  • Captain
  • ****
  • Posts: 413
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #98 on: January 09, 2020, 10:09:42 PM »

Hey, 4.5 version of Combat Analytics somehow doubles damage dealt by weapons - it affect all weapons from quick testing.

Spoiler
[close]

Left shot is from Hypervelocity Driver.
It should deal... 275 base x 2.0 x 1.4 (target's shield) = 770 on shield, while it deals 1540 on screenshot.
Right shot is from Heavy Mauler.
It should deal... 200 base x 0.5 x 1.4 = 140 on shield, while it deals 280 on screenshot.

Interesting, thanks for the solid repro, I'll check it out!

Vayra

  • Admiral
  • *****
  • Posts: 581
  • jangala delenda est
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #99 on: January 10, 2020, 01:00:54 PM »

It's this call, line 338 of EveryFrameDamageDetector.java in version 4.5 and later:

Code: java
        ret.setMultiplier(1); // default multiple is 0 :shrug:

For some reason, that multiplier is additive I guess. Tested by confirming 4.3 and 4.4 do not double damage while 4.5 does, pulling the 4.5 source, and rebuilding with that line commented out - which resolves the issue.
« Last Edit: January 10, 2020, 01:07:10 PM by Vayra »
Logged
Kadur Remnant: http://fractalsoftworks.com/forum/index.php?topic=6649
Vayra's Sector: http://fractalsoftworks.com/forum/index.php?topic=16058
Vayra's Ship Pack: http://fractalsoftworks.com/forum/index.php?topic=16059

im gonna push jangala into the sun i swear to god im gonna do it

Nick XR

  • Captain
  • ****
  • Posts: 413
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #100 on: January 10, 2020, 02:59:09 PM »

It's this call, line 338 of EveryFrameDamageDetector.java in version 4.5 and later:

Code: java
        ret.setMultiplier(1); // default multiple is 0 :shrug:

For some reason, that multiplier is additive I guess. Tested by confirming 4.3 and 4.4 do not double damage while 4.5 does, pulling the 4.5 source, and rebuilding with that line commented out - which resolves the issue.

Thanks for tracking it down explicitly Vayra.
Hmmm, but that was the change that fixed the issue with some weapons dealing the incorrect amount of damage (sub munitions vs parent munitions).

This is like shoveling frogs into a bucket. :'(

Rasip

  • Ensign
  • *
  • Posts: 30
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #101 on: January 15, 2020, 07:34:38 PM »

Thanks. This will make figuring out why some ships seem to perform much better/worse than expected easier.
Logged

Donahue

  • Ensign
  • *
  • Posts: 12
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #102 on: January 22, 2020, 07:43:45 AM »

Is there a way for me to get rid of old combat reports cluttering up the pirates section of the intelligence UI?
Logged

Nick XR

  • Captain
  • ****
  • Posts: 413
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #103 on: January 22, 2020, 10:06:34 AM »

Is there a way for me to get rid of old combat reports cluttering up the pirates section of the intelligence UI?

The entries by default age out after 730 days, if you'd like them to age out faster you can edit the file 'CombatAnalyticsSettings.ini' in the root of the CombatAnalytics mod folder.  But there's no "X" to dismiss/close them I'm afraid.

Vayra

  • Admiral
  • *****
  • Posts: 581
  • jangala delenda est
    • View Profile
Re: [0.9.1a] Combat Analytics & Detailed Combat Results v4.5 (2019-12-15)
« Reply #104 on: January 30, 2020, 08:04:57 PM »

Any chance of an update soon, even a reversion? I think doubling actual damage dealt is a slightly bigger issue than inaccurate submunition analytics... unless that also affected actual damage? :-[
Logged
Kadur Remnant: http://fractalsoftworks.com/forum/index.php?topic=6649
Vayra's Sector: http://fractalsoftworks.com/forum/index.php?topic=16058
Vayra's Ship Pack: http://fractalsoftworks.com/forum/index.php?topic=16059

im gonna push jangala into the sun i swear to god im gonna do it
Pages: 1 ... 5 6 [7] 8 9