Fractal Softworks Forum

Please login or register.

Login with username, password and session length

Author Topic: [0.7.2a] Procurement mission NPEs if pirates have no markets  (Read 1727 times)

Histidine

  • Admiral
  • *****
  • Posts: 4682
    • View Profile
    • GitHub profile
[0.7.2a] Procurement mission NPEs if pirates have no markets
« on: March 30, 2016, 05:12:28 AM »

MarketProcurementMissionEvent.createPirateFleet() calls FleetFactoryV2.createFleet(). It doesn't include a market in the params, so createFleet() calls pickMarket().

Code: java
	public static CampaignFleetAPI createFleet(FleetParams params) {
Global.getSettings().profilerBegin("FleetFactoryV2.createFleet()");
try {

MarketAPI market = pickMarket(params);
if (market == null) return null;

There are no pirate markets, so pickMarket() will return null. Since market is null, createFleet() returns null.

Back to MarketProcurementMissionEvent.createPirateFleet(), line 215:
Code: java
		Misc.setFlagWithReason(fleet.getMemoryWithoutUpdate(), MemFlags.MEMORY_KEY_LOW_REP_IMPACT, "mpm", true, 10000);	// fleet is null; boom
Logged

Alex

  • Administrator
  • Admiral
  • *****
  • Posts: 24118
    • View Profile
Re: [0.7.2a] Procurement mission NPEs if pirates have no markets
« Reply #1 on: March 30, 2016, 09:36:14 AM »

Ahh, oops. Thank you, fixed that up.
Logged