106
Mods / Re: [0.96a] Persean Chronicles, a quest mod (updated 2023-07-23)
« on: July 24, 2023, 08:20:36 AM »looks like there's yet another post-telos combat crash. it seems to be the same crash reported by papasan. relevant logs:SpoilerCode844729 [Thread-3] INFO wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleScript - Telos battle ended. Did player win? false
844754 [Thread-3] INFO com.fs.starfarer.loading.LoadingUtils - Loading JSON from [DIRECTORY: C:\Program Files (x86)\Fractal Softworks\Starsector\starsector-core\..\mods\Nexerelin (data/config/exerelin/factionTraits.json)]
844758 [Thread-3] INFO exerelin.campaign.StatsTracker - Tracker tracking battle
846191 [Thread-3] ERROR com.fs.starfarer.combat.CombatMain - java.lang.NullPointerException
java.lang.NullPointerException
at progsmod.data.campaign.EngagementListener.reportBattleFinished(EngagementListener.java:62)
at com.fs.starfarer.campaign.CampaignEngine.reportBattleFinished(Unknown Source)
at wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleScript.onTelosBattleEnded(Telos2BattleScript.kt:203)
at wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleScript.advance(Telos2BattleScript.kt:172)
at com.fs.starfarer.title.Object.for$Oo.o00000(Unknown Source)
at com.fs.starfarer.combat.super.new.super(Unknown Source)
at com.fs.starfarer.combat.CombatEngine.advanceInner(Unknown Source)
at com.fs.starfarer.combat.CombatEngine.advance(Unknown Source)
at com.fs.starfarer.combat.CombatState.traverse(Unknown Source)
at com.fs.state.AppDriver.begin(Unknown Source)
at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
at java.lang.Thread.run(Thread.java:750)[close]
Huh, this is different; the other was, well, not caused by Nex, but surfaced by it...I was doing something weird that vanilla allowed but Nex didn't. That's probably the same situation here, but with Progressive S-Mods.
there's also an issue with ship loadouts, apparently, though it doesn't seem to be related to the crash.I'm pretty sure these are fine, as long as they aren't causing any issues in the battle. I saw warnings that look like the same thing.there were over 60 of these refit errors, though i only grabbed the first ones that were discernably differentSpoilerCode568968 [Thread-3] WARN wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleCoordinator - Unable to refit null 36f43ae.
java.lang.NullPointerException
at wisp.questgiver.wispLib.ExtensionsKt.refit(Extensions.kt:451)
at wisp.questgiver.wispLib.ExtensionsKt.refit$default(Extensions.kt:419)
at wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleCoordinator.createInitialEnemyFleet(Telos2BattleCoordinator.kt:181)
at wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleCoordinator.startBattle(Telos2BattleCoordinator.kt:97)
at wisp.perseanchronicles.telos.pt2_dart.Telos2SecondLandingDialog$14$1$1.invoke(Telos2SecondLandingDialog.kt:129)
at wisp.perseanchronicles.telos.pt2_dart.Telos2SecondLandingDialog$14$1$1.invoke(Telos2SecondLandingDialog.kt:127)
at wisp.questgiver.v2.json.PagesFromJson$1$4$1$1.invoke(PagesFromJson.kt:118)
at wisp.questgiver.v2.json.PagesFromJson$1$4$1$1.invoke(PagesFromJson.kt:116)
at wisp.questgiver.v2.InteractionDialogLogic$PageNavigator.onOptionSelected(InteractionDialogLogic.kt:215)
at wisp.questgiver.v2.InteractionDialog.optionSelected(InteractionDialog.kt:55)
at com.fs.starfarer.ui.newui.classsuper$1.o00000(Unknown Source)
at com.fs.starfarer.ui.newui.OoOO.actionPerformed(Unknown Source)
at com.fs.starfarer.ui.n.buttonPressed(Unknown Source)
at com.fs.starfarer.ui.I.Ò00000(Unknown Source)
at com.fs.starfarer.ui.I.processInput(Unknown Source)
at com.fs.starfarer.ui.W.super(Unknown Source)
at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
at com.fs.state.AppDriver.begin(Unknown Source)
at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
at java.lang.Thread.run(Thread.java:750)
---
[Thread-3] WARN wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleScript - Unable to refit null 36f4167.
java.lang.NullPointerException
at wisp.questgiver.wispLib.ExtensionsKt.refit(Extensions.kt:451)
at wisp.questgiver.wispLib.ExtensionsKt.refit$default(Extensions.kt:419)
at wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleCoordinator.createEugelFleetReinforcements(Telos2BattleCoordinator.kt:229)
at wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleScript.<init>(Telos2BattleScript.kt:29)
at wisp.perseanchronicles.telos.pt2_dart.battle.Telos2BattleCoordinator.startBattle(Telos2BattleCoordinator.kt:112)
at wisp.perseanchronicles.telos.pt2_dart.Telos2SecondLandingDialog$14$1$1.invoke(Telos2SecondLandingDialog.kt:129)
at wisp.perseanchronicles.telos.pt2_dart.Telos2SecondLandingDialog$14$1$1.invoke(Telos2SecondLandingDialog.kt:127)
at wisp.questgiver.v2.json.PagesFromJson$1$4$1$1.invoke(PagesFromJson.kt:118)
at wisp.questgiver.v2.json.PagesFromJson$1$4$1$1.invoke(PagesFromJson.kt:116)
at wisp.questgiver.v2.InteractionDialogLogic$PageNavigator.onOptionSelected(InteractionDialogLogic.kt:215)
at wisp.questgiver.v2.InteractionDialog.optionSelected(InteractionDialog.kt:55)
at com.fs.starfarer.ui.newui.classsuper$1.o00000(Unknown Source)
at com.fs.starfarer.ui.newui.OoOO.actionPerformed(Unknown Source)
at com.fs.starfarer.ui.n.buttonPressed(Unknown Source)
at com.fs.starfarer.ui.I.Ò00000(Unknown Source)
at com.fs.starfarer.ui.I.processInput(Unknown Source)
at com.fs.starfarer.ui.W.super(Unknown Source)
at com.fs.starfarer.BaseGameState.traverse(Unknown Source)
at com.fs.state.AppDriver.begin(Unknown Source)
at com.fs.starfarer.combat.CombatMain.main(Unknown Source)
at com.fs.starfarer.StarfarerLauncher.o00000(Unknown Source)
at com.fs.starfarer.StarfarerLauncher$1.run(Unknown Source)
at java.lang.Thread.run(Thread.java:750)[close]
edit: additional note. there's a moment between defeating the initial fleet and eugel spawning in where it's possible to end combat early, though this just takes you back to the previous <relive combat> dialogue, where you can restart the combat as per usual. it doesn't crash the game if you do this, though. maybe eugel's related to the crash in some way?
telos quest was started during 3.0.6 using console commands, though i only started doing the quest after upgrading to 3.0.7
the 3.0.6 folder was deleted before extracting 3.0.7
nexerelin is enabled, random sector is not
Did you have devmode on? I'll double-check, but when I tested before, you couldn't end combat early. It is possible that in fixing the code interaction with Nex, I broke this.
Thank you for the reports! I don't love bugs, but it's much much better than having them and not knowing